yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: yahns-public@yhbt.net
Subject: [PATCH 1/4] test_buffer_tmpdir: drop fragile assertions
Date: Thu, 22 Dec 2022 09:02:08 +0000	[thread overview]
Message-ID: <20221222090211.9056-2-bofh@yhbt.net> (raw)
In-Reply-To: <20221222090211.9056-1-bofh@yhbt.net>

When tweaking buffer sizes, another IN_CREATE event can
happen soon after the delete.
---
 test/test_buffer_tmpdir.rb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/test_buffer_tmpdir.rb b/test/test_buffer_tmpdir.rb
index bac8017..39029ed 100644
--- a/test/test_buffer_tmpdir.rb
+++ b/test/test_buffer_tmpdir.rb
@@ -67,7 +67,6 @@ def test_output_buffer_tmpdir
       event = @ino.take
       assert_equal [:DELETE], event.events
       assert_equal name, event.name
-      refute File.exist?("#@tmpdir/#{name}")
     end
   ensure
     c.close if c
@@ -101,7 +100,6 @@ def input_buffer(btype)
       event = ino.take
       assert_equal [:DELETE], event.events
       assert_equal name, event.name
-      refute File.exist?("#{tmpdir}/#{name}")
     end
   ensure
     c.close if c

  reply	other threads:[~2022-12-22  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22  9:02 [PATCH 0/4] a few forgotten patches from last year Eric Wong
2022-12-22  9:02 ` Eric Wong [this message]
2022-12-22  9:02 ` [PATCH 2/4] http_response: clamp body read size Eric Wong
2022-12-22  9:02 ` [PATCH 3/4] standardize on 16384-byte reads Eric Wong
2022-12-22  9:02 ` [PATCH 4/4] test/test_ssl: workaround multi-line exception messages Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221222090211.9056-2-bofh@yhbt.net \
    --to=bofh@yhbt.net \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).