yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: yahns-public@yhbt.net
Subject: [PATCH 2/2] test/test_extras_exec_cgi: drop Rack::ContentLength
Date: Sun, 25 Dec 2022 12:23:51 +0000	[thread overview]
Message-ID: <20221225122351.4799-3-bofh@yhbt.net> (raw)
In-Reply-To: <20221225122351.4799-1-bofh@yhbt.net>

It is causing _blocked_zombie to fail on rtype=11 due to the
addition of Content-Length making the client persistent when
we didn't actually want it to be (for the test).
 test/test_extras_exec_cgi.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/test_extras_exec_cgi.rb b/test/test_extras_exec_cgi.rb
index 426409d..4fa928d 100644
--- a/test/test_extras_exec_cgi.rb
+++ b/test/test_extras_exec_cgi.rb
@@ -136,7 +136,7 @@ def _blocked_zombie(block_on, rtype)
       Yahns::HttpClient.__send__(:include, TrywriteBlocked)
       require './extras/exec_cgi'
       cfg.instance_eval do
-        stack = Rack::ContentLength.new(Rack::Chunked.new(ExecCgi.new(RUNME)))
+        stack = Rack::Chunked.new(ExecCgi.new(RUNME))
         app(:rack, stack) { listen "#{host}:#{port}" }
         stderr_path err.path
         worker_processes 1
@@ -170,6 +170,7 @@ def _blocked_zombie(block_on, rtype)
         assert_match %r{\A\d+\n\z}, body
         exec_pid = body.to_i
         poke_until_dead exec_pid
+        # lack of Content-Length should trigger EOF here:
         assert_raises(EOFError) { c.readpartial(666) }
         raise "BUG in test, bad rtype"

      parent reply	other threads:[~2022-12-25 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 12:23 [PATCH 0/2] exec_cgi: fix compat with newer Rack 2 Eric Wong
2022-12-25 12:23 ` [PATCH 1/2] extras/exec_cgi: fix for newer Rack::ContentLength Eric Wong
2022-12-25 12:23 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221225122351.4799-3-bofh@yhbt.net \
    --to=bofh@yhbt.net \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).