* [PATCH 1/4] response: drop clients after HTTP responses of unknown length
2016-08-03 3:19 5% [PATCH 0/4] remove chunked/Content-Length requirement from apps Eric Wong
@ 2016-08-03 3:19 7% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2016-08-03 3:19 UTC (permalink / raw)
To: yahns-public
Clients are not able to handle persistent connections unless
the client knows the length of the response.
---
lib/yahns/http_response.rb | 6 ++++++
| 4 +---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index 88ff9f9..f2d9c62 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -126,6 +126,7 @@ def http_response_write(status, headers, body, hdr_only)
k = self.class
alive = @hs.next? && k.persistent_connections
flags = MSG_DONTWAIT
+ term = false
if @hs.headers?
code = status.to_i
@@ -147,14 +148,19 @@ def http_response_write(status, headers, body, hdr_only)
# allow Rack apps to tell us they want to drop the client
alive = false if value =~ /\bclose\b/i
when %r{\AContent-Length\z}i
+ term = true
flags |= MSG_MORE if value.to_i > 0 && !hdr_only
kv_str(buf, key, value)
+ when %r{\ATransfer-Encoding\z}i
+ term = true if value =~ /\bchunked\b/i
+ kv_str(buf, key, value)
when "rack.hijack"
hijack = value
else
kv_str(buf, key, value)
end
end
+ alive &&= term
buf << (alive ? "Connection: keep-alive\r\n\r\n".freeze
: "Connection: close\r\n\r\n".freeze)
case rv = kgio_syssend(buf, flags)
--git a/test/test_extras_exec_cgi.rb b/test/test_extras_exec_cgi.rb
index f9b96d9..3c71fd4 100644
--- a/test/test_extras_exec_cgi.rb
+++ b/test/test_extras_exec_cgi.rb
@@ -169,10 +169,8 @@ def _blocked_zombie(block_on, rtype)
assert_match %r{200 OK}, head
assert_match %r{\A\d+\n\z}, body
exec_pid = body.to_i
- assert_raises(Errno::EAGAIN, IO::WaitReadable) { c.read_nonblock(666) }
poke_until_dead exec_pid
- # still alive?
- assert_raises(Errno::EAGAIN, IO::WaitReadable) { c.read_nonblock(666) }
+ assert_raises(EOFError) { c.read_nonblock(666) }
else
raise "BUG in test, bad rtype"
end
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/4] remove chunked/Content-Length requirement from apps
@ 2016-08-03 3:19 5% Eric Wong
2016-08-03 3:19 7% ` [PATCH 1/4] response: drop clients after HTTP responses of unknown length Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2016-08-03 3:19 UTC (permalink / raw)
To: yahns-public
This better aligns with behavior of other real-world Rack
servers such as puma and Thin. We will also now use kgio writev
functionality to speed up writing "Transfer-Encoding: chunked"
to avoid string copies or extra syscalls for other chunking
solutions.
See [PATCH 3/4] for a small informal benchmark.
4 changes
response: drop clients after HTTP responses of unknown length
response: reduce stack overhead for parameter passing
response: support auto-chunking for HTTP/1.1
Revert "document Rack::Chunked/ContentLength semi-requirements"
Documentation/yahns-rackup.pod | 10 -------
examples/yahns_rack_basic.conf.rb | 6 -----
lib/yahns/chunk_body.rb | 27 +++++++++++++++++++
lib/yahns/http_client.rb | 24 ++++++++---------
lib/yahns/http_response.rb | 47 +++++++++++++++++++++++---------
test/test_auto_chunk.rb | 56 +++++++++++++++++++++++++++++++++++++++
test/test_extras_exec_cgi.rb | 4 +--
7 files changed, 130 insertions(+), 44 deletions(-)
create mode 100644 lib/yahns/chunk_body.rb
create mode 100644 test/test_auto_chunk.rb
--
EW
^ permalink raw reply [relevance 5%]
* [ANN] yahns 1.13.0 -_- sleepy app server for Ruby
@ 2016-08-05 7:44 4% Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2016-08-05 7:44 UTC (permalink / raw)
To: ruby-talk; +Cc: yahns-public
A Free Software, multi-threaded, non-blocking network
application server designed for low _idle_ power consumption.
It is primarily optimized for applications with occasional users
which see little or no traffic. yahns currently hosts Rack/HTTP
applications, but may eventually support other application
types. Unlike some existing servers, yahns is extremely
sensitive to fatal bugs in the applications it hosts.
* git clone git://yhbt.net/yahns
* https://yahns.yhbt.net/README
* https://yahns.yhbt.net/NEWS.atom.xml
* we only accept plain-text email yahns-public@yhbt.net
* and archive all the mail we receive: https://yhbt.net/yahns-public/
* nntp://news.public-inbox.org/inbox.comp.lang.ruby.yahns
lrg nabgure ubeevoyl-anzrq freire :>
Changes:
yahns 1.13.0 - some user-visible improvements...
And probably a billion new regressions!
yahns now allows users to skip the Rack::Head, Rack::Chunked and
Rack::ContentLength middlewares to ease migrating from/to other
real-world Rack HTTP servers. Most notably, our chunked
encoding implementation is a bit faster than Rack::Chunked by
taking advantage of the writev(2) syscall:
https://yhbt.net/yahns-public/20160803031906.14553-4-e@80x24.org/
There's also rack 2.x fixes in the test case and extras/ section
(these incompatibilities did not affect existing users unless
they use the wonky extras/ section).
There's also some graceful shutdown fixes, the process title is
now changed to display the number of live FDs.
Of course, there's the usual round of documentation improvements
which are systemd and OpenSSL setup-related this time around.
However, the majority of changes (proxy_*, wbuf_lite), affect
currently-unadvertised functionality which is subject to removal
or incompatible config changes. However, they are used to serve
our mailing list archives at:
https://yhbt.net/yahns-public/
49 changes since yahns 1.12.5:
proxy_pass: simplify writing request bodies upstream
proxy_pass: hoist out proxy_res_headers method
proxy_pass: simplify proxy_http_response
proxy_pass: split out body and trailer reading in response
proxy_pass: trim down proxy_response_finish, too
proxy_pass: split out req_res into a separate file
proxy_pass: fix resumes after complete buffering is unblocked
proxy_pass: X-Forwarded-For appends to existing list
proxy_pass: pass entire object to proxy_http_response
proxy_pass: support "proxy_buffering: false"
proxy_pass: remove unnecessary rescue
req_res: store proxy_pass object here, instead
proxy_pass: redo "proxy_buffering: false"
wbuf: remove needless "busy" parameter
Merge branch 'maint'
extras/try_gzip_static: do not show backtrace on syscall errors
wbuf: remove tmpdir parameter
wbuf_lite: fix write retries for OpenSSL sockets
test_proxy_pass_no_buffering: fix racy test
queue_*: check for closed IO objects
cleanup graceful shutdown handling
proxy_pass: more descriptive error messages
proxy_pass: fix HTTP/1.0 backends on EOF w/o buffering
wbuf_common: reset offset counter when done
extras/try_gzip_static: resolve symlinks
test_ssl: remove unnecessary priv_key DH parameter
openssl_client: wrap shutdown for graceful termination
proxy_pass: keep trailer buffer on blocked client writes
proxy_pass: avoid TOCTTOU race when unbuffering, too
proxy_pass: avoid accessing logger in env after hijacking
proxy_pass: avoid stuck responses in "proxy_buffering: false"
extras: include status messages in responses
update init and add systemd examples
test_proxy_pass_no_buffering: exclude rb/ru files, too
wbuf_lite: use StringIO instead of TmpIO
wbuf_lite: truncate StringIO when done
wbuf_lite: prevent clobbering responses
wbuf_lite: unify EOF error handling
wbuf_lite: reset sf_offset/sf_count consistently
wbuf_lite: clear @busy flag when re-arming
http_response: drop bodies for non-compliant responses
fix rack 2.x compatibility bugs
doc: add session cache usage to OpenSSL example
test: skip some buffering tests on non-default values
response: drop clients after HTTP responses of unknown length
response: reduce stack overhead for parameter passing
response: support auto-chunking for HTTP/1.1
Revert "document Rack::Chunked/ContentLength semi-requirements"
extras/exec_cgi: fix for HTTPoxy vulnerability
Please note the disclaimer:
yahns is extremely sensitive to fatal bugs in the apps it hosts. There
is no (and never will be) any built-in "watchdog"-type feature to kill
stuck processes/threads. Each yahns process may be handling thousands
of clients; unexpectedly killing the process will abort _all_ of those
connections. Lives may be lost!
yahns hackers are not responsible for your application/library bugs.
Use an application server which is tolerant of buggy applications
if you cannot be bothered to fix all your fatal bugs.
--
EW
^ permalink raw reply [relevance 4%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2016-08-03 3:19 5% [PATCH 0/4] remove chunked/Content-Length requirement from apps Eric Wong
2016-08-03 3:19 7% ` [PATCH 1/4] response: drop clients after HTTP responses of unknown length Eric Wong
2016-08-05 7:44 4% [ANN] yahns 1.13.0 -_- sleepy app server for Ruby Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).