* [ANN] yahns 1.6.0 -_- sleepy app server for Ruby
@ 2015-03-09 9:49 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-03-09 9:49 UTC (permalink / raw)
To: ruby-talk, yahns-public
A Free Software, multi-threaded, non-blocking network application server
designed for low _idle_ power consumption. It is primarily optimized
for applications with occasional users which see little or no traffic.
yahns currently hosts Rack/HTTP applications, but may eventually support
other application types. Unlike some existing servers, yahns is
extremely sensitive to fatal bugs in the applications it hosts.
Changes: reduced allocations and bugfixes
This release fixes a bug where previously-configured-but-now-removed
listeners were inherited across USR2 upgrades are not shutdown
immediately in the child.
There are also minor reductions in allocations which can save a few
hundred bytes statically and also whenever write buffering is necessary
for large responses.
Some minor documentation updates improvements in extras, too.
shortlog of changes since 1.5.0:
README: add link to mailing list archives
test_ssl: factor out server SSLContext creation
doc: add design_notes document
reduce File::Stat object allocations
update comments about wbuf_close return values
wbuf: lazily (re)create temporary file
fix compatibility with unicorn.git
skip tests requiring String#b on 1.9.3
use the monotonic clock under Ruby 2.1+
favor Class.new for method-less classes
extras/proxy_pass: save memory in String#split arg
extras/proxy_pass: do not name unused variable
extras/proxy_pass: log exceptions leading to 502
extras/proxy_pass: flesh out upload support + tests
acceptor: close inherited-but-unneeded sockets
See the git repository for more: git clone git://yhbt.net/yahns
Please note the disclaimer:
yahns is extremely sensitive to fatal bugs in the apps it hosts. There
is no (and never will be) any built-in "watchdog"-type feature to kill
stuck processes/threads. Each yahns process may be handling thousands
of clients; unexpectedly killing the process will abort _all_ of those
connections. Lives may be lost!
yahns hackers are not responsible for your application/library bugs.
Use an application server which is tolerant of buggy applications
if you cannot be bothered to fix all your fatal bugs.
* git clone git://yhbt.net/yahns
* http://yahns.yhbt.net/README
* http://yahns.yhbt.net/NEWS.atom.xml
* we like plain-text email yahns-public@yhbt.net
* and archive all the mail we receive: http://yhbt.net/yahns-public/
lrg nabgure ubeevoyl-anzrq freire
lrf, lnuaf vf frys-ubfgvat vgf bja fvgrf fvapr yngr 2013
^ permalink raw reply [relevance 7%]
* [PATCH] acceptor: close inherited-but-unneeded sockets
@ 2015-03-09 4:46 6% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2015-03-09 4:46 UTC (permalink / raw)
To: yahns-public
When inheriting sockets from the parent via YAHNS_FD, we must close
sockets ASAP if they are unconfigured in the child. This bug exists
in yahns (and not unicorn) because of the trickier shutdown routine
we do for blocking accept system calls to work reliably with the
threading support in mainline Ruby 2.x. This bug would not exist
in a purely C server using blocking accept, either.
---
I'll probably release 1.6.0 in a few hours with this and what's been
sitting in master since the last release. If there's more risk-averse
users, maybe a 1.5.1 with just this patch is warranted, but I doubt
it (abguvat nobhg lnuaf vf sbe gur evfx-nirefr pebjq :P).
Eric Wong (15):
README: add link to mailing list archives
test_ssl: factor out server SSLContext creation
doc: add design_notes document
reduce File::Stat object allocations
update comments about wbuf_close return values
wbuf: lazily (re)create temporary file
fix compatibility with unicorn.git
skip tests requiring String#b on 1.9.3
use the monotonic clock under Ruby 2.1+
favor Class.new for method-less classes
extras/proxy_pass: save memory in String#split arg
extras/proxy_pass: do not name unused variable
extras/proxy_pass: log exceptions leading to 502
extras/proxy_pass: flesh out upload support + tests
acceptor: close inherited-but-unneeded sockets
lib/yahns/acceptor.rb | 5 ++++-
test/test_server.rb | 39 +++++++++++++++++++++++++++++++++++++++
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/lib/yahns/acceptor.rb b/lib/yahns/acceptor.rb
index cd9e055..0cebea2 100644
--- a/lib/yahns/acceptor.rb
+++ b/lib/yahns/acceptor.rb
@@ -19,7 +19,10 @@ module Yahns::Acceptor # :nodoc:
# just keep looping this on every acceptor until the associated thread dies
def ac_quit
- return true unless defined?(@thrs)
+ unless defined?(@thrs) # acceptor has not started yet, freshly inherited
+ close
+ return true
+ end
@thrs.each { |t| t[:yahns_quit] = true }
return true if __ac_quit_done?
diff --git a/test/test_server.rb b/test/test_server.rb
index 69babb3..b7cb3e6 100644
--- a/test/test_server.rb
+++ b/test/test_server.rb
@@ -804,4 +804,43 @@ class TestServer < Testcase
ensure
quit_wait(pid)
end
+
+ def test_inherit_too_many
+ err = @err
+ s2 = TCPServer.new(ENV["TEST_HOST"] || "127.0.0.1", 0)
+ cfg = Yahns::Config.new
+ host, port = @srv.addr[3], @srv.addr[1]
+ cfg.instance_eval do
+ ru = lambda { |_| [ 200, {'Content-Length'=>'2'}, ['HI'] ] }
+ GTL.synchronize { app(:rack, ru) { listen "#{host}:#{port}" } }
+ logger(Logger.new(err.path))
+ end
+ mkserver(cfg, @srv) do
+ s2.autoclose = false
+ ENV["YAHNS_FD"] = "#{@srv.fileno},#{s2.fileno}"
+ end
+ run_client(host, port) { |res| assert_equal "HI", res.body }
+ th = Thread.new do
+ c = s2.accept
+ c.readpartial(1234)
+ c.write "HTTP/1.0 666 OK\r\n\r\nGO AWAY"
+ c.close
+ :OK
+ end
+ Thread.pass
+ s2host, s2port = s2.addr[3], s2.addr[1]
+ Net::HTTP.start(s2host, s2port) do |http|
+ res = http.request(Net::HTTP::Get.new("/"))
+ assert_equal 666, res.code.to_i
+ assert_equal "GO AWAY", res.body
+ end
+ assert_equal :OK, th.value
+ tmpc = TCPSocket.new(s2host, s2port)
+ a2 = s2.accept
+ assert_nil IO.select([a2], nil, nil, 0.05)
+ tmpc.close
+ assert_nil a2.read(1)
+ a2.close
+ s2.close
+ end
end
--
EW
^ permalink raw reply related [relevance 6%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-03-09 4:46 6% [PATCH] acceptor: close inherited-but-unneeded sockets Eric Wong
2015-03-09 9:49 7% [ANN] yahns 1.6.0 -_- sleepy app server for Ruby Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).