From: "Lin Jen-Shin (godfat)" <godfat@godfat.org>
To: Eric Wong <e@80x24.org>
Cc: yahns-public@yhbt.net
Subject: Re: -1 shutdown_timeout?
Date: Wed, 23 Sep 2015 17:10:41 +0800 [thread overview]
Message-ID: <CAA2_N1vSQsZDHVijzxaU4zLzP2BX9gQ1Gv5BovB-ZHP2ofQW8A@mail.gmail.com> (raw)
In-Reply-To: <20150923083025.GA22196@dcvr.yhbt.net>
On Wed, Sep 23, 2015 at 4:30 PM, Eric Wong <e@80x24.org> wrote:
> "Lin Jen-Shin (godfat)" <godfat@godfat.org> wrote:
>> However instead of setting shutdown_timeout, I think I would probably
>> need to make the application know that the server is shutting down,
>> and stop right there instead of waiting for full 60 seconds.
>>
>> Not sure if I could do this without talking to yahns directly...
>
> This is a Rack app? I really don't want to introduce custom APIs for
> this which would lock Rack users down to yahns.
Yes this is a Rack app. I totally understand locking down to a specific
webserver would not be so good, but sometimes I really want to
make the best tweak so I'm personally ok with some specific
configuration, especially given that I realized switching to a different
server could mean some other configuration should be changed as well.
The most recent example is database connection pool size.
With a threading server, I could set the size to a very large number,
but for a forking server like Unicorn, the size should be much
lower. So to switch servers, we already need to make a few changes
accordingly. (detecting would be even more works :()
> I suppose you could chain signal handlers, though:
>
> orig_quit = nil
> orig_quit = trap(:QUIT) do
> app_specific_quit
> orig_quit.call
> end
>
> (Ditto for TERM/INT, totally untested)
Just tried it, but not sure where to put this.
With preload=true, yahns is trapping later than
the application. Maybe I should just set it to false
since we're not forking anyway...
next prev parent reply other threads:[~2015-09-23 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 7:25 -1 shutdown_timeout? Lin Jen-Shin (godfat)
2015-09-23 8:05 ` Eric Wong
2015-09-23 8:19 ` Lin Jen-Shin (godfat)
2015-09-23 8:30 ` Eric Wong
2015-09-23 9:10 ` Lin Jen-Shin (godfat) [this message]
2015-09-23 9:31 ` Eric Wong
2015-09-23 9:49 ` Lin Jen-Shin (godfat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA2_N1vSQsZDHVijzxaU4zLzP2BX9gQ1Gv5BovB-ZHP2ofQW8A@mail.gmail.com \
--to=godfat@godfat.org \
--cc=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).