From: "Lin Jen-Shin (godfat)" <email@example.com>
Subject: Re: [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb
Date: Sat, 8 Dec 2018 19:52:52 +0800 [thread overview]
Message-ID: <CAA2_N1vxBb42SP8yyHbb3-pTwEQ6YHRDFMk1kEdOMia6rJ3PUA@mail.gmail.com> (raw)
On Sat, Dec 8, 2018 at 7:36 PM Eric Wong <firstname.lastname@example.org> wrote:
> Thanks for both patches, applied to https://yhbt.net/yahns.git
> Anything else? Might tag a release, soon.
No, so far it's working great locally for me, thank you! I am very
happy I can use yahns on Mac OSX now. So much easier to develop (and
promote to the other developers)
Previously I have no idea why but sleepy_penguin has some compile
error which I can't figure out how to fix, and it really looks like
it's Ruby's bug. They probably fixed it on one of the recent Ruby
patch releases, and it works fine after the `closed?` patch.
It's unrelated but I am happy that yahns quits gracefully upon
receiving SIGINT, while unicorn quits forcefully. I thought I might
try to add something to the application to eliminate the difference,
but since I could just run yahns everywhere I don't have to now.
> Getting rid of kgio is going to be a bit of work...
This really comes with a long way, and on the bright side, we're
moving forward :) Thank you for all the works!
next prev parent reply other threads:[~2018-12-08 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 8:30 [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb Lin Jen-Shin
2018-12-08 8:30 ` [PATCH 2/2] @srv.shutdown could raise Errno::ENOTCONN Lin Jen-Shin
2018-12-08 11:36 ` [PATCH 1/2] Add QueueQuitter#closed? to queue_quitter_pipe.rb Eric Wong
2018-12-08 11:52 ` Lin Jen-Shin (godfat) [this message]
2018-12-08 17:20 ` Eric Wong
2018-12-09 8:49 ` Lin Jen-Shin (godfat)
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).