about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-12-29 06:47:49 +0000
committerEric Wong <e@80x24.org>2016-12-29 06:47:49 +0000
commitba79ebb9164fdc64767ec75bf10bfb5e9e7c24ef (patch)
tree8299b08f1d44ba2fd4785cc08a820c1b47b9a6a4
parentbbb966daa6772a8497911cc00c6aff2f673e62bb (diff)
downloadyahns-ba79ebb9164fdc64767ec75bf10bfb5e9e7c24ef.tar.gz
When entering StreamInput#read, it is common for @rbuf to
be drained and empty, meaning a simple String#clear can
be used in place of a more complex String#slice! String#replace
combo on an empty @rbuf.

While we're at it, we'll avoid an extra instructions for calling
`@rbuf.size` by storing the size in a local.
-rw-r--r--lib/yahns/stream_input.rb5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/yahns/stream_input.rb b/lib/yahns/stream_input.rb
index 496faa2..a6190fc 100644
--- a/lib/yahns/stream_input.rb
+++ b/lib/yahns/stream_input.rb
@@ -43,8 +43,9 @@ class Yahns::StreamInput # :nodoc:
         length < 0 and raise ArgumentError, "negative length #{length} given"
         rv.replace(@rbuf.slice!(0, length))
       else
-        to_read = length - @rbuf.size
-        rv.replace(@rbuf.slice!(0, @rbuf.size))
+        cur = @rbuf.size
+        to_read = length - cur
+        cur == 0 ? rv.clear : rv.replace(@rbuf.slice!(0, cur))
         until to_read == 0 || eof? || (rv.size > 0 && @chunked)
           @client.yahns_read(to_read, @buf) or eof!
           filter_body(@rbuf, @buf)