about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2018-12-08 11:37:06 +0000
committerEric Wong <e@80x24.org>2018-12-08 11:38:19 +0000
commitdbadf731d06a79cdae7afd23f4c20fb8fbb9c07e (patch)
tree5797a606a13ce3315b6f74dbe1561da24ac8236a
parent59550b6ee9a4c801a7c44e9bd2ba29037d45b561 (diff)
downloadyahns-dbadf731d06a79cdae7afd23f4c20fb8fbb9c07e.tar.gz
Without sendfile, we can hit EOFError on IO#pread
if a file we're serving gets truncated mid-response.
This was causing test_truncated_sendfile failures;
but I didn't notice before because I forgot to set
SENDFILE_BROKEN=1 to disable the test.
-rw-r--r--lib/yahns/http_client.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/yahns/http_client.rb b/lib/yahns/http_client.rb
index d55a0db..8744053 100644
--- a/lib/yahns/http_client.rb
+++ b/lib/yahns/http_client.rb
@@ -332,7 +332,6 @@ class Yahns::HttpClient < Kgio::Socket # :nodoc:
       io.read(count, buf)
     end
   rescue EOFError
-    warn "BUG: do_pread overreach:\n #{caller.join("\n ")}\n"
     nil
   end