extras/*: log full backtraces for errors

In case we have bugs, this can help us find bugs in our code.

1 files changed, 6 insertions, 3 deletions

diff --git a/extras/autoindex.rb b/extras/autoindex.rb
index b868a5c..9ce6c61 100644
--- a/extras/autoindex.rb
+++ b/extras/autoindex.rb
@@ -112,15 +112,18 @@ class Autoindex
   rescue Errno::ENOENT, Errno::ENOTDIR # from Dir.open
     r(404)
   rescue => e
-    r(500, e.message, env)
+    r(500, e, env)
   ensure
     dir.close if dir
   end
 
   def r(code, msg = nil, env = nil)
-    if env && logger = env["rack.logger"]
+    if env && exc && logger = env["rack.logger"]
+      msg = exc.message
+      msg = msg.dump if /[[:cntrl:]]/ =~ msg # prevent code injection
       logger.warn("#{env['REQUEST_METHOD']} #{env['PATH_INFO']} " \
-                  "#{code} #{msg.inspect}")
+                  "#{code} #{msg}")
+      exc.backtrace.each { |line| logger.warn(line) }
     end
 
     if Rack::Utils::STATUS_WITH_NO_ENTITY_BODY.include?(code)