From 36f89035e0631f529d748a053b5f8d899279d198 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Wed, 22 Apr 2015 00:36:51 +0000 Subject: config: avoid unnecessary binmode call We may set binary mode upon open by passing "b" in the mode string, so avoid the extra method dispatch and bytecode/cache overhead that entails. --- lib/yahns/config.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/yahns/config.rb') diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb index 9db0d59..f4164a9 100644 --- a/lib/yahns/config.rb +++ b/lib/yahns/config.rb @@ -400,9 +400,8 @@ class Yahns::Config # :nodoc: var = _check_in_block(:app, :errors) if String === val # we've already bound working_directory by the time we get here - val = File.open(File.expand_path(val), "a") + val = File.open(File.expand_path(val), "ab") val.close_on_exec = val.sync = true - val.binmode else rt = [ :puts, :write, :flush ] # match Rack::Lint rt.all? { |m| val.respond_to?(m) } or raise ArgumentError, -- cgit v1.2.3-24-ge0c7