From bb774680aae0a827f887761b18da304aa94111cc Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 4 Jan 2016 10:56:14 +0000 Subject: use String#clear for short-lived buffers we create This should reduce memory pressure slightly as we can have finer-grained control of memory usage for buffers which can be several kilobytes large. It is not safe to do this for output buffers we get from the application, as they may reuse that memory themselves. --- lib/yahns/http_response.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'lib/yahns/http_response.rb') diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb index 292fab7..4b36db2 100644 --- a/lib/yahns/http_response.rb +++ b/lib/yahns/http_response.rb @@ -162,11 +162,13 @@ module Yahns::HttpResponse # :nodoc: : "Connection: close\r\n\r\n".freeze) case rv = kgio_syssend(buf, flags) when nil # all done, likely + buf.clear + buf = nil # recycle any memory we used ASAP break when String flags = MSG_DONTWAIT - buf = rv # hope the skb grows - when :wait_writable, :wait_readable + buf = rv # unlikely, hope the skb grows + when :wait_writable, :wait_readable # unlikely if k.output_buffering alive = hijack ? hijack : alive rv = response_header_blocked(rv, buf, body, alive, offset, count) -- cgit v1.2.3-24-ge0c7