All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Umang Jain <umang.jain@ideasonboard.com>
To: Stefan Wahren <wahrenst@gmx.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] staging: vchiq_core: Drop unnecessary blank lines
Date: Sun, 21 Apr 2024 14:25:20 +0530	[thread overview]
Message-ID: <16ca5177-d899-4d09-b601-1b553ce4b791@ideasonboard.com> (raw)
In-Reply-To: <20240420115351.27713-4-wahrenst@gmx.net>

Hi Stefan,

Thank you for the patch

On 20/04/24 5:23 pm, Stefan Wahren wrote:
> chechpatch.pl noticed

s/chechpatch.pl/checkpatch.pl
>
> CHECK: Please don't use multiple blank lines
>
> So drop them.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 58451ee08abc..ca32902afe06 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -1190,7 +1190,6 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service,
>   	header->size = size;
>   	header->msgid = msgid;
>
> -
>   	svc_fourcc = service ? service->base.fourcc
>   			     : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
>
> @@ -1616,7 +1615,6 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header)
>   		break;
>   	}
>
> -
>   	svc_fourcc = service ? service->base.fourcc
>   			     : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
>
> --
> 2.34.1
>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Umang Jain <umang.jain@ideasonboard.com>
To: Stefan Wahren <wahrenst@gmx.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] staging: vchiq_core: Drop unnecessary blank lines
Date: Sun, 21 Apr 2024 14:25:20 +0530	[thread overview]
Message-ID: <16ca5177-d899-4d09-b601-1b553ce4b791@ideasonboard.com> (raw)
In-Reply-To: <20240420115351.27713-4-wahrenst@gmx.net>

Hi Stefan,

Thank you for the patch

On 20/04/24 5:23 pm, Stefan Wahren wrote:
> chechpatch.pl noticed

s/chechpatch.pl/checkpatch.pl
>
> CHECK: Please don't use multiple blank lines
>
> So drop them.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 58451ee08abc..ca32902afe06 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -1190,7 +1190,6 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service,
>   	header->size = size;
>   	header->msgid = msgid;
>
> -
>   	svc_fourcc = service ? service->base.fourcc
>   			     : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
>
> @@ -1616,7 +1615,6 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header)
>   		break;
>   	}
>
> -
>   	svc_fourcc = service ? service->base.fourcc
>   			     : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
>
> --
> 2.34.1
>


  reply	other threads:[~2024-04-21  8:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-20 11:53 [PATCH 0/4] staging: vchiq_core: Minor clean-ups Stefan Wahren
2024-04-20 11:53 ` Stefan Wahren
2024-04-20 11:53 ` [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Stefan Wahren
2024-04-20 11:53   ` Stefan Wahren
2024-04-21  8:53   ` Umang Jain
2024-04-21  8:53     ` Umang Jain
2024-04-20 11:53 ` [PATCH 2/4] staging: vchiq_core: Add parentheses to VCHIQ_MSG_SRCPORT Stefan Wahren
2024-04-20 11:53   ` Stefan Wahren
2024-04-21  8:54   ` Umang Jain
2024-04-21  8:54     ` Umang Jain
2024-04-20 11:53 ` [PATCH 3/4] staging: vchiq_core: Drop unnecessary blank lines Stefan Wahren
2024-04-20 11:53   ` Stefan Wahren
2024-04-21  8:55   ` Umang Jain [this message]
2024-04-21  8:55     ` Umang Jain
2024-04-20 11:53 ` [PATCH 4/4] staging: vchiq_core: Add missing " Stefan Wahren
2024-04-20 11:53   ` Stefan Wahren
2024-04-21  8:55   ` Umang Jain
2024-04-21  8:55     ` Umang Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16ca5177-d899-4d09-b601-1b553ce4b791@ideasonboard.com \
    --to=umang.jain@ideasonboard.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.