From: "Ryan Walklin" <ryan@testtoast.com>
To: "Chris Morgan" <macromorgan@hotmail.com>,
"Andre Przywara" <andre.przywara@arm.com>
Cc: "Chen-Yu Tsai" <wens@csie.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 4/5] arm64: dts: allwinner: h700: Add RG35XX-H DTS
Date: Sun, 21 Apr 2024 20:18:44 +1200 [thread overview]
Message-ID: <9ed7fbbd-44dc-451d-a800-01bef205cebc@app.fastmail.com> (raw)
In-Reply-To: <DM4PR05MB9229B7D4654478D28D1BC2B6A5132@DM4PR05MB9229.namprd05.prod.outlook.com>
On Sun, 21 Apr 2024, at 3:09 PM, Chris Morgan wrote:
Thanks for the review and all the work on the regulators!
>>
>> Is there any reason to not just use the existing gpio-keys node?
>> Either put a label on it in patch 2/5, and reference that below,
>> outside of the root node, or use an absolute path reference.
>
> I would also second just putting an alias and adding these to it.
> I myself as a preference tend to set the GPIO volume buttons as
> a seperate node only so I can enable key repeat on them, otherwise
> one node is best.
>
Thanks, have split the volume keys out and merged the thumbsticks into the existing node.
>
> After extensive testing with a multimeter and fudging the regulator
> voltages up or down, I've been able to figure out the regulator
> assignments for each of the different power domains. Schematics would
> have helped, but sadly this had to be done the hard way. Based on
> past experience with Anbernic I would strongly suspect all devices
> have this assignment, but I know for sure my 35XXH does.
>
> vcc-pa-supply = <®_cldo3>;
> vcc-pc-supply = <®_cldo3>;
> vcc-pe-supply = <®_cldo3>;
> vcc-pf-supply = <®_cldo3>;
> vcc-pg-supply = <®_aldo4>;
> vcc-ph-supply = <®_cldo3>;
> vcc-pi-supply = <®_cldo3>;
>
> On my board the reg_cldo3 is a constant 3.3v output, and the reg_aldo4
> is a constant 1.8v output.
>
Nice work! These work well in my testing.
>
> I haven't figured out the boost regulator yet, but for the host port
> I've been able to ascertain there's no less than 2 GPIO controlled
> regulators in play. PE5 must be driven high or the USB host port will
> not power on at all. If PE5 is driven high then the port kicks on, but
> at 3.3v. Once I also enable PI7 the port then reaches 4.6v. I'm not sure
> how to get it to a proper 5v yet, I'm still working that part out.
>
Thanks for working all that out, will hold off any other changes for now.
Ryan
next prev parent reply other threads:[~2024-04-21 8:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 10:43 [PATCH v2 0/5] arm64: dts: allwinner: Add Anbernic RG35XX (Plus/H/2024) support Ryan Walklin
2024-04-20 10:43 ` [PATCH v2 1/5] dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants Ryan Walklin
2024-04-20 10:43 ` [PATCH v2 2/5] arm64: dts: allwinner: h700: Add RG35XX 2024 DTS Ryan Walklin
2024-04-20 10:59 ` Krzysztof Kozlowski
2024-04-21 2:05 ` Ryan Walklin
2024-04-21 0:49 ` Andre Przywara
2024-04-21 2:28 ` Ryan Walklin
2024-04-22 10:17 ` Andre Przywara
2024-04-21 4:00 ` Chris Morgan
2024-04-21 8:43 ` Ryan Walklin
2024-04-22 12:34 ` Andre Przywara
2024-04-22 11:06 ` Andre Przywara
2024-04-21 20:01 ` Jernej Škrabec
2024-04-20 10:43 ` [PATCH v2 3/5] arm64: dts: allwinner: h700: Add RG35XX-Plus DTS Ryan Walklin
2024-04-21 0:53 ` Andre Przywara
2024-04-21 16:53 ` Chris Morgan
2024-04-20 10:43 ` [PATCH v2 4/5] arm64: dts: allwinner: h700: Add RG35XX-H DTS Ryan Walklin
2024-04-21 1:06 ` Andre Przywara
2024-04-21 3:09 ` Chris Morgan
2024-04-21 8:18 ` Ryan Walklin [this message]
2024-04-22 10:17 ` Andre Przywara
2024-04-20 10:43 ` [PATCH v2 5/5] arm64: dts: allwinner: h700: Add RG35XX DTBs to Makefile Ryan Walklin
2024-04-21 1:07 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ed7fbbd-44dc-451d-a800-01bef205cebc@app.fastmail.com \
--to=ryan@testtoast.com \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macromorgan@hotmail.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.