From: Herbert Xu <herbert@gondor.apana.org.au>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: davem@davemloft.net, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] crypto: atmel-sha204a - remove unused includes
Date: Fri, 3 May 2024 18:42:23 +0800 [thread overview]
Message-ID: <ZjS_j-s6F2h3jflL@gondor.apana.org.au> (raw)
In-Reply-To: <20240427001439.12726-3-l.rubusch@gmail.com>
On Sat, Apr 27, 2024 at 12:14:36AM +0000, Lothar Rubusch wrote:
> Remove unnecessarily included headers.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> ---
> drivers/crypto/atmel-sha204a.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index c77f482d2..5c3fef6e9 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -5,17 +5,8 @@
> * Copyright (c) 2019 Linaro, Ltd. <ard.biesheuvel@linaro.org>
> */
>
> -#include <linux/delay.h>
> -#include <linux/device.h>
> -#include <linux/err.h>
> -#include <linux/errno.h>
> #include <linux/i2c.h>
> -#include <linux/init.h>
> #include <linux/kernel.h>
> -#include <linux/module.h>
> -#include <linux/scatterlist.h>
> -#include <linux/slab.h>
> -#include <linux/workqueue.h>
> #include "atmel-i2c.h"
These do not seem to be redundant.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
claudiu.beznea@tuxon.dev, linux-crypto@vger.kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] crypto: atmel-sha204a - remove unused includes
Date: Fri, 3 May 2024 18:42:23 +0800 [thread overview]
Message-ID: <ZjS_j-s6F2h3jflL@gondor.apana.org.au> (raw)
In-Reply-To: <20240427001439.12726-3-l.rubusch@gmail.com>
On Sat, Apr 27, 2024 at 12:14:36AM +0000, Lothar Rubusch wrote:
> Remove unnecessarily included headers.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> ---
> drivers/crypto/atmel-sha204a.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index c77f482d2..5c3fef6e9 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -5,17 +5,8 @@
> * Copyright (c) 2019 Linaro, Ltd. <ard.biesheuvel@linaro.org>
> */
>
> -#include <linux/delay.h>
> -#include <linux/device.h>
> -#include <linux/err.h>
> -#include <linux/errno.h>
> #include <linux/i2c.h>
> -#include <linux/init.h>
> #include <linux/kernel.h>
> -#include <linux/module.h>
> -#include <linux/scatterlist.h>
> -#include <linux/slab.h>
> -#include <linux/workqueue.h>
> #include "atmel-i2c.h"
These do not seem to be redundant.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-03 10:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 0:14 [PATCH 0/5] crypto: atmel-sha204a - read out otp zone Lothar Rubusch
2024-04-27 0:14 ` Lothar Rubusch
2024-04-27 0:14 ` [PATCH 1/5] crypto: atmel-i2 - add missing arg description Lothar Rubusch
2024-04-27 0:14 ` Lothar Rubusch
2024-04-27 0:14 ` [PATCH 2/5] crypto: atmel-sha204a - remove unused includes Lothar Rubusch
2024-04-27 0:14 ` Lothar Rubusch
2024-05-03 10:42 ` Herbert Xu [this message]
2024-05-03 10:42 ` Herbert Xu
2024-04-27 0:14 ` [PATCH 3/5] crypto: atmel-i2c - rename read function Lothar Rubusch
2024-04-27 0:14 ` Lothar Rubusch
2024-04-27 0:14 ` [PATCH 4/5] crypto: atmel-sha204a - add reading from otp zone Lothar Rubusch
2024-04-27 0:14 ` Lothar Rubusch
2024-04-27 0:14 ` [PATCH 5/5] crypto: atmel-sha204a - provide the otp content Lothar Rubusch
2024-04-27 0:14 ` Lothar Rubusch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjS_j-s6F2h3jflL@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=l.rubusch@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.