clogger RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: Stefan Sundin <git@stefansundin.com>
Cc: clogger-public@yhbt.net
Subject: Re: v2
Date: Thu, 1 Feb 2024 07:58:21 +0000	[thread overview]
Message-ID: <20240201075821.M727816@dcvr> (raw)
In-Reply-To: <20240128012812.76997-1-git@stefansundin.com>

Stefan Sundin <git@stefansundin.com> wrote:
> Thank you for the review. I think I have addressed most, if
> not all, of the issues.

Thanks, pushed to clogger.git as
commit 6b0768f8791c5d6dd2e8a5aea0da76d46549477e
and 2991f00afa4e445214f3b997bb37cb746c01cd2d

I've also pushed out TypedData memory leak workaround;
might try to fix some deprecation warnings while testing
some other stuff but personal things and storms + water leaks
keep getting in the way :<

> Still learning email based patch workflow, so please feel free
> to let me know if I'm doing anything wrong.

Seems fine :>  If you have documentation improvements to git.git,
I'm sure folks at git@vger.kernel.org would be happy to look at
them :>

      parent reply	other threads:[~2024-02-01  7:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23  3:08 rack 3.x compatibility Stefan Sundin
2024-01-23  3:08 ` [PATCH 1/2] update deprecated license identifier Stefan Sundin
2024-01-23  3:08 ` [PATCH 2/2] rack 3.x compatibility Stefan Sundin
2024-01-23 12:47   ` Eric Wong
2024-01-28  1:22     ` v2 Stefan Sundin
2024-01-28  1:22       ` [PATCH v2 1/2] update deprecated license identifier Stefan Sundin
2024-01-28  1:23       ` [PATCH v2 2/2] rack 3.x compatibility Stefan Sundin
2024-02-02  7:45         ` [PATCH] test_broken_header_response: allow NoMethodError w/ rack 2 Eric Wong
2024-02-01  7:58       ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/clogger/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201075821.M727816@dcvr \
    --to=bofh@yhbt.net \
    --cc=clogger-public@yhbt.net \
    --cc=git@stefansundin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/clogger.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).