cmogstored dev/user discussion/issues/patches/etc
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: cmogstored-public@bogomips.org
Subject: [PATCH] notify.c: workaround epoll_pwait bug in current Linux 5.0/5.1
Date: Sat, 11 May 2019 07:56:30 +0000	[thread overview]
Message-ID: <20190511075630.17811-1-e@80x24.org> (raw)

The bugfix should hit mainline and stable kernels, soon; but
there's no reason for us to be caring if errno is EINTR, or
not...

https://lore.kernel.org/lkml/20190427093319.sgicqik2oqkez3wk@dcvr/
https://lore.kernel.org/lkml/20190507043954.9020-1-deepa.kernel@gmail.com/
---
 notify.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/notify.c b/notify.c
index 73e772a..1deed82 100644
--- a/notify.c
+++ b/notify.c
@@ -100,7 +100,14 @@ void mog_notify_wait(bool need_usage_file)
 	mfd = mog_idleq_wait_intr(mog_notify_queue, timeout);
 	if (mfd)
 		notify_queue_step(mfd);
-	else if (errno == EINTR)
+	else
+		/*
+		 * errno == EINTR, but epoll_pwait on some Linux v5.0+/v5.1+
+		 * fails to return EINTR.  This should be fixed in Linux,
+		 * soon:
+		 * <20190427093319.sgicqik2oqkez3wk@dcvr>
+		 * <20190507043954.9020-1-deepa.kernel@gmail.com>
+		 */
 		note_run();
 }
 
-- 
EW


                 reply	other threads:[~2019-05-11  7:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/cmogstored/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190511075630.17811-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=cmogstored-public@bogomips.org \
    --subject='Re: [PATCH] notify.c: workaround epoll_pwait bug in current Linux 5.0/5.1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	../../cmogstored.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).