From: Hleb Valoshka <375gnu@gmail.com>
To: kgio@librelist.org
Subject: [PATCH] Remove Scope IDs from IPv6 addresses.
Date: Tue, 10 Sep 2013 18:17:41 +0300 [thread overview]
Message-ID: <1378826261-10771-1-git-send-email-375gnu@gmail.com> (raw)
In-Reply-To: <1378826261-10771-1-git-send-email-375gnu@gmail.com>
Scoped ipv6 addresses are defined in rfc4007.
Ruby doesn't support them yet and it's unknown whether it will
(see http://bugs.ruby-lang.org/issues/8464).
So we just remove scope ids.
---
ext/raindrops/linux_inet_diag.c | 49 ++++++++++++++++++++++++++++++++++++---
1 file changed, 46 insertions(+), 3 deletions(-)
diff --git a/ext/raindrops/linux_inet_diag.c b/ext/raindrops/linux_inet_diag.c
index cd4a876..3948c33 100644
--- a/ext/raindrops/linux_inet_diag.c
+++ b/ext/raindrops/linux_inet_diag.c
@@ -134,17 +134,54 @@ static int st_free_data(st_data_t key, st_data_t value, st_data_t ignored)
return ST_DELETE;
}
+/*
+ * call-seq:
+ * remove_scope_id(ipv4_or_ipv6_address)
+ *
+ * Returns copy of IP address with Scope ID removed,
+ * if address has it (only IPv6 actually may have it).
+ *
+ * NOTE: free() must be called on its result.
+ */
+static char* remove_scope_id(const char * addr)
+{
+ char *newaddr, *t;
+
+ newaddr = strdup(addr);
+ if (newaddr == NULL)
+ perror("strdup");
+
+ t = strchr(newaddr, '%');
+
+ if (t != NULL) {
+ *t = '\0';
+ t = strchr(t+1, ']');
+ if (t == NULL)
+ fprintf(stderr, "Bad IPv6 address: %s!\n", addr);
+ else
+ strcat(newaddr, t);
+ }
+
+ return newaddr;
+}
+
static int st_to_hash(st_data_t key, st_data_t value, VALUE hash)
{
struct listen_stats *stats = (struct listen_stats *)value;
if (stats->listener_p) {
- VALUE k = rb_str_new2((const char *)key);
- VALUE v = rb_listen_stats(stats);
+ VALUE k, v;
+ char *xkey = remove_scope_id((const char *)key);
+ if (xkey == NULL)
+ goto get_out;
+ k = rb_str_new2(xkey);
+ v = rb_listen_stats(stats);
+ free(xkey);
OBJ_FREEZE(k);
rb_hash_aset(hash, k, v);
}
+get_out:
return st_free_data(key, value, 0);
}
@@ -153,7 +190,12 @@ static int st_AND_hash(st_data_t key, st_data_t value, VALUE hash)
struct listen_stats *stats = (struct listen_stats *)value;
if (stats->listener_p) {
- VALUE k = rb_str_new2((const char *)key);
+ VALUE k;
+ char *xkey = remove_scope_id((const char *)key);
+ if (xkey == NULL)
+ goto get_out;
+ k = rb_str_new2(xkey);
+ free(xkey);
if (rb_hash_lookup(hash, k) == Qtrue) {
VALUE v = rb_listen_stats(stats);
@@ -161,6 +203,7 @@ static int st_AND_hash(st_data_t key, st_data_t value, VALUE hash)
rb_hash_aset(hash, k, v);
}
}
+get_out:
return st_free_data(key, value, 0);
}
--
1.7.10.4
next parent reply other threads:[~2013-09-10 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 15:17 Hleb Valoshka [this message]
2013-09-10 18:35 ` [PATCH] Remove Scope IDs from IPv6 addresses Eric Wong
2013-09-10 18:37 ` Eric Wong
[not found] <CAAB-Kcmzm4Gr58k2YexCD5+4QYzZJf3HydDRHcSAsoEEut_OFw@mail.gmail.com>
2013-09-12 13:31 ` Hleb Valoshka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/kgio/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378826261-10771-1-git-send-email-375gnu@gmail.com \
--to=375gnu@gmail.com \
--cc=kgio@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).