* Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno
[not found] <3DC9CAC8-5708-4001-B4F1-899D46DA9AC1@gmail.com>
@ 2023-06-11 21:39 ` Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2023-06-11 21:39 UTC (permalink / raw)
To: Jean Boussier; +Cc: samuel.williams, raindrops-public, kgio-public
Jean Boussier <jean.boussier@gmail.com> wrote:
> > the "why"
>
> I think the missing piece here is that this change is necessary for compatibility with the current ruby master:
>
> https://bugs.ruby-lang.org/issues/19057#note-17
Thanks, that's an important note omitted from both original patches.
I've pushed out Samuel's patch as commit
b3212417cc3e7cc44aa9e1ffe89b0d62ef3fdab5 to raindrops.git
with your comment
> kgio seem to have the same code and fail in the same way.
+Cc kgio-public@yhbt.net
I'll take documented patches for kgio, otherwise I'll try to deal with it
before Ruby 3.3 (or when Debian stable ships Ruby 3.3 :P).
I've also posted some raindrops cleanups and modernizations
which should reduce stack frames and binary size for 3.1+
(untested since I don't have space/time for multiple Ruby
installs atm):
https://yhbt.net/raindrops-public/20230611213328.379546-1-bofh@yhbt.net/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-11 21:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <3DC9CAC8-5708-4001-B4F1-899D46DA9AC1@gmail.com>
2023-06-11 21:39 ` [PATCH] Prefer to use rb_io_descriptor in my_fileno Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/kgio.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).