From: Julien Grall <julien.grall@citrix.com> To: <xen-devel@lists.xenproject.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Julien Grall" <julien.grall@linaro.org>, "Julien Grall" <julien.grall@citrix.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "Boris Ostrovsky" <boris.ostrovsky@oracle.com>, "David Vrabel" <david.vrabel@citrix.com> Subject: [PATCH v2 6/7] block/xen-blkfront: Remove invalid comment Date: Wed, 17 Jun 2015 15:28:07 +0100 [thread overview] Message-ID: <1434551288-14113-7-git-send-email-julien.grall@citrix.com> (raw) In-Reply-To: <1434551288-14113-1-git-send-email-julien.grall@citrix.com> From: Julien Grall <julien.grall@linaro.org> Since commit b764915 "xen-blkfront: use a different scatterlist for each request", biovec has been replaced by scatterlist when copying back the data during a completion request. Signed-off-by: Julien Grall <julien.grall@citrix.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: David Vrabel <david.vrabel@citrix.com> --- Changes in v2: - Add Roger's Acked-by --- drivers/block/xen-blkfront.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 5c72c25..60cf1d6 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1056,12 +1056,6 @@ static void blkif_completion(struct blk_shadow *s, struct blkfront_info *info, s->req.u.indirect.nr_segments : s->req.u.rw.nr_segments; if (bret->operation == BLKIF_OP_READ && info->feature_persistent) { - /* - * Copy the data received from the backend into the bvec. - * Since bv_offset can be different than 0, and bv_len different - * than PAGE_SIZE, we have to keep track of the current offset, - * to be sure we are copying the data from the right shared page. - */ for_each_sg(s->sg, sg, nseg, i) { BUG_ON(sg->offset + sg->length > PAGE_SIZE); shared_data = kmap_atomic( -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: julien.grall@citrix.com (Julien Grall) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 6/7] block/xen-blkfront: Remove invalid comment Date: Wed, 17 Jun 2015 15:28:07 +0100 [thread overview] Message-ID: <1434551288-14113-7-git-send-email-julien.grall@citrix.com> (raw) In-Reply-To: <1434551288-14113-1-git-send-email-julien.grall@citrix.com> From: Julien Grall <julien.grall@linaro.org> Since commit b764915 "xen-blkfront: use a different scatterlist for each request", biovec has been replaced by scatterlist when copying back the data during a completion request. Signed-off-by: Julien Grall <julien.grall@citrix.com> Acked-by: Roger Pau Monn? <roger.pau@citrix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: David Vrabel <david.vrabel@citrix.com> --- Changes in v2: - Add Roger's Acked-by --- drivers/block/xen-blkfront.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 5c72c25..60cf1d6 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1056,12 +1056,6 @@ static void blkif_completion(struct blk_shadow *s, struct blkfront_info *info, s->req.u.indirect.nr_segments : s->req.u.rw.nr_segments; if (bret->operation == BLKIF_OP_READ && info->feature_persistent) { - /* - * Copy the data received from the backend into the bvec. - * Since bv_offset can be different than 0, and bv_len different - * than PAGE_SIZE, we have to keep track of the current offset, - * to be sure we are copying the data from the right shared page. - */ for_each_sg(s->sg, sg, nseg, i) { BUG_ON(sg->offset + sg->length > PAGE_SIZE); shared_data = kmap_atomic( -- 2.1.4
next prev parent reply other threads:[~2015-06-17 14:30 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-17 14:28 [PATCH v2 0/7] xen: Clean up Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 1/7] xen: Include xen/page.h rather than asm/xen/page.h Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 2/7] xen/xenbus: client: Fix call of virt_to_mfn in xenbus_grant_ring Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 3/7] xen/grant-table: Remove unused macro SPP Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 4/7] arm/xen: Drop duplicate define mfn_to_virt Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 5/7] block/xen-blkfront: Remove unused macro MAXIMUM_OUTSTANDING_BLOCK_REQS Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 6/7] block/xen-blkfront: Remove invalid comment Julien Grall 2015-06-17 14:28 ` Julien Grall [this message] 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` [PATCH v2 7/7] block/xen-blkback: s/nr_pages/nr_segs/ Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 14:28 ` Julien Grall 2015-06-17 15:36 ` [Xen-devel] [PATCH v2 0/7] xen: Clean up David Vrabel 2015-06-17 15:36 ` David Vrabel 2015-06-17 15:36 ` David Vrabel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1434551288-14113-7-git-send-email-julien.grall@citrix.com \ --to=julien.grall@citrix.com \ --cc=boris.ostrovsky@oracle.com \ --cc=david.vrabel@citrix.com \ --cc=julien.grall@linaro.org \ --cc=konrad.wilk@oracle.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=roger.pau@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.