* [rtc-linux] [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
@ 2015-07-04 18:27 Fabio Estevam
2015-07-04 18:42 ` [rtc-linux] " Alexandre Belloni
2015-07-14 22:05 ` [rtc-linux] " Alexandre Belloni
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2015-07-04 18:27 UTC (permalink / raw)
To: alexandre.belloni; +Cc: gregory.clement, rtc-linux, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Remove the 'flags' variable in order to fix the following warning:
drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/rtc/rtc-armada38x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c
index 4b62d1a..2b08cac 100644
--- a/drivers/rtc/rtc-armada38x.c
+++ b/drivers/rtc/rtc-armada38x.c
@@ -88,7 +88,7 @@ static int armada38x_rtc_set_time(struct device *dev, struct rtc_time *tm)
{
struct armada38x_rtc *rtc = dev_get_drvdata(dev);
int ret = 0;
- unsigned long time, flags;
+ unsigned long time;
ret = rtc_tm_to_time(tm, &time);
--
1.9.1
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
2015-07-04 18:27 [rtc-linux] [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time() Fabio Estevam
@ 2015-07-04 18:42 ` Alexandre Belloni
2015-07-04 18:54 ` Gregory CLEMENT
2015-07-14 22:05 ` [rtc-linux] " Alexandre Belloni
1 sibling, 1 reply; 6+ messages in thread
From: Alexandre Belloni @ 2015-07-04 18:42 UTC (permalink / raw)
To: Fabio Estevam; +Cc: gregory.clement, rtc-linux, Fabio Estevam
Hi Fabio,
On 04/07/2015 at 15:27:34 -0300, Fabio Estevam wrote :
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Remove the 'flags' variable in order to fix the following warning:
>
> drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
>
Thank you but I'm pretty sure that one is fixed (that is the fourth
patch to do so) ;)
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/rtc/rtc-armada38x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c
> index 4b62d1a..2b08cac 100644
> --- a/drivers/rtc/rtc-armada38x.c
> +++ b/drivers/rtc/rtc-armada38x.c
> @@ -88,7 +88,7 @@ static int armada38x_rtc_set_time(struct device *dev, struct rtc_time *tm)
> {
> struct armada38x_rtc *rtc = dev_get_drvdata(dev);
> int ret = 0;
> - unsigned long time, flags;
> + unsigned long time;
>
> ret = rtc_tm_to_time(tm, &time);
>
> --
> 1.9.1
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
2015-07-04 18:42 ` [rtc-linux] " Alexandre Belloni
@ 2015-07-04 18:54 ` Gregory CLEMENT
2015-07-04 19:02 ` Alexandre Belloni
0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2015-07-04 18:54 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Fabio Estevam, rtc-linux, Fabio Estevam
Hi Alexandre,
On 04/07/2015 20:42, Alexandre Belloni wrote:
> Hi Fabio,
>
> On 04/07/2015 at 15:27:34 -0300, Fabio Estevam wrote :
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Remove the 'flags' variable in order to fix the following warning:
>>
>> drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
>>
>
> Thank you but I'm pretty sure that one is fixed (that is the fourth
> patch to do so) ;)
Well, it should be fixed however none of the patch sent were merged in Linus tree yet...
Thanks,
Gregory
>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> drivers/rtc/rtc-armada38x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c
>> index 4b62d1a..2b08cac 100644
>> --- a/drivers/rtc/rtc-armada38x.c
>> +++ b/drivers/rtc/rtc-armada38x.c
>> @@ -88,7 +88,7 @@ static int armada38x_rtc_set_time(struct device *dev, struct rtc_time *tm)
>> {
>> struct armada38x_rtc *rtc = dev_get_drvdata(dev);
>> int ret = 0;
>> - unsigned long time, flags;
>> + unsigned long time;
>>
>> ret = rtc_tm_to_time(tm, &time);
>>
>> --
>> 1.9.1
>>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
2015-07-04 18:54 ` Gregory CLEMENT
@ 2015-07-04 19:02 ` Alexandre Belloni
2015-07-14 13:06 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Belloni @ 2015-07-04 19:02 UTC (permalink / raw)
To: Gregory CLEMENT; +Cc: Fabio Estevam, rtc-linux, Fabio Estevam
Hi,
On 04/07/2015 at 20:54:44 +0200, Gregory CLEMENT wrote :
> Hi Alexandre,
>
> On 04/07/2015 20:42, Alexandre Belloni wrote:
> > Hi Fabio,
> >
> > On 04/07/2015 at 15:27:34 -0300, Fabio Estevam wrote :
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Remove the 'flags' variable in order to fix the following warning:
> >>
> >> drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
> >>
> >
> > Thank you but I'm pretty sure that one is fixed (that is the fourth
> > patch to do so) ;)
>
> Well, it should be fixed however none of the patch sent were merged in Linus tree yet...
>
Hum, okay, I just realized f98b733e93e00365b4df78fbb33c2cad3080f6bb is not fixing it...
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [rtc-linux] Re: [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
2015-07-04 19:02 ` Alexandre Belloni
@ 2015-07-14 13:06 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2015-07-14 13:06 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: Gregory CLEMENT, rtc-linux, Fabio Estevam
On Sat, Jul 4, 2015 at 4:02 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
>
> Hum, okay, I just realized f98b733e93e00365b4df78fbb33c2cad3080f6bb is not fixing it...
Yes, the build warning is still present in linux-next.
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [rtc-linux] [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time()
2015-07-04 18:27 [rtc-linux] [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time() Fabio Estevam
2015-07-04 18:42 ` [rtc-linux] " Alexandre Belloni
@ 2015-07-14 22:05 ` Alexandre Belloni
1 sibling, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2015-07-14 22:05 UTC (permalink / raw)
To: Fabio Estevam; +Cc: gregory.clement, rtc-linux, Fabio Estevam
On 04/07/2015 at 15:27:34 -0300, Fabio Estevam wrote :
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Remove the 'flags' variable in order to fix the following warning:
>
> drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-14 22:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-04 18:27 [rtc-linux] [PATCH] drivers/rtc/rtc-armada38x: Remove unused variable from armada38x_rtc_set_time() Fabio Estevam
2015-07-04 18:42 ` [rtc-linux] " Alexandre Belloni
2015-07-04 18:54 ` Gregory CLEMENT
2015-07-04 19:02 ` Alexandre Belloni
2015-07-14 13:06 ` Fabio Estevam
2015-07-14 22:05 ` [rtc-linux] " Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.