From: Ian Campbell <ian.campbell@citrix.com>
To: Eric Shelton <eshelton@pobox.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com,
wei.liu2@citrix.com, ian.jackson@eu.citrix.com,
samuel.thibault@ens-lyon.org
Subject: Re: [PATCH V3 1/1] libxl: set stub domain size based on VRAM size
Date: Thu, 16 Jul 2015 16:51:43 +0100 [thread overview]
Message-ID: <1437061903.32371.232.camel@citrix.com> (raw)
In-Reply-To: <1436953503.11153.36.camel@citrix.com>
On Wed, 2015-07-15 at 10:45 +0100, Ian Campbell wrote:
> On Sat, 2015-07-11 at 17:30 -0400, Eric Shelton wrote:
> > Allocate additional memory to the stub domain for qemu-traditional if
> > more than 4 MB is assigned to the video adapter to avoid out of memory
> > condition for QEMU.
>
> In reply to v2 (after you'd sent v3, I think) Ian J said:
> > Well, it does also reduce the stubdom memory when the video memory is
> > <4Mby. That sounds plausible to me but at the very least the commit
> > message needs changing, and maybe we should wait a bit to see if one
> > of the qemu experts objects.
>
> libxl__domain_build_info_setdefault ensures, for qemu-xen-traditional,
> that video_memkb is either precisely 4M (TYPE_CIRRUS) or >= 8M
> (TYPE_STD) but allows a free choice for TYPE_NONE, defaulting to 0 (I'd
> almost expect it to insist on 0, but there you are).
>
> I suggest adding a second paragraph to the commit message:
>
> For LIBXL_VGA_INTERFACE_TYPE_STD + CIRRUS video_memkb is always
> at least 4MB. However if LIBXL_VGA_INTERFACE_TYPE_STD is
> selected the video_memkb defaults to 0, resulting in a stubdom
> which is 4MB smaller than before. It seems unlikely that VGA
> disable would require more memory then the other options, so
> this should be ok.
>
> I'm happy to add that while I commit and will Ack + do so tomorrow
> unless somebody objects during today.
Done.
prev parent reply other threads:[~2015-07-16 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 21:30 [PATCH V3 0/1] libxl: set stub domain size based on VRAM size Eric Shelton
2015-07-11 21:30 ` [PATCH V3 1/1] " Eric Shelton
2015-07-14 8:51 ` George Dunlap
2015-07-14 10:02 ` Eric Shelton
2015-07-14 10:26 ` George Dunlap
2015-07-15 9:45 ` Ian Campbell
2015-07-16 15:51 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437061903.32371.232.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=eshelton@pobox.com \
--cc=ian.jackson@eu.citrix.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.