From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Eric Shelton <eshelton@pobox.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH V3 1/1] libxl: set stub domain size based on VRAM size
Date: Tue, 14 Jul 2015 09:51:39 +0100 [thread overview]
Message-ID: <CAFLBxZbFwrJGcTgQwVYhuKGwG7fXpEGyMauqCrZ7THrF8qpXuw@mail.gmail.com> (raw)
In-Reply-To: <1436650242-1067-2-git-send-email-eshelton@pobox.com>
On Sat, Jul 11, 2015 at 10:30 PM, Eric Shelton <eshelton@pobox.com> wrote:
> Allocate additional memory to the stub domain for qemu-traditional if
> more than 4 MB is assigned to the video adapter to avoid out of memory
> condition for QEMU.
>
> Signed-off-by: Eric Shelton <eshelton@pobox.com>
This seems like a good fix for now, thanks.
But (just speaking to people in general) it does make it even harder
to predict exactly how much host memory a VM is going to end up
needing to start, which is something a lot of people complain about.
I'm beginning to think that one feature we should try to look at is a
way for the admin to specify, "Max host memory used", from which
shadow/p2m/device memory/stubdomain can all be "allocated".
-George
> ---
> tools/libxl/libxl_dm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 317a8eb..9a5a937 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -1087,6 +1087,7 @@ void libxl__spawn_stub_dm(libxl__egc *egc, libxl__stub_dm_spawn_state *sdss)
>
> dm_config->b_info.max_vcpus = 1;
> - dm_config->b_info.max_memkb = 32 * 1024;
> + dm_config->b_info.max_memkb = 28 * 1024 +
> + guest_config->b_info.video_memkb;
> dm_config->b_info.target_memkb = dm_config->b_info.max_memkb;
>
> dm_config->b_info.u.pv.features = "";
> --
> 2.1.0
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-07-14 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 21:30 [PATCH V3 0/1] libxl: set stub domain size based on VRAM size Eric Shelton
2015-07-11 21:30 ` [PATCH V3 1/1] " Eric Shelton
2015-07-14 8:51 ` George Dunlap [this message]
2015-07-14 10:02 ` Eric Shelton
2015-07-14 10:26 ` George Dunlap
2015-07-15 9:45 ` Ian Campbell
2015-07-16 15:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZbFwrJGcTgQwVYhuKGwG7fXpEGyMauqCrZ7THrF8qpXuw@mail.gmail.com \
--to=george.dunlap@eu.citrix.com \
--cc=eshelton@pobox.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.