From: Johannes Berg <johannes@sipsolutions.net>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH v3 5/5] mac80211: select an AID when creating new mesh STAs
Date: Fri, 17 Jul 2015 16:50:56 +0200 [thread overview]
Message-ID: <1437144656.1933.28.camel@sipsolutions.net> (raw)
In-Reply-To: <1437144483.1933.27.camel@sipsolutions.net> (sfid-20150717_164811_113789_A7C6D03E)
On Fri, 2015-07-17 at 16:48 +0200, Johannes Berg wrote:
> On Fri, 2015-07-17 at 15:48 +0200, Johannes Berg wrote:
> > On Tue, 2015-07-14 at 08:31 -0400, Bob Copeland wrote:
> > > Instead of using peer link id for AID, generate a new
> > > AID when creating mesh STAs in the kernel peering manager.
> > > This enables smaller TIM elements and more closely follows
> > > the standard, and it also enables mesh to work on drivers
> > > that require a valid AID when the STA is inserted (ath10k
> > > firmware has this requirement, for example).
> > >
> > > In the case of userspace-managed stations, we use the AID
> > > from NL80211_CMD_NEW_STATION.
> > >
> > Applied the remaining 3 patches to mac80211-next (after merging
> > mac80211)
> >
>
> Actually, I'm dropping this one (the 5th) as it broke all the wpa_s
> mesh test cases. Perhaps wpa_s isn't assigning an AID and mac80211
> needs a fallback?
>
Actually, it also fails without any of your patches, so I guess it's
some other issue. I'll keep these and sort it out when I'm back.
johannes
next prev parent reply other threads:[~2015-07-17 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 12:31 [PATCH v3 0/5] mesh AID fixes Bob Copeland
2015-07-14 12:31 ` [PATCH v3 1/5] mac80211: correct aid location in peering frames Bob Copeland
2015-07-17 12:38 ` Johannes Berg
2015-07-14 12:31 ` [PATCH v3 2/5] mac80211: add missing length check for confirm frames Bob Copeland
2015-07-17 12:39 ` Johannes Berg
2015-07-14 12:31 ` [PATCH v3 3/5] mac80211: reorder mesh_plink to remove forward decl Bob Copeland
2015-07-14 12:31 ` [PATCH v3 4/5] mac80211: mesh: separate plid and aid concepts Bob Copeland
2015-07-14 12:31 ` [PATCH v3 5/5] mac80211: select an AID when creating new mesh STAs Bob Copeland
2015-07-17 13:48 ` Johannes Berg
2015-07-17 14:48 ` Johannes Berg
2015-07-17 14:50 ` Johannes Berg [this message]
2015-07-17 15:13 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437144656.1933.28.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.