From: Michael Ellerman <mpe@ellerman.id.au>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "Avargil, Raanan" <raanan.avargil@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, aaron.f.brown@intel.com,
yanirx.lubetkin@intel.com, jesse.brandeburg@intel.com,
shannon.nelson@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, matthew.vick@intel.com,
john.ronciak@intel.com, mitch.a.williams@intel.com
Subject: Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM
Date: Wed, 22 Jul 2015 11:41:20 +1000 [thread overview]
Message-ID: <1437529280.16792.9.camel@ellerman.id.au> (raw)
In-Reply-To: <1436956216.13597.8.camel@intel.com>
On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote:
> On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote:
> > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is
> > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used"
> > warning for e1000e_disable_aspm_locked().
> >
> > Move it inside the existing CONFIG_PM block to avoid the warning.
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
> > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> NACK, this is already fixed in my next-queue tree. Raanan submitted a
> patch back on July 6th to resolve this issue, see commit id
> a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my
> next-queue tree.
OK. I take it your next-queue is destined for 4.3, so we'll just have to suck
on the warning until then?
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM
Date: Wed, 22 Jul 2015 11:41:20 +1000 [thread overview]
Message-ID: <1437529280.16792.9.camel@ellerman.id.au> (raw)
In-Reply-To: <1436956216.13597.8.camel@intel.com>
On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote:
> On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote:
> > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is
> > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used"
> > warning for e1000e_disable_aspm_locked().
> >
> > Move it inside the existing CONFIG_PM block to avoid the warning.
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
> > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> NACK, this is already fixed in my next-queue tree. Raanan submitted a
> patch back on July 6th to resolve this issue, see commit id
> a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my
> next-queue tree.
OK. I take it your next-queue is destined for 4.3, so we'll just have to suck
on the warning until then?
cheers
next prev parent reply other threads:[~2015-07-22 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 3:54 [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM Michael Ellerman
2015-07-14 3:54 ` [Intel-wired-lan] " Michael Ellerman
2015-07-15 10:30 ` Jeff Kirsher
2015-07-15 10:30 ` [Intel-wired-lan] " Jeff Kirsher
2015-07-22 1:41 ` Michael Ellerman [this message]
2015-07-22 1:41 ` Michael Ellerman
2015-07-23 14:07 ` Jeff Kirsher
2015-07-23 14:07 ` [Intel-wired-lan] " Jeff Kirsher
2015-07-25 9:12 ` Michael Ellerman
2015-07-25 9:12 ` [Intel-wired-lan] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437529280.16792.9.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aaron.f.brown@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=raanan.avargil@intel.com \
--cc=shannon.nelson@intel.com \
--cc=yanirx.lubetkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.