* [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code
@ 2015-09-14 14:06 Fabio Estevam
2015-09-14 14:06 ` [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabio Estevam @ 2015-09-14 14:06 UTC (permalink / raw)
To: u-boot
iox74lv_set() is not used anywhere, so let's remove it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 43 -----------------------
1 file changed, 43 deletions(-)
diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
index 612fb78..acb8431 100644
--- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
+++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
@@ -155,49 +155,6 @@ static void iox74lv_init(void)
gpio_direction_output(IOX_OE, 1);
};
-void iox74lv_set(int index)
-{
- int i;
-
- gpio_direction_output(IOX_OE, 0);
-
- for (i = 7; i >= 0; i--) {
- gpio_direction_output(IOX_SHCP, 0);
-
- if (i == index)
- gpio_direction_output(IOX_SDI, seq[qn_output[i]][0]);
- else
- gpio_direction_output(IOX_SDI, seq[qn_output[i]][1]);
- udelay(500);
- gpio_direction_output(IOX_SHCP, 1);
- udelay(500);
- }
-
- gpio_direction_output(IOX_STCP, 0);
- udelay(500);
- /*
- * shift register will be output to pins
- */
- gpio_direction_output(IOX_STCP, 1);
-
- for (i = 7; i >= 0; i--) {
- gpio_direction_output(IOX_SHCP, 0);
- gpio_direction_output(IOX_SDI, seq[qn_output[i]][1]);
- udelay(500);
- gpio_direction_output(IOX_SHCP, 1);
- udelay(500);
- }
-
- gpio_direction_output(IOX_STCP, 0);
- udelay(500);
- /*
- * shift register will be output to pins
- */
- gpio_direction_output(IOX_STCP, 1);
-
- gpio_direction_output(IOX_OE, 1);
-};
-
#ifdef CONFIG_SYS_I2C_MXC
#define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
/* I2C1 for PMIC and EEPROM */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible
2015-09-14 14:06 [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Fabio Estevam
@ 2015-09-14 14:06 ` Fabio Estevam
2015-09-20 7:51 ` Stefano Babic
2015-09-14 14:06 ` [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev() Fabio Estevam
2015-09-20 7:50 ` [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Stefano Babic
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2015-09-14 14:06 UTC (permalink / raw)
To: u-boot
Make the internal symbols static when possible.
This prevents sparse build warnings.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
index acb8431..3d5c285 100644
--- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
+++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
@@ -158,7 +158,7 @@ static void iox74lv_init(void)
#ifdef CONFIG_SYS_I2C_MXC
#define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
/* I2C1 for PMIC and EEPROM */
-struct i2c_pads_info i2c_pad_info1 = {
+static struct i2c_pads_info i2c_pad_info1 = {
.scl = {
.i2c_mode = MX6_PAD_UART4_TX_DATA__I2C1_SCL | PC,
.gpio_mode = MX6_PAD_UART4_TX_DATA__GPIO1_IO28 | PC,
@@ -313,7 +313,7 @@ static iomux_v3_cfg_t const quadspi_pads[] = {
MX6_PAD_NAND_DQS__QSPI_A_SS0_B | MUX_PAD_CTRL(QSPI_PAD_CTRL1),
};
-int board_qspi_init(void)
+static int board_qspi_init(void)
{
/* Set the iomux */
imx_iomux_v3_setup_multiple_pads(quadspi_pads,
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev()
2015-09-14 14:06 [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Fabio Estevam
2015-09-14 14:06 ` [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible Fabio Estevam
@ 2015-09-14 14:06 ` Fabio Estevam
2015-09-20 7:51 ` Stefano Babic
2015-09-20 7:50 ` [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Stefano Babic
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2015-09-14 14:06 UTC (permalink / raw)
To: u-boot
get_board_rev() is not actually providing the board revision.
It just returns the CPU revision instead.
As the CPU revision is already printed on boot, there is no
reason to have get_board_rev(), so let's remove it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
index 3d5c285..8650f35 100644
--- a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
+++ b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
@@ -631,11 +631,6 @@ int board_late_init(void)
return 0;
}
-u32 get_board_rev(void)
-{
- return get_cpu_rev();
-}
-
int checkboard(void)
{
if (is_mx6ul_9x9_evk())
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code
2015-09-14 14:06 [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Fabio Estevam
2015-09-14 14:06 ` [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible Fabio Estevam
2015-09-14 14:06 ` [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev() Fabio Estevam
@ 2015-09-20 7:50 ` Stefano Babic
2 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2015-09-20 7:50 UTC (permalink / raw)
To: u-boot
On 14/09/2015 16:06, Fabio Estevam wrote:
> iox74lv_set() is not used anywhere, so let's remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible
2015-09-14 14:06 ` [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible Fabio Estevam
@ 2015-09-20 7:51 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2015-09-20 7:51 UTC (permalink / raw)
To: u-boot
On 14/09/2015 16:06, Fabio Estevam wrote:
> Make the internal symbols static when possible.
>
> This prevents sparse build warnings.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c b/board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
> index acb8431..3d5c285 100644
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev()
2015-09-14 14:06 ` [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev() Fabio Estevam
@ 2015-09-20 7:51 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2015-09-20 7:51 UTC (permalink / raw)
To: u-boot
On 14/09/2015 16:06, Fabio Estevam wrote:
> get_board_rev() is not actually providing the board revision.
>
> It just returns the CPU revision instead.
>
> As the CPU revision is already printed on boot, there is no
> reason to have get_board_rev(), so let's remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-20 7:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-14 14:06 [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Fabio Estevam
2015-09-14 14:06 ` [U-Boot] [PATCH 2/3] mx6ul_14x14_evk: Staticize when possible Fabio Estevam
2015-09-20 7:51 ` Stefano Babic
2015-09-14 14:06 ` [U-Boot] [PATCH 3/3] mx6ul_14x14_evk: Remove get_board_rev() Fabio Estevam
2015-09-20 7:51 ` Stefano Babic
2015-09-20 7:50 ` [U-Boot] [PATCH 1/3] mx6ul_14x14_evk: Remove dead code Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.