From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Jim Fehlig <jfehlig@suse.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] libxl: update check-xl-disk-parse
Date: Wed, 9 Dec 2015 10:32:57 +0000 [thread overview]
Message-ID: <1449657177.16124.177.camel@citrix.com> (raw)
In-Reply-To: <20151209102426.GC23818@citrix.com>
On Wed, 2015-12-09 at 10:24 +0000, Wei Liu wrote:
> On Wed, Dec 09, 2015 at 10:15:35AM +0000, Wei Liu wrote:
> > On Wed, Dec 09, 2015 at 10:06:17AM +0000, Ian Campbell wrote:
> > > On Tue, 2015-12-08 at 20:02 +0000, Wei Liu wrote:
> > > > The block-attach command now returns 1 when fails. Update first
> > > > test
> > > > case to expect return value 1 instead of 255.
> > > >
> > > > The parser now doesn't generate output for default values. Remove
> > > > them
> > > > from expected output.
> > >
> > > This it looks good.
> > >
> > > > The "discard=" variant is never not supported, so delete two test
> > > > cases
> > > > with that variant.
> > >
> > > I don't follow (the double negative "never not" doesn't help).
> > >
> >
> > Duh, I didn't intend to use double negation.
You meant "...was never supported..." then I think?
> > > However, assuming you are saying that discard= is always supported, I
> > > don't
> > > then see the rationale for removing the test. Of course we do want to
> > > test
> > > things which are supported.
> > >
> >
> > No, it is not supported. I dug into mailing list archive last night and
> > confirmed that Ian J asked Olaf to remove such variant. Those test
> > cases
> > were residual from a previous version Olaf failed to remove.
> >
>
> Forgot to paste in the references:
>
> commit 417e6b70d73ffe8f8d3938aa30a413b35098e614 in xen.git
>
> http://lists.xen.org/archives/html/xen-devel/2014-05/msg01063.html
Thanks, please include the commit reference in the v2 commit for this
change.
Ian.
prev parent reply other threads:[~2015-12-09 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 20:02 [PATCH] libxl: update check-xl-disk-parse Wei Liu
2015-12-09 10:06 ` Ian Campbell
2015-12-09 10:15 ` Wei Liu
2015-12-09 10:24 ` Wei Liu
2015-12-09 10:32 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449657177.16124.177.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.