* [PATCH v4 net] ionic: fix ptp support config breakage
@ 2021-05-11 18:11 Shannon Nelson
2021-05-11 18:36 ` Randy Dunlap
2021-05-11 23:33 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Shannon Nelson @ 2021-05-11 18:11 UTC (permalink / raw)
To: netdev, davem, kuba; +Cc: drivers, Shannon Nelson, Randy Dunlap, Allen Hubbe
When IONIC=y and PTP_1588_CLOCK=m were set in the .config file
the driver link failed with undefined references.
We add the dependancy
depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
to clear this up.
If PTP_1588_CLOCK=m, the depends limits IONIC to =m (or disabled).
If PTP_1588_CLOCK is disabled, IONIC can be any of y/m/n.
Fixes: 61db421da31b ("ionic: link in the new hw timestamp code")
Reported-by: kernel test robot <lkp@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Allen Hubbe <allenbh@pensando.io>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
---
v4 - Jakub's rewrite
v3 - put version notes below ---, added Allen's Cc
v2 - added Fixes tag
---
drivers/net/ethernet/pensando/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
index 5f8b0bb3af6e..202973a82712 100644
--- a/drivers/net/ethernet/pensando/Kconfig
+++ b/drivers/net/ethernet/pensando/Kconfig
@@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
config IONIC
tristate "Pensando Ethernet IONIC Support"
depends on 64BIT && PCI
+ depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
select NET_DEVLINK
select DIMLIB
help
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 net] ionic: fix ptp support config breakage
2021-05-11 18:11 [PATCH v4 net] ionic: fix ptp support config breakage Shannon Nelson
@ 2021-05-11 18:36 ` Randy Dunlap
2021-05-11 23:33 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2021-05-11 18:36 UTC (permalink / raw)
To: Shannon Nelson, netdev, davem, kuba; +Cc: drivers, Allen Hubbe
On 5/11/21 11:11 AM, Shannon Nelson wrote:
> When IONIC=y and PTP_1588_CLOCK=m were set in the .config file
> the driver link failed with undefined references.
>
> We add the dependancy
> depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
> to clear this up.
>
> If PTP_1588_CLOCK=m, the depends limits IONIC to =m (or disabled).
> If PTP_1588_CLOCK is disabled, IONIC can be any of y/m/n.
>
> Fixes: 61db421da31b ("ionic: link in the new hw timestamp code")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Allen Hubbe <allenbh@pensando.io>
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
>
> v4 - Jakub's rewrite
> v3 - put version notes below ---, added Allen's Cc
> v2 - added Fixes tag
> ---
> drivers/net/ethernet/pensando/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
> index 5f8b0bb3af6e..202973a82712 100644
> --- a/drivers/net/ethernet/pensando/Kconfig
> +++ b/drivers/net/ethernet/pensando/Kconfig
> @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
> config IONIC
> tristate "Pensando Ethernet IONIC Support"
> depends on 64BIT && PCI
> + depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
> select NET_DEVLINK
> select DIMLIB
> help
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 net] ionic: fix ptp support config breakage
2021-05-11 18:11 [PATCH v4 net] ionic: fix ptp support config breakage Shannon Nelson
2021-05-11 18:36 ` Randy Dunlap
@ 2021-05-11 23:33 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-11 23:33 UTC (permalink / raw)
To: Shannon Nelson; +Cc: netdev, davem, kuba, drivers, rdunlap, allenbh
Hello:
This patch was applied to bpf/bpf.git (refs/heads/master):
On Tue, 11 May 2021 11:11:32 -0700 you wrote:
> When IONIC=y and PTP_1588_CLOCK=m were set in the .config file
> the driver link failed with undefined references.
>
> We add the dependancy
> depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
> to clear this up.
>
> [...]
Here is the summary with links:
- [v4,net] ionic: fix ptp support config breakage
https://git.kernel.org/bpf/bpf/c/bcbda3fc6162
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-11 23:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 18:11 [PATCH v4 net] ionic: fix ptp support config breakage Shannon Nelson
2021-05-11 18:36 ` Randy Dunlap
2021-05-11 23:33 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.