* [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak
@ 2021-07-30 19:53 ` Matthew Brost
0 siblings, 0 replies; 7+ messages in thread
From: Matthew Brost @ 2021-07-30 19:53 UTC (permalink / raw)
To: intel-gfx, dri-devel
A small race exists between intel_gt_retire_requests_timeout and
intel_timeline_exit which could result in the syncmap not getting
free'd. Rather than work to hard to seal this race, simply cleanup the
syncmap on fini.
unreferenced object 0xffff88813bc53b18 (size 96):
comm "gem_close_race", pid 5410, jiffies 4294917818 (age 1105.600s)
hex dump (first 32 bytes):
01 00 00 00 00 00 00 00 00 00 00 00 0a 00 00 00 ................
00 00 00 00 00 00 00 00 6b 6b 6b 6b 06 00 00 00 ........kkkk....
backtrace:
[<00000000120b863a>] __sync_alloc_leaf+0x1e/0x40 [i915]
[<00000000042f6959>] __sync_set+0x1bb/0x240 [i915]
[<0000000090f0e90f>] i915_request_await_dma_fence+0x1c7/0x400 [i915]
[<0000000056a48219>] i915_request_await_object+0x222/0x360 [i915]
[<00000000aaac4ee3>] i915_gem_do_execbuffer+0x1bd0/0x2250 [i915]
[<000000003c9d830f>] i915_gem_execbuffer2_ioctl+0x405/0xce0 [i915]
[<00000000fd7a8e68>] drm_ioctl_kernel+0xb0/0xf0 [drm]
[<00000000e721ee87>] drm_ioctl+0x305/0x3c0 [drm]
[<000000008b0d8986>] __x64_sys_ioctl+0x71/0xb0
[<0000000076c362a4>] do_syscall_64+0x33/0x80
[<00000000eb7a4831>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Fixes: 531958f6f357 ("drm/i915/gt: Track timeline activeness in enter/exit")
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index c4a126c8caef..1257f4f11e66 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -127,6 +127,15 @@ static void intel_timeline_fini(struct rcu_head *rcu)
i915_vma_put(timeline->hwsp_ggtt);
i915_active_fini(&timeline->active);
+
+ /*
+ * A small race exists between intel_gt_retire_requests_timeout and
+ * intel_timeline_exit which could result in the syncmap not getting
+ * free'd. Rather than work to hard to seal this race, simply cleanup
+ * the syncmap on fini.
+ */
+ i915_syncmap_free(&timeline->sync);
+
kfree(timeline);
}
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm/i915: Fix syncmap memory leak
@ 2021-07-30 19:53 ` Matthew Brost
0 siblings, 0 replies; 7+ messages in thread
From: Matthew Brost @ 2021-07-30 19:53 UTC (permalink / raw)
To: intel-gfx, dri-devel
A small race exists between intel_gt_retire_requests_timeout and
intel_timeline_exit which could result in the syncmap not getting
free'd. Rather than work to hard to seal this race, simply cleanup the
syncmap on fini.
unreferenced object 0xffff88813bc53b18 (size 96):
comm "gem_close_race", pid 5410, jiffies 4294917818 (age 1105.600s)
hex dump (first 32 bytes):
01 00 00 00 00 00 00 00 00 00 00 00 0a 00 00 00 ................
00 00 00 00 00 00 00 00 6b 6b 6b 6b 06 00 00 00 ........kkkk....
backtrace:
[<00000000120b863a>] __sync_alloc_leaf+0x1e/0x40 [i915]
[<00000000042f6959>] __sync_set+0x1bb/0x240 [i915]
[<0000000090f0e90f>] i915_request_await_dma_fence+0x1c7/0x400 [i915]
[<0000000056a48219>] i915_request_await_object+0x222/0x360 [i915]
[<00000000aaac4ee3>] i915_gem_do_execbuffer+0x1bd0/0x2250 [i915]
[<000000003c9d830f>] i915_gem_execbuffer2_ioctl+0x405/0xce0 [i915]
[<00000000fd7a8e68>] drm_ioctl_kernel+0xb0/0xf0 [drm]
[<00000000e721ee87>] drm_ioctl+0x305/0x3c0 [drm]
[<000000008b0d8986>] __x64_sys_ioctl+0x71/0xb0
[<0000000076c362a4>] do_syscall_64+0x33/0x80
[<00000000eb7a4831>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Fixes: 531958f6f357 ("drm/i915/gt: Track timeline activeness in enter/exit")
Cc: <stable@vger.kernel.org>
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index c4a126c8caef..1257f4f11e66 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -127,6 +127,15 @@ static void intel_timeline_fini(struct rcu_head *rcu)
i915_vma_put(timeline->hwsp_ggtt);
i915_active_fini(&timeline->active);
+
+ /*
+ * A small race exists between intel_gt_retire_requests_timeout and
+ * intel_timeline_exit which could result in the syncmap not getting
+ * free'd. Rather than work to hard to seal this race, simply cleanup
+ * the syncmap on fini.
+ */
+ i915_syncmap_free(&timeline->sync);
+
kfree(timeline);
}
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix syncmap memory leak
2021-07-30 19:53 ` Matthew Brost
(?)
@ 2021-07-30 20:20 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-07-30 20:20 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]
== Series Details ==
Series: drm/i915: Fix syncmap memory leak
URL : https://patchwork.freedesktop.org/series/93245/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10427 -> Patchwork_20751
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/index.html
Known issues
------------
Here are the changes found in Patchwork_20751 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][1] ([i915#1888]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@workarounds:
- fi-tgl-u2: [DMESG-WARN][3] ([i915#2867]) -> [PASS][4] +16 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/fi-tgl-u2/igt@i915_selftest@live@workarounds.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/fi-tgl-u2/igt@i915_selftest@live@workarounds.html
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
Participating hosts (37 -> 32)
------------------------------
Missing (5): fi-kbl-soraka fi-hsw-4200u fi-bsw-cyan bat-jsl-1 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10427 -> Patchwork_20751
CI-20190529: 20190529
CI_DRM_10427: e5efc20bce6b7996df9bdc720796f8713a45701a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6159: 6135b9cc319ed965e3aafb5b2ae2abf4762a06b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20751: 2e32c1dff4b60c320ec8c4c38ed1f5ab6f84b936 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2e32c1dff4b6 drm/i915: Fix syncmap memory leak
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/index.html
[-- Attachment #2: Type: text/html, Size: 2740 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix syncmap memory leak
2021-07-30 19:53 ` Matthew Brost
(?)
(?)
@ 2021-07-31 2:17 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-07-31 2:17 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30256 bytes --]
== Series Details ==
Series: drm/i915: Fix syncmap memory leak
URL : https://patchwork.freedesktop.org/series/93245/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10427_full -> Patchwork_20751_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20751_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][2] -> [FAIL][3] ([i915#2410])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-tglb2/igt@gem_ctx_persistence@many-contexts.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb3/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-skl: [PASS][4] -> [TIMEOUT][5] ([i915#3063])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl9/igt@gem_eio@in-flight-contexts-1us.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl3/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#3063] / [i915#3648])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-tglb5/igt@gem_eio@unwedge-stress.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-kbl4/igt@gem_exec_fair@basic-none-share@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-iclb: NOTRUN -> [FAIL][10] ([i915#2849])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-glk9/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#2849])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#118] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-glk9/igt@gem_exec_whisper@basic-queues-forked.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-glk4/igt@gem_exec_whisper@basic-queues-forked.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][19] ([i915#2658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-snb6/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#768])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@gem_render_copy@y-tiled-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#3323])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen7_exec_parse@basic-allowed:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109289]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@gen7_exec_parse@basic-allowed.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1436] / [i915#716])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl6/igt@gen9_exec_parse@allowed-single.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl10/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-secure:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#2856])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@gen9_exec_parse@bb-secure.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: NOTRUN -> [WARN][26] ([i915#1804] / [i915#2684])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rpm@gem-evict-pwrite:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#579]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@i915_pm_rpm@gem-evict-pwrite.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#110725] / [fdo#111614])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@kms_big_fb@x-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: [PASS][29] -> [DMESG-WARN][30] ([i915#3621])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-iclb2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#110723]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#3689]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb1/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][33] ([fdo#109271]) +225 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-snb2/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-cmp-planar-formats:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109284] / [fdo#111827]) +4 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@kms_chamelium@hdmi-cmp-planar-formats.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +8 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-snb7/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [PASS][36] -> [DMESG-WARN][37] ([i915#1982])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl9/igt@kms_color@pipe-b-ctm-0-5.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl1/igt@kms_color@pipe-b-ctm-0-5.html
* igt@kms_color@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278] / [i915#1149])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@kms_color@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +15 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl1/igt@kms_color_chamelium@pipe-a-ctm-0-5.html
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl2/igt@kms_color_chamelium@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb1/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +6 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl7/igt@kms_color_chamelium@pipe-d-ctm-0-75.html
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][43] ([i915#1319])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl2/igt@kms_content_protection@legacy.html
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111828])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb3/igt@kms_content_protection@legacy.html
- shard-apl: NOTRUN -> [TIMEOUT][45] ([i915#1319])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl2/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@uevent:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109300] / [fdo#111066])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#3444])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278] / [fdo#109279]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-32x10-offscreen:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278]) +18 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_cursor_crc@pipe-d-cursor-32x10-offscreen.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109274] / [fdo#109278])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][52] -> [FAIL][53] ([i915#2346] / [i915#533])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [PASS][54] -> [INCOMPLETE][55] ([i915#155] / [i915#180] / [i915#636])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109274]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][57] -> [FAIL][58] ([i915#2122])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-glk5/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-glk5/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#79])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][61] -> [DMESG-WARN][62] ([i915#180])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][63] ([i915#180])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl1/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][64] ([i915#180]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][65] -> [FAIL][66] ([i915#2122])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl3/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#2587])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb1/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#111825]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +31 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl2/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109280]) +11 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271]) +63 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#1839]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl2/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][74] -> [DMESG-WARN][75] ([i915#180]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][76] ([i915#265])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
- shard-kbl: NOTRUN -> [FAIL][77] ([i915#265])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][78] -> [FAIL][79] ([fdo#108145] / [i915#265]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#2733])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#658]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][84] -> [SKIP][85] ([fdo#109642] / [fdo#111068] / [i915#658])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-iclb2/igt@kms_psr2_su@page_flip.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb1/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][86] -> [SKIP][87] ([fdo#109441])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271]) +168 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl2/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_vrr@flipline:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109502])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb7/igt@kms_vrr@flipline.html
* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#2530])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb1/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html
* igt@nouveau_crc@pipe-b-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#2530]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@nouveau_crc@pipe-b-source-outp-complete.html
* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109278] / [i915#2530])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@nouveau_crc@pipe-d-source-outp-complete.html
* igt@perf@polling-parameterized:
- shard-tglb: [PASS][93] -> [FAIL][94] ([i915#1542])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-tglb8/igt@perf@polling-parameterized.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-tglb8/igt@perf@polling-parameterized.html
* igt@prime_nv_api@i915_nv_double_export:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109291]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@prime_nv_api@i915_nv_double_export.html
* igt@sysfs_clients@fair-1:
- shard-iclb: NOTRUN -> [SKIP][96] ([i915#2994])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl2/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@split-10:
- shard-skl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl8/igt@sysfs_clients@split-10.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][99] ([i915#658]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-iclb8/igt@feature_discovery@psr2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +3 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-apl1/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-apl7/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_ctx_persistence@legacy-engines-hang@render:
- shard-glk: [FAIL][103] ([i915#2410]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-glk5/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-glk5/igt@gem_ctx_persistence@legacy-engines-hang@render.html
* igt@gem_eio@hibernate:
- {shard-rkl}: [FAIL][105] ([i915#3666]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-1/igt@gem_eio@hibernate.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@gem_eio@hibernate.html
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: [TIMEOUT][107] ([i915#3063]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-1/igt@gem_eio@unwedge-stress.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][109] ([i915#2846]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@gem_exec_fair@basic-deadline.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][111] ([i915#2842]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-1/igt@gem_exec_fair@basic-throttle@rcs0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_mmap_offset@clear:
- shard-skl: [FAIL][113] ([i915#1888] / [i915#3160]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl7/igt@gem_mmap_offset@clear.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl5/igt@gem_mmap_offset@clear.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- {shard-rkl}: [SKIP][115] ([i915#3844] / [i915#579]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-6/igt@i915_pm_rpm@system-suspend-execbuf.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-2/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_selftest@live@gt_pm:
- {shard-rkl}: [DMESG-FAIL][117] ([i915#1021]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@i915_selftest@live@gt_pm.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-1/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@forcewake:
- shard-skl: [INCOMPLETE][119] ([i915#636]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl8/igt@i915_suspend@forcewake.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl7/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0:
- {shard-rkl}: [SKIP][121] ([i915#3721]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-iclb: [DMESG-WARN][123] ([i915#3621]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-iclb1/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-iclb3/igt@kms_big_fb@yf-tiled-32bpp-rotate-90.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [FAIL][125] ([i915#3678]) -> [PASS][126] +3 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-c-degamma:
- {shard-rkl}: [SKIP][127] ([i915#1149] / [i915#1849]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-1/igt@kms_color@pipe-c-degamma.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@kms_color@pipe-c-degamma.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][129] ([i915#180]) -> [PASS][130] +4 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- {shard-rkl}: [SKIP][131] ([fdo#112022]) -> [PASS][132] +4 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [INCOMPLETE][133] ([i915#146] / [i915#2405] / [i915#300]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- {shard-rkl}: [SKIP][135] ([fdo#111825]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled:
- shard-skl: [FAIL][137] ([i915#3451]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-skl10/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-skl3/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-ytiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-untiled:
- {shard-rkl}: [SKIP][139] ([fdo#111314]) -> [PASS][140] +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-rkl-5/igt@kms_draw_crc@draw-method-xrgb8888-render-untiled.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb8888-render-untiled.html
* igt@kms_flip@flip-vs-expired-vblank@b-dp1:
- shard-kbl: [FAIL][141] ([i915#79]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10427/shard-kbl6/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/shard-kbl2/igt@kms_flip@flip-vs-expired-vblank@b-dp1.html
* igt@kms_flip@plain
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20751/index.html
[-- Attachment #2: Type: text/html, Size: 33489 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak
2021-07-30 19:53 ` Matthew Brost
` (2 preceding siblings ...)
(?)
@ 2021-08-06 18:23 ` John Harrison
2021-08-06 18:29 ` Matthew Brost
-1 siblings, 1 reply; 7+ messages in thread
From: John Harrison @ 2021-08-06 18:23 UTC (permalink / raw)
To: Matthew Brost, intel-gfx, dri-devel
On 7/30/2021 12:53, Matthew Brost wrote:
> A small race exists between intel_gt_retire_requests_timeout and
> intel_timeline_exit which could result in the syncmap not getting
> free'd. Rather than work to hard to seal this race, simply cleanup the
free'd -> freed
> syncmap on fini.
>
> unreferenced object 0xffff88813bc53b18 (size 96):
> comm "gem_close_race", pid 5410, jiffies 4294917818 (age 1105.600s)
> hex dump (first 32 bytes):
> 01 00 00 00 00 00 00 00 00 00 00 00 0a 00 00 00 ................
> 00 00 00 00 00 00 00 00 6b 6b 6b 6b 06 00 00 00 ........kkkk....
> backtrace:
> [<00000000120b863a>] __sync_alloc_leaf+0x1e/0x40 [i915]
> [<00000000042f6959>] __sync_set+0x1bb/0x240 [i915]
> [<0000000090f0e90f>] i915_request_await_dma_fence+0x1c7/0x400 [i915]
> [<0000000056a48219>] i915_request_await_object+0x222/0x360 [i915]
> [<00000000aaac4ee3>] i915_gem_do_execbuffer+0x1bd0/0x2250 [i915]
> [<000000003c9d830f>] i915_gem_execbuffer2_ioctl+0x405/0xce0 [i915]
> [<00000000fd7a8e68>] drm_ioctl_kernel+0xb0/0xf0 [drm]
> [<00000000e721ee87>] drm_ioctl+0x305/0x3c0 [drm]
> [<000000008b0d8986>] __x64_sys_ioctl+0x71/0xb0
> [<0000000076c362a4>] do_syscall_64+0x33/0x80
> [<00000000eb7a4831>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> Fixes: 531958f6f357 ("drm/i915/gt: Track timeline activeness in enter/exit")
> Cc: <stable@vger.kernel.org>
> ---
> drivers/gpu/drm/i915/gt/intel_timeline.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
> index c4a126c8caef..1257f4f11e66 100644
> --- a/drivers/gpu/drm/i915/gt/intel_timeline.c
> +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
> @@ -127,6 +127,15 @@ static void intel_timeline_fini(struct rcu_head *rcu)
>
> i915_vma_put(timeline->hwsp_ggtt);
> i915_active_fini(&timeline->active);
> +
> + /*
> + * A small race exists between intel_gt_retire_requests_timeout and
> + * intel_timeline_exit which could result in the syncmap not getting
> + * free'd. Rather than work to hard to seal this race, simply cleanup
> + * the syncmap on fini.
What is the race? I'm going round in circles just trying to work out how
intel_gt_retire_requests_timeout is supposed to get to
intel_timeline_exit in the first place.
Also, free'd -> freed.
John.
> + */
> + i915_syncmap_free(&timeline->sync);
> +
> kfree(timeline);
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak
2021-08-06 18:23 ` [Intel-gfx] [PATCH] " John Harrison
@ 2021-08-06 18:29 ` Matthew Brost
2021-08-06 20:16 ` John Harrison
0 siblings, 1 reply; 7+ messages in thread
From: Matthew Brost @ 2021-08-06 18:29 UTC (permalink / raw)
To: John Harrison; +Cc: intel-gfx, dri-devel
On Fri, Aug 06, 2021 at 11:23:06AM -0700, John Harrison wrote:
> On 7/30/2021 12:53, Matthew Brost wrote:
> > A small race exists between intel_gt_retire_requests_timeout and
> > intel_timeline_exit which could result in the syncmap not getting
> > free'd. Rather than work to hard to seal this race, simply cleanup the
> free'd -> freed
>
Sure.
> > syncmap on fini.
> >
> > unreferenced object 0xffff88813bc53b18 (size 96):
> > comm "gem_close_race", pid 5410, jiffies 4294917818 (age 1105.600s)
> > hex dump (first 32 bytes):
> > 01 00 00 00 00 00 00 00 00 00 00 00 0a 00 00 00 ................
> > 00 00 00 00 00 00 00 00 6b 6b 6b 6b 06 00 00 00 ........kkkk....
> > backtrace:
> > [<00000000120b863a>] __sync_alloc_leaf+0x1e/0x40 [i915]
> > [<00000000042f6959>] __sync_set+0x1bb/0x240 [i915]
> > [<0000000090f0e90f>] i915_request_await_dma_fence+0x1c7/0x400 [i915]
> > [<0000000056a48219>] i915_request_await_object+0x222/0x360 [i915]
> > [<00000000aaac4ee3>] i915_gem_do_execbuffer+0x1bd0/0x2250 [i915]
> > [<000000003c9d830f>] i915_gem_execbuffer2_ioctl+0x405/0xce0 [i915]
> > [<00000000fd7a8e68>] drm_ioctl_kernel+0xb0/0xf0 [drm]
> > [<00000000e721ee87>] drm_ioctl+0x305/0x3c0 [drm]
> > [<000000008b0d8986>] __x64_sys_ioctl+0x71/0xb0
> > [<0000000076c362a4>] do_syscall_64+0x33/0x80
> > [<00000000eb7a4831>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> >
> > Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> > Fixes: 531958f6f357 ("drm/i915/gt: Track timeline activeness in enter/exit")
> > Cc: <stable@vger.kernel.org>
> > ---
> > drivers/gpu/drm/i915/gt/intel_timeline.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
> > index c4a126c8caef..1257f4f11e66 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_timeline.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
> > @@ -127,6 +127,15 @@ static void intel_timeline_fini(struct rcu_head *rcu)
> > i915_vma_put(timeline->hwsp_ggtt);
> > i915_active_fini(&timeline->active);
> > +
> > + /*
> > + * A small race exists between intel_gt_retire_requests_timeout and
> > + * intel_timeline_exit which could result in the syncmap not getting
> > + * free'd. Rather than work to hard to seal this race, simply cleanup
> > + * the syncmap on fini.
> What is the race? I'm going round in circles just trying to work out how
> intel_gt_retire_requests_timeout is supposed to get to intel_timeline_exit
> in the first place.
>
intel_gt_retire_requests_timeout increments tl->active_count, active_count == 2
intel_timeline_exit is called, returns on atomic_add_unless, active_count == 1
intel_gt_retire_requests_timeout decrements tl->active_count, active_count == 0
i915_syncmap_free is never called, memory leak
Matt
> Also, free'd -> freed.
>
> John.
>
>
> > + */
> > + i915_syncmap_free(&timeline->sync);
> > +
> > kfree(timeline);
> > }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak
2021-08-06 18:29 ` Matthew Brost
@ 2021-08-06 20:16 ` John Harrison
0 siblings, 0 replies; 7+ messages in thread
From: John Harrison @ 2021-08-06 20:16 UTC (permalink / raw)
To: Matthew Brost; +Cc: intel-gfx, dri-devel
On 8/6/2021 11:29, Matthew Brost wrote:
> On Fri, Aug 06, 2021 at 11:23:06AM -0700, John Harrison wrote:
>> On 7/30/2021 12:53, Matthew Brost wrote:
>>> A small race exists between intel_gt_retire_requests_timeout and
>>> intel_timeline_exit which could result in the syncmap not getting
>>> free'd. Rather than work to hard to seal this race, simply cleanup the
>> free'd -> freed
>>
> Sure.
>
>>> syncmap on fini.
>>>
>>> unreferenced object 0xffff88813bc53b18 (size 96):
>>> comm "gem_close_race", pid 5410, jiffies 4294917818 (age 1105.600s)
>>> hex dump (first 32 bytes):
>>> 01 00 00 00 00 00 00 00 00 00 00 00 0a 00 00 00 ................
>>> 00 00 00 00 00 00 00 00 6b 6b 6b 6b 06 00 00 00 ........kkkk....
>>> backtrace:
>>> [<00000000120b863a>] __sync_alloc_leaf+0x1e/0x40 [i915]
>>> [<00000000042f6959>] __sync_set+0x1bb/0x240 [i915]
>>> [<0000000090f0e90f>] i915_request_await_dma_fence+0x1c7/0x400 [i915]
>>> [<0000000056a48219>] i915_request_await_object+0x222/0x360 [i915]
>>> [<00000000aaac4ee3>] i915_gem_do_execbuffer+0x1bd0/0x2250 [i915]
>>> [<000000003c9d830f>] i915_gem_execbuffer2_ioctl+0x405/0xce0 [i915]
>>> [<00000000fd7a8e68>] drm_ioctl_kernel+0xb0/0xf0 [drm]
>>> [<00000000e721ee87>] drm_ioctl+0x305/0x3c0 [drm]
>>> [<000000008b0d8986>] __x64_sys_ioctl+0x71/0xb0
>>> [<0000000076c362a4>] do_syscall_64+0x33/0x80
>>> [<00000000eb7a4831>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>>
>>> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
>>> Fixes: 531958f6f357 ("drm/i915/gt: Track timeline activeness in enter/exit")
>>> Cc: <stable@vger.kernel.org>
>>> ---
>>> drivers/gpu/drm/i915/gt/intel_timeline.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
>>> index c4a126c8caef..1257f4f11e66 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_timeline.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
>>> @@ -127,6 +127,15 @@ static void intel_timeline_fini(struct rcu_head *rcu)
>>> i915_vma_put(timeline->hwsp_ggtt);
>>> i915_active_fini(&timeline->active);
>>> +
>>> + /*
>>> + * A small race exists between intel_gt_retire_requests_timeout and
>>> + * intel_timeline_exit which could result in the syncmap not getting
>>> + * free'd. Rather than work to hard to seal this race, simply cleanup
>>> + * the syncmap on fini.
>> What is the race? I'm going round in circles just trying to work out how
>> intel_gt_retire_requests_timeout is supposed to get to intel_timeline_exit
>> in the first place.
>>
> intel_gt_retire_requests_timeout increments tl->active_count, active_count == 2
> intel_timeline_exit is called, returns on atomic_add_unless, active_count == 1
> intel_gt_retire_requests_timeout decrements tl->active_count, active_count == 0
> i915_syncmap_free is never called, memory leak
>
> Matt
Okay. Think I follow it now.
Seems like the syncmap free should have been in timeline_fini instead of
timeline_exit in the first place?
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
>
>> Also, free'd -> freed.
>>
>> John.
>>
>>
>>> + */
>>> + i915_syncmap_free(&timeline->sync);
>>> +
>>> kfree(timeline);
>>> }
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-06 20:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 19:53 [Intel-gfx] [PATCH] drm/i915: Fix syncmap memory leak Matthew Brost
2021-07-30 19:53 ` Matthew Brost
2021-07-30 20:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-31 2:17 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-08-06 18:23 ` [Intel-gfx] [PATCH] " John Harrison
2021-08-06 18:29 ` Matthew Brost
2021-08-06 20:16 ` John Harrison
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.