All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <pmoore@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Andrew Jones" <drjones@redhat.com>,
	"Marcus Meissner" <meissner@suse.de>,
	"Eduardo Otubo" <eduardo.otubo@profitbricks.com>,
	"Patch Tracking" <patches@linaro.org>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Alexander Graf" <agraf@suse.de>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Karl-Philipp Richter" <krichter722@aol.de>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures
Date: Tue, 30 Jun 2015 13:18:49 -0400	[thread overview]
Message-ID: <1691300.PcMPTG641q@sifl> (raw)
In-Reply-To: <CAFEAcA_zgwHgdhMaUkCuSynYJWoZnkrZr2a3F7mbsCyUS7YyNQ@mail.gmail.com>

On Tuesday, June 30, 2015 06:07:40 PM Peter Maydell wrote:
> On 30 June 2015 at 18:01, Paul Moore <pmoore@redhat.com> wrote:
> > I'm starting to wonder if the 32-bit ARM build system didn't have
> > __NR_cacheflush defined in the system headers; that might explain some of
> > the behavior.  Could you check your system to see if it has
> > __NR_cacheflush defined (try /usr/include/asm/unistd.h)?
> 
> The constant name is __ARM_NR_cacheflush, not __NR_cacheflush
> (all the ARM-specific syscalls are __ARM_NR_*). See
> http://lxr.free-electrons.com/source/arch/arm/include/uapi/asm/unistd.h#L418

/me smacks his forehead

Of course it is.  We already work around that in arch-syscall-validate.  D'oh!

Good news though, I think we just found the bug ;)

I'm currently trying to put out another fire in a different project; as soon 
as I've got that done I'll fix this.  However, if somebody wants to play, I'm 
always happy to accept patches :)

-- 
paul moore
security @ redhat

  reply	other threads:[~2015-06-30 17:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 12:58 [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures Peter Maydell
2015-06-16 13:12 ` Andrew Jones
2015-06-16 13:16   ` Peter Maydell
2015-06-26 16:03     ` Andrew Jones
2015-06-26 20:26       ` Paul Moore
2015-06-29  7:50         ` Andrew Jones
2015-06-29 14:53           ` Paul Moore
2015-06-29 17:47             ` Andrew Jones
2015-06-29 20:24               ` Paul Moore
2015-06-30  8:39                 ` Andrew Jones
2015-06-30 17:01                   ` Paul Moore
2015-06-30 17:07                     ` Peter Maydell
2015-06-30 17:18                       ` Paul Moore [this message]
2015-07-01 12:07                         ` Andrew Jones
2015-07-01 17:08                           ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1691300.PcMPTG641q@sifl \
    --to=pmoore@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=drjones@redhat.com \
    --cc=eduardo.otubo@profitbricks.com \
    --cc=krichter722@aol.de \
    --cc=meissner@suse.de \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.