From: Andrew Jones <drjones@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marcus Meissner" <meissner@suse.de>,
"Eduardo Otubo" <eduardo.otubo@profitbricks.com>,
patches@linaro.org, "Riku Voipio" <riku.voipio@iki.fi>,
"Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org, "Paul Moore" <pmoore@redhat.com>,
"Karl-Philipp Richter" <krichter722@aol.de>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures
Date: Tue, 16 Jun 2015 15:12:37 +0200 [thread overview]
Message-ID: <20150616131237.GF4428@hawk.localdomain> (raw)
In-Reply-To: <1428670681-23032-1-git-send-email-peter.maydell@linaro.org>
On Fri, Apr 10, 2015 at 01:58:01PM +0100, Peter Maydell wrote:
> Unfortunately it turns out that libseccomp 2.2 still does not work
> correctly on non-x86 architectures; return to the previous configure
> setup of insisting on libseccomp 2.1 or better and i386/x86_64 and
> disabling seccomp support in all other situations.
>
> This reverts the two commits:
> * "seccomp: libseccomp version varying according to arch"
> (commit 896848f0d3e2393905845ef2b244bb2601f9df0c)
> * "seccomp: update libseccomp version and remove arch restriction"
> (commit 8e27fc200457e3f2473d0069263774d4ba17bd85)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> With QEMU 2.3 release so close this seems the safest approach.
>
> configure | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/configure b/configure
> index 8b673fd..6969f6f 100755
> --- a/configure
> +++ b/configure
> @@ -1848,19 +1848,14 @@ fi
> # libseccomp check
>
> if test "$seccomp" != "no" ; then
> - if $pkg_config --atleast-version=2.2.0 libseccomp ||
> - (test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> - $pkg_config --atleast-version=2.1.1 libseccomp); then
> + if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> + $pkg_config --atleast-version=2.1.1 libseccomp; then
> libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
> QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
> seccomp="yes"
> else
> if test "$seccomp" = "yes"; then
> - if test "$cpu" = "i386" || test "$cpu" = "x86_64"; then
> feature_not_found "libseccomp" "Install libseccomp devel >= 2.1.1"
> - else
> - feature_not_found "libseccomp" "Install libseccomp devel >= 2.2.0"
> - fi
> fi
> seccomp="no"
> fi
> --
> 1.9.1
>
>
>
Hi Peter,
Can we now revert this revert, along with bumping the non-x86 arch
atleast-version to v2.2.1?
Thanks,
drew
next prev parent reply other threads:[~2015-06-16 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 12:58 [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures Peter Maydell
2015-06-16 13:12 ` Andrew Jones [this message]
2015-06-16 13:16 ` Peter Maydell
2015-06-26 16:03 ` Andrew Jones
2015-06-26 20:26 ` Paul Moore
2015-06-29 7:50 ` Andrew Jones
2015-06-29 14:53 ` Paul Moore
2015-06-29 17:47 ` Andrew Jones
2015-06-29 20:24 ` Paul Moore
2015-06-30 8:39 ` Andrew Jones
2015-06-30 17:01 ` Paul Moore
2015-06-30 17:07 ` Peter Maydell
2015-06-30 17:18 ` Paul Moore
2015-07-01 12:07 ` Andrew Jones
2015-07-01 17:08 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616131237.GF4428@hawk.localdomain \
--to=drjones@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=eduardo.otubo@profitbricks.com \
--cc=krichter722@aol.de \
--cc=meissner@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=pmoore@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.