From: Will Deacon <will@kernel.org>
To: mark.rutland@arm.com, catalin.marinas@arm.com,
Dave.Martin@arm.com, xieyuanbin1@huawei.com,
Jiangfeng Xiao <xiaojiangfeng@huawei.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, nixiaoming@huawei.com,
wangbing6@huawei.com, douzhaolei@huawei.com, liaohua4@huawei.com,
lijiahuan5@huawei.com, wangfangpeng1@huawei.com
Subject: Re: [PATCH v2] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY
Date: Tue, 21 May 2024 19:39:24 +0100 [thread overview]
Message-ID: <171631490546.211397.14650733448270838075.b4-ty@kernel.org> (raw)
In-Reply-To: <1716212077-43826-1-git-send-email-xiaojiangfeng@huawei.com>
On Mon, 20 May 2024 21:34:37 +0800, Jiangfeng Xiao wrote:
> When CONFIG_DEBUG_BUGVERBOSE=n, we fail to add necessary padding bytes
> to bug_table entries, and as a result the last entry in a bug table will
> be ignored, potentially leading to an unexpected panic(). All prior
> entries in the table will be handled correctly.
>
> The arm64 ABI requires that struct fields of up to 8 bytes are
> naturally-aligned, with padding added within a struct such that struct
> are suitably aligned within arrays.
>
> [...]
Applied to arm64 (for-next/core), thanks!
[1/1] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY
https://git.kernel.org/arm64/c/ffbf4fb9b5c1
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: mark.rutland@arm.com, catalin.marinas@arm.com,
Dave.Martin@arm.com, xieyuanbin1@huawei.com,
Jiangfeng Xiao <xiaojiangfeng@huawei.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, nixiaoming@huawei.com,
wangbing6@huawei.com, douzhaolei@huawei.com, liaohua4@huawei.com,
lijiahuan5@huawei.com, wangfangpeng1@huawei.com
Subject: Re: [PATCH v2] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY
Date: Tue, 21 May 2024 19:39:24 +0100 [thread overview]
Message-ID: <171631490546.211397.14650733448270838075.b4-ty@kernel.org> (raw)
In-Reply-To: <1716212077-43826-1-git-send-email-xiaojiangfeng@huawei.com>
On Mon, 20 May 2024 21:34:37 +0800, Jiangfeng Xiao wrote:
> When CONFIG_DEBUG_BUGVERBOSE=n, we fail to add necessary padding bytes
> to bug_table entries, and as a result the last entry in a bug table will
> be ignored, potentially leading to an unexpected panic(). All prior
> entries in the table will be handled correctly.
>
> The arm64 ABI requires that struct fields of up to 8 bytes are
> naturally-aligned, with padding added within a struct such that struct
> are suitably aligned within arrays.
>
> [...]
Applied to arm64 (for-next/core), thanks!
[1/1] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY
https://git.kernel.org/arm64/c/ffbf4fb9b5c1
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-21 18:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:13 [PATCH] arm64: asm-bug: Add .align 2 to the end of __BUG_ENTRY Jiangfeng Xiao
2024-05-17 14:13 ` Jiangfeng Xiao
2024-05-20 10:33 ` Mark Rutland
2024-05-20 10:33 ` Mark Rutland
2024-05-20 12:05 ` Li Zetao
2024-05-20 12:05 ` Li Zetao
2024-05-20 13:01 ` Mark Rutland
2024-05-20 13:01 ` Mark Rutland
2024-05-20 13:21 ` Jiangfeng Xiao
2024-05-20 13:21 ` Jiangfeng Xiao
2024-05-20 13:30 ` Jiangfeng Xiao
2024-05-20 13:30 ` Jiangfeng Xiao
2024-05-20 13:34 ` [PATCH v2] " Jiangfeng Xiao
2024-05-20 13:34 ` Jiangfeng Xiao
2024-05-21 18:39 ` Will Deacon [this message]
2024-05-21 18:39 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171631490546.211397.14650733448270838075.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=douzhaolei@huawei.com \
--cc=kernel-team@android.com \
--cc=liaohua4@huawei.com \
--cc=lijiahuan5@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nixiaoming@huawei.com \
--cc=wangbing6@huawei.com \
--cc=wangfangpeng1@huawei.com \
--cc=xiaojiangfeng@huawei.com \
--cc=xieyuanbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.