From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
David Hunt <david.hunt@intel.com>,
reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_power: fix using variables before validity check
Date: Wed, 12 May 2021 17:19:16 +0200 [thread overview]
Message-ID: <1895782.HPLxxfrSh9@thomas> (raw)
In-Reply-To: <f6520635-df13-4c51-0aaa-a56dae3d6aef@intel.com>
> > In function power_guest_channel_read_msg, 'lcore_id' is used before
> > validity check, which may cause buffer 'global_fds' accessed by index
> > 'lcore_id' overflow.
> >
> > This patch moves the validity check of 'lcore_id' before the 'lcore_id'
> > being used for the first time.
> >
> > Fixes: 9dc843eb273b ("power: extend guest channel API for reading")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: HongBo Zheng <zhenghongbo3@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> > ---
> > v2:
> > * "global_fds[lcore_id]" check may move before the line
> > "fds.fd = global_fds[lcore_id].
>
>
> Hi Connor,
>
> Just for future reference, it is common to include tags from previous
> version of a patch set unless there's major changes. So it would have
> been good to include Reshma's "Reviewed-by" tag in v2.
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied with Reshma's tag, thanks.
title: power: fix sanity checks for guest channel read
prev parent reply other threads:[~2021-05-12 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 12:59 [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check Min Hu (Connor)
2021-04-28 15:13 ` Pattan, Reshma
2021-04-29 0:43 ` Min Hu (Connor)
2021-05-11 13:25 ` Thomas Monjalon
2021-05-11 13:34 ` Pattan, Reshma
2021-05-12 2:19 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-12 7:03 ` David Hunt
2021-05-12 7:14 ` Min Hu (Connor)
2021-05-12 7:41 ` David Hunt
2021-05-12 15:19 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1895782.HPLxxfrSh9@thomas \
--to=thomas@monjalon.net \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.