From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check
Date: Tue, 11 May 2021 13:34:33 +0000 [thread overview]
Message-ID: <BYAPR11MB3366C8F38F89A7F8EF844032FF539@BYAPR11MB3366.namprd11.prod.outlook.com> (raw)
In-Reply-To: <d1dcb8b1-9fd2-a779-cf93-aeadae3d7c48@huawei.com>
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> > Another suggestion if you would like to improve the code, is below,
> > You can move "global_fds[lcore_id]" check to immediate after the line
> "fds.fd = global_fds[lcore_id]; "
> Hi, thanks Pattan.
> But I think "global_fds[lcore_id]" check may move before the line
> "fds.fd = global_fds[lcore_id];
> If it failed, "fds.fd = global_fds[lcore_id];" should not be performed.
> What's your opinion?
>
That is correct. You can do that change.
next prev parent reply other threads:[~2021-05-11 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 12:59 [dpdk-dev] [PATCH] lib/librte_power: fix using variables before validity check Min Hu (Connor)
2021-04-28 15:13 ` Pattan, Reshma
2021-04-29 0:43 ` Min Hu (Connor)
2021-05-11 13:25 ` Thomas Monjalon
2021-05-11 13:34 ` Pattan, Reshma [this message]
2021-05-12 2:19 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-12 7:03 ` David Hunt
2021-05-12 7:14 ` Min Hu (Connor)
2021-05-12 7:41 ` David Hunt
2021-05-12 15:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3366C8F38F89A7F8EF844032FF539@BYAPR11MB3366.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.