All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Will Deacon <Will.Deacon@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	Lina Iyer <lina.iyer@linaro.org>,
	Chander Kashyap <k.chander@samsung.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Nicolas Pitre <nico@linaro.org>,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	Charles Garcia-Tobin <Charles.Garcia-Tobin@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Kevin Hilman <khilman@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Sebastian Capella <sebcape@gmail.com>,
	Mark Brown <broonie@kernel.org>, Antti Miettinen <ananaza@iki.fi>,
	Paul Walmsley <paul@pwsan.com>,
	Geoff Levand <geoff@infradead.org>,
	Peter
Subject: Re: [PATCH v8 6/8] drivers: cpuidle: CPU idle ARM64 driver
Date: Mon, 29 Sep 2014 12:08:04 +0100	[thread overview]
Message-ID: <20140929110804.GC2165@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <5415C968.90303@gmail.com>

On Sun, Sep 14, 2014 at 05:59:20PM +0100, Tomasz Figa wrote:

[...]

> About the patch 8 alone, somebody would have to test it. Maybe Bart or
> Krzysztof could find some time to look at this? Other than that, I'm not
> quite sure about entry latency you specified. It would look like
> entering the state takes longer time than leaving, which I believe is
> not the case. However I can't find any place in the code which would use
> entry latency, so it might not be that important for now.

I added that entry latency value because I thought that when entering that
idle state the CPU had to flush the outercache, which I do not think that's
what's really happening on Exynos.

Since Bart's patch to define cpu nodes in DT is making it to the
mainline, this leaves us time to find out what that entry-latency-us value
should be and patch the dts accordingly (Exynos CPUidle DT changes are
not making it for this cycle, so we have time to update the patch
accordingly).

entry-latency-us is used to compute CPUidle exit_latency so it has to be
correct, and I rely on Samsung guys to provide me with that value, or
I will ask them to set it properly for me.

Thanks,
Lorenzo


WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 6/8] drivers: cpuidle: CPU idle ARM64 driver
Date: Mon, 29 Sep 2014 12:08:04 +0100	[thread overview]
Message-ID: <20140929110804.GC2165@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <5415C968.90303@gmail.com>

On Sun, Sep 14, 2014 at 05:59:20PM +0100, Tomasz Figa wrote:

[...]

> About the patch 8 alone, somebody would have to test it. Maybe Bart or
> Krzysztof could find some time to look at this? Other than that, I'm not
> quite sure about entry latency you specified. It would look like
> entering the state takes longer time than leaving, which I believe is
> not the case. However I can't find any place in the code which would use
> entry latency, so it might not be that important for now.

I added that entry latency value because I thought that when entering that
idle state the CPU had to flush the outercache, which I do not think that's
what's really happening on Exynos.

Since Bart's patch to define cpu nodes in DT is making it to the
mainline, this leaves us time to find out what that entry-latency-us value
should be and patch the dts accordingly (Exynos CPUidle DT changes are
not making it for this cycle, so we have time to update the patch
accordingly).

entry-latency-us is used to compute CPUidle exit_latency so it has to be
correct, and I rely on Samsung guys to provide me with that value, or
I will ask them to set it properly for me.

Thanks,
Lorenzo

  parent reply	other threads:[~2014-09-29 11:08 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 15:28 [PATCH v8 0/8] ARM generic idle states Lorenzo Pieralisi
2014-09-01 15:28 ` Lorenzo Pieralisi
2014-09-01 15:28 ` [PATCH v8 1/8] arm64: kernel: refactor the CPU suspend API for retention states Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
     [not found] ` <1409585324-3678-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
2014-09-01 15:28   ` [PATCH v8 2/8] Documentation: arm: define DT idle states bindings Lorenzo Pieralisi
2014-09-01 15:28     ` Lorenzo Pieralisi
2014-09-01 15:28 ` [PATCH v8 3/8] drivers: cpuidle: implement DT based idle states infrastructure Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
2014-09-03 13:25   ` Daniel Lezcano
2014-09-03 13:25     ` Daniel Lezcano
2014-09-03 17:30     ` Lorenzo Pieralisi
2014-09-03 17:30       ` Lorenzo Pieralisi
2014-09-01 15:28 ` [PATCH v8 4/8] arm64: kernel: introduce cpu_init_idle CPU operation Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
2014-09-03 17:34   ` Lina Iyer
2014-09-03 17:34     ` Lina Iyer
2014-09-03 17:46     ` Lorenzo Pieralisi
2014-09-03 17:46       ` Lorenzo Pieralisi
2014-09-03 19:16       ` Lina Iyer
2014-09-03 19:16         ` Lina Iyer
2014-09-01 15:28 ` [PATCH v8 5/8] arm64: add PSCI CPU_SUSPEND based cpu_suspend support Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
2014-09-01 15:28 ` [PATCH v8 6/8] drivers: cpuidle: CPU idle ARM64 driver Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
2014-09-03 17:37   ` Lorenzo Pieralisi
2014-09-03 17:37     ` Lorenzo Pieralisi
2014-09-04 16:03     ` Catalin Marinas
2014-09-04 16:03       ` Catalin Marinas
2014-09-04 17:29       ` Lorenzo Pieralisi
2014-09-04 17:29         ` Lorenzo Pieralisi
2014-09-05  9:21         ` Will Deacon
2014-09-05  9:21           ` Will Deacon
2014-09-05 15:34           ` Lorenzo Pieralisi
2014-09-05 15:34             ` Lorenzo Pieralisi
2014-09-11  8:28             ` Daniel Lezcano
2014-09-11  8:28               ` Daniel Lezcano
2014-09-11  8:57               ` Lorenzo Pieralisi
2014-09-11  8:57                 ` Lorenzo Pieralisi
     [not found]                 ` <20140911085727.GA25773-7AyDDHkRsp3ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-09-11  9:32                   ` Daniel Lezcano
2014-09-11  9:32                     ` Daniel Lezcano
2014-09-12 10:32                     ` Catalin Marinas
2014-09-12 10:32                       ` Catalin Marinas
2014-09-12 11:26                       ` Lorenzo Pieralisi
2014-09-12 11:26                         ` Lorenzo Pieralisi
2014-09-23 13:35                         ` Bartlomiej Zolnierkiewicz
2014-09-23 13:35                           ` Bartlomiej Zolnierkiewicz
2014-09-23 18:14                           ` Lorenzo Pieralisi
2014-09-23 18:14                             ` Lorenzo Pieralisi
2014-09-14 16:59                 ` Tomasz Figa
2014-09-14 16:59                   ` Tomasz Figa
2014-09-23 13:42                   ` Bartlomiej Zolnierkiewicz
2014-09-23 13:42                     ` Bartlomiej Zolnierkiewicz
2014-09-23 18:16                     ` Lorenzo Pieralisi
2014-09-23 18:16                       ` Lorenzo Pieralisi
2014-09-29 11:08                   ` Lorenzo Pieralisi [this message]
2014-09-29 11:08                     ` Lorenzo Pieralisi
2014-09-01 15:28 ` [PATCH v8 7/8] drivers: cpuidle: initialize big.LITTLE driver through DT Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
2014-09-03 13:29   ` Daniel Lezcano
2014-09-03 13:29     ` Daniel Lezcano
2014-09-01 15:28 ` [PATCH v8 8/8] drivers: cpuidle: initialize Exynos " Lorenzo Pieralisi
2014-09-01 15:28   ` Lorenzo Pieralisi
2014-09-03 13:32   ` Daniel Lezcano
2014-09-03 13:32     ` Daniel Lezcano
2014-09-03 17:29     ` Lorenzo Pieralisi
2014-09-03 17:29       ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140929110804.GC2165@e102568-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Charles.Garcia-Tobin@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=ananaza@iki.fi \
    --cc=ashwin.chaugule@linaro.org \
    --cc=broonie@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geoff@infradead.org \
    --cc=grant.likely@linaro.org \
    --cc=k.chander@samsung.com \
    --cc=khilman@linaro.org \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nico@linaro.org \
    --cc=paul@pwsan.com \
    --cc=sebcape@gmail.com \
    --cc=tomasz.figa@gmail.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.