From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs
Date: Sat, 30 May 2015 08:48:00 -0700 [thread overview]
Message-ID: <20150530084800.56e3585e@urahara> (raw)
In-Reply-To: <1432946276-9424-3-git-send-email-liang-min.wang@intel.com>
On Fri, 29 May 2015 20:37:56 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:
> adding a new library based upon ethdev APIs to provide API's that bear
> the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops
> (linux/netdevice.h).
The API's for ethtool like things are valuable, but please contain
it more.
I think you should contain this to only those things which are in
the original Linux ethtool. Adding yet another layer that calls DPDK
for open/close/start stop just adds more layers with out providing any
value.
The ones I would keep:
get_driverinfo
get_link
The ones I would add:
cmd - for speed/duplex negotiation
eeprom - for eeprom access
eee - for energy awareness
coalesce - for packet coalescing
ringparam - to allow changing ring parameters
(existing rx config model is limiting)
pauseparam - existing flow control in DPDK is mess
gstrings/stats - map to XSTATS
test - for offline tests
dump - for register dump
features - control offload features
perm_addr - base mac address
next prev parent reply other threads:[~2015-05-30 15:47 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-30 0:37 [PATCH 0/2] User-space Ethtool Liang-Min Larry Wang
2015-05-30 0:37 ` [PATCH 1/2] ethdev: add api to set default mac address Liang-Min Larry Wang
2015-05-30 1:57 ` Andrew Harvey (agh)
2015-05-30 0:37 ` [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Liang-Min Larry Wang
2015-05-30 15:48 ` Stephen Hemminger [this message]
2015-05-30 16:16 ` Wang, Liang-min
2015-05-30 19:26 ` Stephen Hemminger
2015-05-30 19:40 ` Wang, Liang-min
2015-05-31 16:48 ` Stephen Hemminger
2015-05-31 17:30 ` Wang, Liang-min
2015-05-31 18:31 ` Wang, Liang-min
2015-06-01 12:42 ` David Harton (dharton)
2015-06-10 15:09 ` [PATCH v4 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-10 15:09 ` [PATCH v4 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-10 15:21 ` David Harton (dharton)
2015-06-11 12:26 ` Ananyev, Konstantin
2015-06-11 12:57 ` Wang, Liang-min
2015-06-11 13:07 ` Ananyev, Konstantin
2015-06-11 21:51 ` Wang, Liang-min
2015-06-12 12:30 ` Ananyev, Konstantin
2015-06-15 13:26 ` Wang, Liang-min
2015-06-15 13:45 ` Ananyev, Konstantin
2015-06-15 14:47 ` Wang, Liang-min
2015-06-15 18:10 ` Ananyev, Konstantin
2015-06-17 17:25 ` Ananyev, Konstantin
2015-06-15 16:05 ` David Harton (dharton)
2015-06-15 18:23 ` Ananyev, Konstantin
2015-06-16 18:15 ` Ananyev, Konstantin
2015-06-11 13:14 ` Ananyev, Konstantin
2015-06-11 13:25 ` Wang, Liang-min
2015-06-10 15:09 ` [PATCH v4 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-10 15:09 ` [PATCH v4 3/4] igb: " Liang-Min Larry Wang
2015-06-10 15:09 ` [PATCH v4 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-11 21:43 ` [PATCH v5 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-11 21:43 ` [PATCH v5 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-11 21:43 ` [PATCH v5 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-11 21:43 ` [PATCH v5 3/4] igb: " Liang-Min Larry Wang
2015-06-11 21:43 ` [PATCH v5 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-12 22:03 ` [PATCH v6 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-12 22:03 ` [PATCH v6 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-13 23:25 ` David Harton (dharton)
2015-06-12 22:03 ` [PATCH v6 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-12 22:03 ` [PATCH v6 3/4] igb: " Liang-Min Larry Wang
2015-06-12 22:03 ` [PATCH v6 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-13 0:21 ` [PATCH v6 0/4] User-space Ethtool Andrew Harvey (agh)
2015-06-17 22:22 ` [PATCH v7 " Liang-Min Larry Wang
2015-06-17 22:22 ` [PATCH v7 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-25 13:39 ` Stephen Hemminger
2015-06-25 20:58 ` Wang, Liang-min
2015-06-25 13:44 ` Stephen Hemminger
2015-06-25 21:05 ` Wang, Liang-min
2015-06-17 22:22 ` [PATCH v7 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-25 13:45 ` Stephen Hemminger
2015-06-26 6:26 ` Andrew Harvey (agh)
2015-06-17 22:22 ` [PATCH v7 3/4] igb: " Liang-Min Larry Wang
2015-06-17 22:22 ` [PATCH v7 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-18 2:04 ` [PATCH v7 0/4] User-space Ethtool Stephen Hemminger
2015-06-18 12:47 ` Wang, Liang-min
2015-06-23 15:19 ` Wang, Liang-min
2015-06-24 13:55 ` Andrew Harvey (agh)
2015-06-24 17:16 ` David Harton (dharton)
2015-06-26 14:26 ` [PATCH v8 0/5] " Liang-Min Larry Wang
2015-06-26 14:26 ` [PATCH v8 1/5] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-26 16:51 ` Stephen Hemminger
2015-06-26 17:05 ` Wang, Liang-min
2015-06-27 1:21 ` Wang, Liang-min
2015-06-26 14:26 ` [PATCH v8 2/5] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-26 14:26 ` [PATCH v8 3/5] igb: " Liang-Min Larry Wang
2015-06-26 14:26 ` [PATCH v8 4/5] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-26 14:26 ` [PATCH v8 5/5] Changed register tables to const Liang-Min Larry Wang
2015-06-26 19:15 ` [PATCH v8 0/5] User-space Ethtool Ananyev, Konstantin
2015-06-27 1:19 ` [PATCH v9 " Liang-Min Larry Wang
2015-06-27 1:19 ` [PATCH v9 1/5] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-27 1:19 ` [PATCH v9 2/5] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-27 1:32 ` Stephen Hemminger
2015-06-27 2:37 ` Wang, Liang-min
2015-06-27 1:34 ` Stephen Hemminger
2015-06-27 2:39 ` Wang, Liang-min
2015-06-27 1:34 ` Stephen Hemminger
2015-06-27 1:19 ` [PATCH v9 3/5] igb: " Liang-Min Larry Wang
2015-06-27 1:35 ` Stephen Hemminger
2015-06-27 1:19 ` [PATCH v9 4/5] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-27 1:19 ` [PATCH v9 5/5] ixgbe/igb: changed register tables to const Liang-Min Larry Wang
2015-06-27 1:36 ` Stephen Hemminger
2015-06-27 1:50 ` Wang, Liang-min
2015-06-27 2:40 ` Wang, Liang-min
2015-07-10 12:55 ` Wang, Liang-min
2015-06-27 2:36 ` [PATCH v10 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-27 2:36 ` [PATCH v10 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-27 2:36 ` [PATCH v10 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-27 2:36 ` [PATCH v10 3/4] igb: " Liang-Min Larry Wang
2015-06-27 2:36 ` [PATCH v10 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-06-27 12:25 ` [PATCH v11 0/4] User-space Ethtool Liang-Min Larry Wang
2015-06-27 12:25 ` [PATCH v11 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-06-27 12:25 ` [PATCH v11 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-06-27 12:25 ` [PATCH v11 3/4] igb: " Liang-Min Larry Wang
2015-06-27 12:25 ` [PATCH v11 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-07 17:39 ` [PATCH v12 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-07 17:39 ` [PATCH v12 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-07 17:39 ` [PATCH v12 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-07 17:39 ` [PATCH v12 3/4] igb: " Liang-Min Larry Wang
2015-07-07 17:39 ` [PATCH v12 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-10 12:48 ` [PATCH v13 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-10 12:48 ` [PATCH v13 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-10 12:48 ` [PATCH v13 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-10 12:48 ` [PATCH v13 3/4] igb: " Liang-Min Larry Wang
2015-07-10 12:48 ` [PATCH v13 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-12 21:22 ` [PATCH v14 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-12 21:22 ` [PATCH v14 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-13 22:26 ` Thomas Monjalon
2015-07-12 21:22 ` [PATCH v14 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-12 21:22 ` [PATCH v14 3/4] igb: " Liang-Min Larry Wang
2015-07-12 21:22 ` [PATCH v14 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-14 2:18 ` [PATCH v15 0/4] User-space Ethtool Liang-Min Larry Wang
2015-07-14 2:18 ` [PATCH v15 1/4] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-15 6:16 ` Thomas Monjalon
2015-07-15 10:07 ` Wang, Liang-min
2015-07-15 10:27 ` Thomas Monjalon
2015-07-15 10:48 ` Wang, Liang-min
2015-07-15 11:20 ` Thomas Monjalon
2015-07-15 11:36 ` Wang, Liang-min
2015-07-15 12:06 ` Thomas Monjalon
2015-07-14 2:18 ` [PATCH v15 2/4] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-14 2:18 ` [PATCH v15 3/4] igb: " Liang-Min Larry Wang
2015-07-14 2:18 ` [PATCH v15 4/4] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 0/6] User-space Ethtool Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 1/6] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 2/6] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 3/6] igb: " Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 4/6] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 5/6] ethdev: change api name, version information and fix macro Liang-Min Larry Wang
2015-07-14 13:11 ` [PATCH v16 6/6] examples/l2fwd-ethtool: replace lib with new API name Liang-Min Larry Wang
2015-07-14 20:13 ` [PATCH v16 0/6] User-space Ethtool Thomas Monjalon
2015-07-14 20:56 ` Wang, Liang-min
2015-07-15 5:53 ` Thomas Monjalon
2015-07-15 10:15 ` Wang, Liang-min
2015-07-15 10:30 ` Thomas Monjalon
2015-07-16 13:25 ` [PATCH v17 0/5] " Liang-Min Larry Wang
2015-07-16 13:25 ` [PATCH v17 1/5] ethdev: add api to support setting default mac addr Liang-Min Larry Wang
2015-07-16 13:25 ` [PATCH v17 2/5] ethdev: add apis to support access device info Liang-Min Larry Wang
2015-07-16 13:25 ` [PATCH v17 3/5] ixgbe: add ops to support ethtool ops Liang-Min Larry Wang
2015-07-16 13:25 ` [PATCH v17 4/5] igb: " Liang-Min Larry Wang
2015-07-16 13:25 ` [PATCH v17 5/5] examples: new example: l2fwd-ethtool Liang-Min Larry Wang
2015-07-16 21:25 ` Thomas Monjalon
2015-07-16 21:48 ` [PATCH v17 0/5] User-space Ethtool Thomas Monjalon
2015-07-16 21:55 ` Wang, Liang-min
2015-07-16 22:09 ` Thomas Monjalon
2015-07-16 22:15 ` Wang, Liang-min
-- strict thread matches above, loose matches on Subject: below --
2015-05-29 19:26 [PATCH 0/2] " Liang-Min Larry Wang
2015-05-29 19:26 ` [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Liang-Min Larry Wang
2015-06-02 12:38 ` Thomas Monjalon
2015-06-02 13:15 ` Wang, Liang-min
2015-06-02 14:32 ` Thomas Monjalon
2015-06-02 15:47 ` Wang, Liang-min
2015-06-02 16:02 ` Thomas Monjalon
2015-06-02 17:06 ` Wang, Liang-min
2015-06-02 20:37 ` Thomas Monjalon
2015-06-02 20:56 ` Wang, Liang-min
2015-06-03 1:00 ` David Harton (dharton)
2015-06-03 2:09 ` Andrew Harvey (agh)
2015-06-04 14:25 ` O'Driscoll, Tim
2015-06-04 14:58 ` Stephen Hemminger
2015-06-04 22:10 ` Andrew Harvey (agh)
2015-06-05 10:46 ` Thomas Monjalon
2015-06-05 11:25 ` Wang, Liang-min
2015-06-05 12:47 ` Bruce Richardson
2015-06-05 17:24 ` Andrew Harvey (agh)
2015-06-05 21:03 ` Thomas Monjalon
2015-06-05 13:40 ` Thomas Monjalon
2015-06-05 14:20 ` Wang, Liang-min
2015-06-05 16:07 ` Andrew Harvey (agh)
2015-06-05 20:57 ` Thomas Monjalon
2015-05-29 13:15 [PATCH 0/2] User-space Ethtool Liang-Min Larry Wang
2015-05-29 13:15 ` [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Liang-Min Larry Wang
2015-05-29 15:22 ` Stephen Hemminger
2015-05-29 18:17 ` Wang, Liang-min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530084800.56e3585e@urahara \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liang-min.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.