From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, Vishnu Patekar <vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Subject: Re: [PATCH v2 3/6] ARM: dts: sun8i: Add sun8i-a23-a33 dtsi Date: Tue, 2 Jun 2015 10:21:55 +0200 [thread overview] Message-ID: <20150602082155.GP23777@lukather> (raw) In-Reply-To: <556D6487.4010207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2678 bytes --] On Tue, Jun 02, 2015 at 10:08:39AM +0200, Hans de Goede wrote: > Hi, > > On 02-06-15 09:51, Maxime Ripard wrote: > >On Sat, May 30, 2015 at 04:55:03PM +0200, Hans de Goede wrote: > >>From: Vishnu Patekar <vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> > >>Rename sun8i-a23.dtsi to sun8i-a23-a33.dtsi as the base dtsi for the A33 > >>is 99% the same and add a new sun8i-a23.dtsi including sun8i-a23-a33.dtsi > >>and setting the few things not shared with the A33 (mbus-clk, pio > >>compatible and interrupts). > >> > >>Signed-off-by: Vishnu Patekar <vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > > > >Fixed the conflicts and applied. > > > >Also judging from a quick look at the datasheet, the A33 doesn't seem > >to have that clock gates tree but rather one similar to the H3's. That > >will probably mean we'll have to move out the gates from this DTSI at > >some point. > > Heuh... > > Ok so I've done a full bit for bit comparison of the 2 datasheets for > the clk gates, mostly they are mostly the same and the registers seem to > just be renamed. > > The only differences are: > > 01c200060 (AHB1 MODULE CLOCK GATING REGISTER 0 / Bus Clock Gating Register 0): > > Only A33 has bit 5 SS gating > > 01c200064 (AHB1 MODULE CLOCK GATING REGISTER 1 / Bus Clock Gating Register 1): > > Only A33 has bit 26 SAT gating, note that if we add support for this we > must add it as a needed clock to the simplefb node > > Only A33 has bit 21 MSGBOX_GATING > > 01c200068 (APB1 MODULE CLOCK GATING REGISTER / Bus Clock Gating Register 2): > > No differences > > 01c20006c (APB2 MODULE CLOCK GATING REGISTER / Bus Clock Gating Register 3): > > No differences > > > So you are right that in the near future we should add a separate compatible > + clk driver or the ahb1_gates on the A33, but it does not seem that there is > the issue of one gate register having multiple parents like on the H3. Or maybe > the H3 does also not have that issue, and this is a misinterpretation of > the H3 datasheet ? I might have been misguided by the clock name (AHB1, APB1, etc... gates vs bus gates). If it's just as simple as that, then yeah, we'll probably don't need the H3 bus gates driver for this. > Note I do not know what the actual parent clock for the new gates is, but > it stands to reason that it is AHB1, I've been unable to find anything to > confirm or deny this. That's always something we can change if we find that it's not the case. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/6] ARM: dts: sun8i: Add sun8i-a23-a33 dtsi Date: Tue, 2 Jun 2015 10:21:55 +0200 [thread overview] Message-ID: <20150602082155.GP23777@lukather> (raw) In-Reply-To: <556D6487.4010207@redhat.com> On Tue, Jun 02, 2015 at 10:08:39AM +0200, Hans de Goede wrote: > Hi, > > On 02-06-15 09:51, Maxime Ripard wrote: > >On Sat, May 30, 2015 at 04:55:03PM +0200, Hans de Goede wrote: > >>From: Vishnu Patekar <vishnupatekar0510@gmail.com> > >> > >>Rename sun8i-a23.dtsi to sun8i-a23-a33.dtsi as the base dtsi for the A33 > >>is 99% the same and add a new sun8i-a23.dtsi including sun8i-a23-a33.dtsi > >>and setting the few things not shared with the A33 (mbus-clk, pio > >>compatible and interrupts). > >> > >>Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com> > >>Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > > >Fixed the conflicts and applied. > > > >Also judging from a quick look at the datasheet, the A33 doesn't seem > >to have that clock gates tree but rather one similar to the H3's. That > >will probably mean we'll have to move out the gates from this DTSI at > >some point. > > Heuh... > > Ok so I've done a full bit for bit comparison of the 2 datasheets for > the clk gates, mostly they are mostly the same and the registers seem to > just be renamed. > > The only differences are: > > 01c200060 (AHB1 MODULE CLOCK GATING REGISTER 0 / Bus Clock Gating Register 0): > > Only A33 has bit 5 SS gating > > 01c200064 (AHB1 MODULE CLOCK GATING REGISTER 1 / Bus Clock Gating Register 1): > > Only A33 has bit 26 SAT gating, note that if we add support for this we > must add it as a needed clock to the simplefb node > > Only A33 has bit 21 MSGBOX_GATING > > 01c200068 (APB1 MODULE CLOCK GATING REGISTER / Bus Clock Gating Register 2): > > No differences > > 01c20006c (APB2 MODULE CLOCK GATING REGISTER / Bus Clock Gating Register 3): > > No differences > > > So you are right that in the near future we should add a separate compatible > + clk driver or the ahb1_gates on the A33, but it does not seem that there is > the issue of one gate register having multiple parents like on the H3. Or maybe > the H3 does also not have that issue, and this is a misinterpretation of > the H3 datasheet ? I might have been misguided by the clock name (AHB1, APB1, etc... gates vs bus gates). If it's just as simple as that, then yeah, we'll probably don't need the H3 bus gates driver for this. > Note I do not know what the actual parent clock for the new gates is, but > it stands to reason that it is AHB1, I've been unable to find anything to > confirm or deny this. That's always something we can change if we find that it's not the case. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150602/ce9ced6c/attachment.sig>
next prev parent reply other threads:[~2015-06-02 8:21 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-30 14:55 [PATCH v2 0/6] Introduce Allwinner A33 support Hans de Goede 2015-05-30 14:55 ` Hans de Goede [not found] ` <1432997706-20172-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-05-30 14:55 ` [PATCH v2 1/6] ARM: sunxi: Add Machine support for A33 Hans de Goede 2015-05-30 14:55 ` Hans de Goede [not found] ` <1432997706-20172-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-02 7:28 ` Maxime Ripard 2015-06-02 7:28 ` Maxime Ripard 2015-05-30 14:55 ` [PATCH v2 2/6] pinctrl: sunxi: Add allwinner A33 PIO controller support Hans de Goede 2015-05-30 14:55 ` Hans de Goede 2015-05-30 14:55 ` [PATCH v2 3/6] ARM: dts: sun8i: Add sun8i-a23-a33 dtsi Hans de Goede 2015-05-30 14:55 ` Hans de Goede [not found] ` <1432997706-20172-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-02 7:51 ` Maxime Ripard 2015-06-02 7:51 ` Maxime Ripard 2015-06-02 8:08 ` Hans de Goede 2015-06-02 8:08 ` Hans de Goede [not found] ` <556D6487.4010207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-02 8:21 ` Maxime Ripard [this message] 2015-06-02 8:21 ` Maxime Ripard 2015-05-30 14:55 ` [PATCH v2 4/6] ARM: dts: sun8i: Add sun8i-a33 dtsi Hans de Goede 2015-05-30 14:55 ` Hans de Goede [not found] ` <1432997706-20172-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-02 7:55 ` Maxime Ripard 2015-06-02 7:55 ` Maxime Ripard 2015-05-30 14:55 ` [PATCH v2 5/6] ARM: dts: sun8i: Add ET-Q8 A33 support Hans de Goede 2015-05-30 14:55 ` Hans de Goede [not found] ` <1432997706-20172-6-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-02 7:56 ` Maxime Ripard 2015-06-02 7:56 ` Maxime Ripard 2015-05-30 14:55 ` [PATCH v2 6/6] ARM: sun8i: dts: Add Ippo-q8h v1.2 with A33 and 1024x600 lcd support Hans de Goede 2015-05-30 14:55 ` Hans de Goede [not found] ` <1432997706-20172-7-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-02 8:14 ` Maxime Ripard 2015-06-02 8:14 ` Maxime Ripard 2015-06-02 8:29 ` Hans de Goede 2015-06-02 8:29 ` Hans de Goede [not found] ` <556D6955.8030708-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-03 9:45 ` Maxime Ripard 2015-06-03 9:45 ` Maxime Ripard 2015-06-03 11:12 ` Hans de Goede 2015-06-03 11:12 ` Hans de Goede [not found] ` <556EE104.3090803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-13 13:50 ` Maxime Ripard 2015-06-13 13:50 ` Maxime Ripard 2015-06-13 14:18 ` Hans de Goede 2015-06-13 14:18 ` Hans de Goede [not found] ` <557C3BD3.6030105-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-16 17:41 ` Maxime Ripard 2015-06-16 17:41 ` Maxime Ripard 2015-06-17 7:16 ` Hans de Goede 2015-06-17 7:16 ` Hans de Goede [not found] ` <55811EB2.4060302-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-18 18:37 ` Maxime Ripard 2015-06-18 18:37 ` Maxime Ripard 2015-06-18 20:16 ` Hans de Goede 2015-06-18 20:16 ` Hans de Goede 2015-06-14 18:16 ` Pantelis Antoniou 2015-06-14 18:16 ` Pantelis Antoniou [not found] ` <85E62D2D-5387-433B-A944-7F2145459F08-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> 2015-06-16 17:55 ` Maxime Ripard 2015-06-16 17:55 ` Maxime Ripard 2015-06-16 19:33 ` Pantelis Antoniou 2015-06-16 19:33 ` Pantelis Antoniou [not found] ` <D4216F2D-0556-4849-B1DF-8E4D250006B4-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> 2015-06-17 7:19 ` Hans de Goede 2015-06-17 7:19 ` Hans de Goede [not found] ` <55811F94.3080608-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-17 7:26 ` Pantelis Antoniou 2015-06-17 7:26 ` Pantelis Antoniou 2015-06-17 7:16 ` Hans de Goede 2015-06-17 7:16 ` Hans de Goede [not found] ` <55811ED9.9090503-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2015-06-18 17:52 ` Maxime Ripard 2015-06-18 17:52 ` Maxime Ripard 2015-05-30 20:43 ` [PATCH v2 0/6] Introduce Allwinner A33 support jonsmirl-Re5JQEeQqe8AvxtiuMwx3w 2015-05-30 20:43 ` [linux-sunxi] " jonsmirl at gmail.com 2015-06-02 7:43 ` Chen-Yu Tsai 2015-06-02 7:43 ` Chen-Yu Tsai 2016-06-13 19:10 ` ernestovm07 2016-06-13 19:10 ` ernestovm07 at gmail.com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150602082155.GP23777@lukather \ --to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \ --cc=vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=wens-jdAy2FN1RRM@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.