From: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c-tools: enable static use of libi2c
Date: Wed, 17 Jun 2015 11:06:15 +0200 [thread overview]
Message-ID: <20150617110615.7c7cb411@endymion.delvare> (raw)
In-Reply-To: <1434420079-3029-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Hallo Wolfram,
On Tue, 16 Jun 2015 04:01:19 +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
>
> When debugging embedded systems, it is often nice to simply TFTP the
> desired i2ctool to the target without the hazzle of dealing with shared
> libs. Using -static is overkill, too, so let's add a switch which will
> only link functions from libi2c statically.
Fine with me.
> Signed-off-by: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
> ---
> Makefile | 2 ++
> tools/Module.mk | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 252a126..6d36f2f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -33,6 +33,8 @@ CFLAGS += -Wall
> SOCFLAGS := -fpic -D_REENTRANT $(CFLAGS)
>
> BUILD_STATIC_LIB ?= 1
> +# Uncomment to use static libi2c
> +#USE_STATIC_LIB := 1
Any reason for not using ?= as above, with the default being unset?
That way BUILD_STATIC_LIB and USE_STATIC_LIB can both be controlled
using the same mechanism, and can be changed from their default value
on the command line (without patching the Makefile.)
>
> KERNELVERSION := $(shell uname -r)
>
> diff --git a/tools/Module.mk b/tools/Module.mk
> index d14bb0c..8efddbb 100644
> --- a/tools/Module.mk
> +++ b/tools/Module.mk
> @@ -12,7 +12,11 @@ TOOLS_DIR := tools
> TOOLS_CFLAGS := -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \
> -Wcast-align -Wwrite-strings -Wnested-externs -Winline \
> -W -Wundef -Wmissing-prototypes -Iinclude
> +ifeq ($(USE_STATIC_LIB),1)
> +TOOLS_LDFLAGS := $(LIB_DIR)/$(LIB_STLIBNAME)
> +else
> TOOLS_LDFLAGS := -Llib -li2c
> +endif
Unrelated to your patch, but shouldn't this -Llib rather been written
-L$(LIB_DIR)?
Also it might make sense to check if USE_STATIC_LIB is set when
BUILD_STATIC_LIB isn't and complain about it?
>
> TOOLS_TARGETS := i2cdetect i2cdump i2cset i2cget
>
--
Jean Delvare
SUSE L3 Support
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c-tools: enable static use of libi2c
Date: Wed, 17 Jun 2015 09:06:15 +0000 [thread overview]
Message-ID: <20150617110615.7c7cb411@endymion.delvare> (raw)
In-Reply-To: <1434420079-3029-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Hallo Wolfram,
On Tue, 16 Jun 2015 04:01:19 +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When debugging embedded systems, it is often nice to simply TFTP the
> desired i2ctool to the target without the hazzle of dealing with shared
> libs. Using -static is overkill, too, so let's add a switch which will
> only link functions from libi2c statically.
Fine with me.
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Makefile | 2 ++
> tools/Module.mk | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 252a126..6d36f2f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -33,6 +33,8 @@ CFLAGS += -Wall
> SOCFLAGS := -fpic -D_REENTRANT $(CFLAGS)
>
> BUILD_STATIC_LIB ?= 1
> +# Uncomment to use static libi2c
> +#USE_STATIC_LIB := 1
Any reason for not using ?= as above, with the default being unset?
That way BUILD_STATIC_LIB and USE_STATIC_LIB can both be controlled
using the same mechanism, and can be changed from their default value
on the command line (without patching the Makefile.)
>
> KERNELVERSION := $(shell uname -r)
>
> diff --git a/tools/Module.mk b/tools/Module.mk
> index d14bb0c..8efddbb 100644
> --- a/tools/Module.mk
> +++ b/tools/Module.mk
> @@ -12,7 +12,11 @@ TOOLS_DIR := tools
> TOOLS_CFLAGS := -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \
> -Wcast-align -Wwrite-strings -Wnested-externs -Winline \
> -W -Wundef -Wmissing-prototypes -Iinclude
> +ifeq ($(USE_STATIC_LIB),1)
> +TOOLS_LDFLAGS := $(LIB_DIR)/$(LIB_STLIBNAME)
> +else
> TOOLS_LDFLAGS := -Llib -li2c
> +endif
Unrelated to your patch, but shouldn't this -Llib rather been written
-L$(LIB_DIR)?
Also it might make sense to check if USE_STATIC_LIB is set when
BUILD_STATIC_LIB isn't and complain about it?
>
> TOOLS_TARGETS := i2cdetect i2cdump i2cset i2cget
>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-06-17 9:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 2:01 [PATCH] i2c-tools: enable static use of libi2c Wolfram Sang
2015-06-16 2:01 ` Wolfram Sang
[not found] ` <1434420079-3029-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-06-17 9:06 ` Jean Delvare [this message]
2015-06-17 9:06 ` Jean Delvare
2015-06-17 10:53 ` Wolfram Sang
2015-06-17 10:53 ` Wolfram Sang
2015-06-17 13:10 ` Jean Delvare
2015-06-17 13:10 ` Jean Delvare
[not found] ` <20150617151025.1353abe3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-06-17 13:20 ` Wolfram Sang
2015-06-17 13:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617110615.7c7cb411@endymion.delvare \
--to=jdelvare-l3a5bk7wagm@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.