From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
Boaz Harrosh <boaz@plexistor.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Rui Wang <ruiv.wang@gmail.com>, Jean Delvare <jdelvare@suse.de>,
Alun Evans <alun@badgerous.net>, Robert Elliott <Elliott@hp.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Paul Bolle <pebolle@tiscali.nl>, Tony Luck <tony.luck@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips
Date: Wed, 17 Jun 2015 08:12:51 -0700 [thread overview]
Message-ID: <20150617151251.GA1043@roeck-us.net> (raw)
In-Reply-To: <20150617131841.GI13393@katana>
On Wed, Jun 17, 2015 at 03:18:42PM +0200, Wolfram Sang wrote:
>
> > > Having said that, I am still not convinced that the driver should be in the kernel
> > > to start with. Browsing through Intel's datasheets, the registers are supported
> > > in E5-2600 v1, v2, and v3. However, in v3 Intel added a note saying that the registers
> > > should not be accessed by the OS directly, but only through the bios. Given that,
> > > and if that is possible, it might make more sense to rely on ACPI. It would then
> > > be up to the board and/or BIOS vendor to decide if the information should be available
> > > to the OS or not.
> >
> > I think the plan is to add something to ACPI to tell us when we can
> > use these registers. Unfortunately I'm not privy to whatever the ACPI
> > committee is doing.
>
> Coming from the embedded world and not knowing much about this, I tend
> to wait until the above issue is clear, meaning when and how this driver
> is safe to be used. I hope you don't mind. Keeping your code up to date
> and sharing it is much appreciated, though! As well as Guenter's comments.
>
When I suggested that we should rely on ACPI, I meant through ACPI SMBus CMI
(i2c-scmi), not through some ACPI properties which would permit direct access.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
Boaz Harrosh <boaz-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org>,
One Thousand Gnomes
<gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
Rui Wang <ruiv.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
Alun Evans <alun-eX+YDEU5biwsV2N9l4h3zg@public.gmane.org>,
Robert Elliott <Elliott-VXdhtT5mjnY@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mauro Carvalho Chehab
<m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>,
Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips
Date: Wed, 17 Jun 2015 08:12:51 -0700 [thread overview]
Message-ID: <20150617151251.GA1043@roeck-us.net> (raw)
In-Reply-To: <20150617131841.GI13393@katana>
On Wed, Jun 17, 2015 at 03:18:42PM +0200, Wolfram Sang wrote:
>
> > > Having said that, I am still not convinced that the driver should be in the kernel
> > > to start with. Browsing through Intel's datasheets, the registers are supported
> > > in E5-2600 v1, v2, and v3. However, in v3 Intel added a note saying that the registers
> > > should not be accessed by the OS directly, but only through the bios. Given that,
> > > and if that is possible, it might make more sense to rely on ACPI. It would then
> > > be up to the board and/or BIOS vendor to decide if the information should be available
> > > to the OS or not.
> >
> > I think the plan is to add something to ACPI to tell us when we can
> > use these registers. Unfortunately I'm not privy to whatever the ACPI
> > committee is doing.
>
> Coming from the embedded world and not knowing much about this, I tend
> to wait until the above issue is clear, meaning when and how this driver
> is safe to be used. I hope you don't mind. Keeping your code up to date
> and sharing it is much appreciated, though! As well as Guenter's comments.
>
When I suggested that we should rely on ACPI, I meant through ACPI SMBus CMI
(i2c-scmi), not through some ACPI properties which would permit direct access.
Thanks,
Guenter
next prev parent reply other threads:[~2015-06-17 15:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:55 [PATCH v2 0/2] i2c_imc: New driver, at long last Andy Lutomirski
2015-03-09 20:55 ` Andy Lutomirski
2015-03-09 20:55 ` [PATCH v2 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips Andy Lutomirski
2015-03-14 4:14 ` Guenter Roeck
2015-03-17 20:14 ` Andy Lutomirski
2015-03-17 20:14 ` Andy Lutomirski
2015-06-17 13:18 ` Wolfram Sang
2015-06-17 15:12 ` Guenter Roeck [this message]
2015-06-17 15:12 ` Guenter Roeck
2015-03-09 20:55 ` [PATCH v2 2/2] i2c, i2c_imc: Add DIMM bus code Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617151251.GA1043@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Elliott@hp.com \
--cc=alun@badgerous.net \
--cc=boaz@plexistor.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=m.chehab@samsung.com \
--cc=pebolle@tiscali.nl \
--cc=ruiv.wang@gmail.com \
--cc=tony.luck@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.