From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>, Shaohua Li <shli@fb.com>,
netdev@vger.kernel.org, davem@davemloft.net, Kernel-team@fb.com,
clm@fb.com, linux-mm@kvack.org, dbavatar@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [RFC V3] net: don't wait for order-3 page allocation
Date: Thu, 18 Jun 2015 16:30:19 +0200 [thread overview]
Message-ID: <20150618143019.GE5858@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1506171602300.8203@chino.kir.corp.google.com>
On Wed 17-06-15 16:02:59, David Rientjes wrote:
> On Fri, 12 Jun 2015, Vlastimil Babka wrote:
>
> > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > > index 3cfff2a..41ec022 100644
> > > --- a/net/core/skbuff.c
> > > +++ b/net/core/skbuff.c
> > > @@ -4398,7 +4398,7 @@ struct sk_buff *alloc_skb_with_frags(unsigned long
> > > header_len,
> > >
> > > while (order) {
> > > if (npages >= 1 << order) {
> > > - page = alloc_pages(gfp_mask |
> > > + page = alloc_pages((gfp_mask & ~__GFP_WAIT) |
> > > __GFP_COMP |
> > > __GFP_NOWARN |
> > > __GFP_NORETRY,
> >
> > Note that __GFP_NORETRY is weaker than ~__GFP_WAIT and thus redundant. But it
> > won't hurt anything leaving it there. And you might consider __GFP_NO_KSWAPD
> > instead, as I said in the other thread.
> >
>
> Yeah, I agreed with __GFP_NO_KSWAPD to avoid utilizing memory reserves for
> this.
Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the
_current_ implementation of the allocator has this nasty and very subtle
side effect but that doesn't mean it should be abused outside of the mm
proper. Why shouldn't this path wake the kswapd and let it compact
memory on the background to increase the success rate for the later
high order allocations?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>, Shaohua Li <shli@fb.com>,
netdev@vger.kernel.org, davem@davemloft.net, Kernel-team@fb.com,
clm@fb.com, linux-mm@kvack.org, dbavatar@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [RFC V3] net: don't wait for order-3 page allocation
Date: Thu, 18 Jun 2015 16:30:19 +0200 [thread overview]
Message-ID: <20150618143019.GE5858@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1506171602300.8203@chino.kir.corp.google.com>
On Wed 17-06-15 16:02:59, David Rientjes wrote:
> On Fri, 12 Jun 2015, Vlastimil Babka wrote:
>
> > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > > index 3cfff2a..41ec022 100644
> > > --- a/net/core/skbuff.c
> > > +++ b/net/core/skbuff.c
> > > @@ -4398,7 +4398,7 @@ struct sk_buff *alloc_skb_with_frags(unsigned long
> > > header_len,
> > >
> > > while (order) {
> > > if (npages >= 1 << order) {
> > > - page = alloc_pages(gfp_mask |
> > > + page = alloc_pages((gfp_mask & ~__GFP_WAIT) |
> > > __GFP_COMP |
> > > __GFP_NOWARN |
> > > __GFP_NORETRY,
> >
> > Note that __GFP_NORETRY is weaker than ~__GFP_WAIT and thus redundant. But it
> > won't hurt anything leaving it there. And you might consider __GFP_NO_KSWAPD
> > instead, as I said in the other thread.
> >
>
> Yeah, I agreed with __GFP_NO_KSWAPD to avoid utilizing memory reserves for
> this.
Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the
_current_ implementation of the allocator has this nasty and very subtle
side effect but that doesn't mean it should be abused outside of the mm
proper. Why shouldn't this path wake the kswapd and let it compact
memory on the background to increase the success rate for the later
high order allocations?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-06-18 14:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 23:50 [RFC V3] net: don't wait for order-3 page allocation Shaohua Li
2015-06-11 23:50 ` Shaohua Li
2015-06-12 0:02 ` Eric Dumazet
2015-06-12 0:02 ` Eric Dumazet
2015-06-12 0:34 ` David Miller
2015-06-12 0:34 ` David Miller
2015-06-12 9:36 ` Vlastimil Babka
2015-06-12 9:36 ` Vlastimil Babka
2015-06-17 23:02 ` David Rientjes
2015-06-17 23:02 ` David Rientjes
2015-06-18 14:30 ` Michal Hocko [this message]
2015-06-18 14:30 ` Michal Hocko
2015-06-18 14:35 ` Eric Dumazet
2015-06-18 14:43 ` Michal Hocko
2015-06-18 14:43 ` Michal Hocko
2015-06-18 15:22 ` Vlastimil Babka
2015-06-18 15:47 ` Michal Hocko
2015-06-18 15:47 ` Michal Hocko
2015-06-30 23:49 ` David Rientjes
2015-06-30 23:49 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618143019.GE5858@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=dbavatar@gmail.com \
--cc=edumazet@google.com \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
--cc=shli@fb.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.