From: Peter Karlsson <peter@zapto.se>
To: Joe Perches <joe@perches.com>
Cc: greg@kroah.com, marek.belisko@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: ft1000-usb: Fixed some issues with lines over 80 characters
Date: Thu, 18 Jun 2015 18:33:30 +0200 [thread overview]
Message-ID: <20150618163330.GA27895@laptop> (raw)
In-Reply-To: <1434642666.2689.105.camel@perches.com>
On 2015-06-18 08:51, Joe Perches wrote:
> On Thu, 2015-06-18 at 15:50 +0200, Peter Karlsson wrote:
> > Fix checkpatch warnings about lines over 80 characters.
> []
> > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
> []
> > @@ -414,12 +414,20 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
> > unsigned long flags;
> > struct IOCTL_GET_VER get_ver_data;
> > struct IOCTL_GET_DSP_STAT get_stat_data;
> > - u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64,
> > - 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a,
> > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > - 0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00,
> > - 0x00, 0x01, 0x00, 0x00};
> > + u8 ConnectionMsg[] = {
> > + 0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,
>
> 7 bytes per line is unusual.
> 8 or 10 is more common.
You are right. I guess i should redo the patches. Frans Klaver also pointed
out that four commits have the same commit message, which is not good.
Peter
next prev parent reply other threads:[~2015-06-18 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 13:50 [PATCH 0/5] staging: ft1000-usb: checkpatch fixes Peter Karlsson
2015-06-18 13:50 ` [PATCH 1/5] staging: ft1000-usb: Fixed some issues with lines over 80 characters Peter Karlsson
2015-06-18 15:51 ` Joe Perches
2015-06-18 16:33 ` Peter Karlsson [this message]
2015-06-18 13:50 ` [PATCH 2/5] " Peter Karlsson
2015-06-22 17:18 ` Dan Carpenter
2015-06-18 13:50 ` [PATCH 3/5] " Peter Karlsson
2015-06-22 17:20 ` Dan Carpenter
2015-06-18 13:51 ` [PATCH 4/5] " Peter Karlsson
2015-06-18 13:51 ` [PATCH 5/5] staging: ft1000-usb: Removed CVS keyword marker Peter Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618163330.GA27895@laptop \
--to=peter@zapto.se \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.