From: Ingo Molnar <mingo@kernel.org>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Boszormenyi Zoltan <zboszor@pr.hu>, Len Brown <lenb@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
"x86 @ kernel . org" <x86@kernel.org>
Subject: Re: [Patch v1] PCI, ACPI: Fix regressions caused by resource_size_t overflow with 32bit kernel
Date: Tue, 23 Jun 2015 09:35:30 +0200 [thread overview]
Message-ID: <20150623073530.GA21872@gmail.com> (raw)
In-Reply-To: <1435032732-26160-1-git-send-email-jiang.liu@linux.intel.com>
* Jiang Liu <jiang.liu@linux.intel.com> wrote:
> The data type resource_size_t may be 32 bits or 64 bits depending on
> CONFIG_PHYS_ADDR_T_64BIT. So reject ACPI resource descriptors which
> will cause resource_size_t overflow with 32bit kernel
>
> This issue was triggered on a platform running 32bit kernel with an
> ACPI resource descriptor with address range [0x400000000-0xfffffffff].
> Please refer to https://lkml.org/lkml/2015/6/19/277 for more information.
>
> Reported-by: Boszormenyi Zoltan <zboszor@pr.hu>
> Fixes: 593669c2ac0f ("x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation")
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: stable@vger.kernel.org # 4.0
Yeah, so please use the customary changelog style we use in the kernel:
" Current code does (A), this causes problem (B) when doing (C).
In that case the user notices (D).
We can improve this doing (E), because now the user will experience (F),
which is more desirable."
Please fill in A-F accordingly.
In particular your changelog is missing 'B' and 'D': what exactly is a
'resource_size_t overflow' and what does the user notice from it?
Your changelog is also missing 'F'.
Thanks,
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Boszormenyi Zoltan <zboszor@pr.hu>, Len Brown <lenb@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
"x86 @ kernel . org" <x86@kernel.org>
Subject: Re: [Patch v1] PCI, ACPI: Fix regressions caused by resource_size_t overflow with 32bit kernel
Date: Tue, 23 Jun 2015 09:35:30 +0200 [thread overview]
Message-ID: <20150623073530.GA21872@gmail.com> (raw)
In-Reply-To: <1435032732-26160-1-git-send-email-jiang.liu@linux.intel.com>
* Jiang Liu <jiang.liu@linux.intel.com> wrote:
> The data type resource_size_t may be 32 bits or 64 bits depending on
> CONFIG_PHYS_ADDR_T_64BIT. So reject ACPI resource descriptors which
> will cause resource_size_t overflow with 32bit kernel
>
> This issue was triggered on a platform running 32bit kernel with an
> ACPI resource descriptor with address range [0x400000000-0xfffffffff].
> Please refer to https://lkml.org/lkml/2015/6/19/277 for more information.
>
> Reported-by: Boszormenyi Zoltan <zboszor@pr.hu>
> Fixes: 593669c2ac0f ("x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation")
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: stable@vger.kernel.org # 4.0
Yeah, so please use the customary changelog style we use in the kernel:
" Current code does (A), this causes problem (B) when doing (C).
In that case the user notices (D).
We can improve this doing (E), because now the user will experience (F),
which is more desirable."
Please fill in A-F accordingly.
In particular your changelog is missing 'B' and 'D': what exactly is a
'resource_size_t overflow' and what does the user notice from it?
Your changelog is also missing 'F'.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
next prev parent reply other threads:[~2015-06-23 7:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 13:24 Ethernet chip disappeared from lspci Boszormenyi Zoltan
2015-06-19 13:31 ` Boszormenyi Zoltan
2015-06-19 13:46 ` ACPI regression? Was " Boszormenyi Zoltan
2015-06-19 23:13 ` Rafael J. Wysocki
2015-06-19 23:13 ` Rafael J. Wysocki
2015-06-20 6:38 ` Boszormenyi Zoltan
2015-06-21 10:34 ` Boszormenyi Zoltan
2015-06-21 14:03 ` Bjorn Helgaas
2015-06-21 14:03 ` Bjorn Helgaas
2015-06-21 14:03 ` Bjorn Helgaas
2015-06-21 14:19 ` Boszormenyi Zoltan
2015-06-21 15:37 ` Boszormenyi Zoltan
2015-06-21 15:37 ` Boszormenyi Zoltan
2015-06-21 17:25 ` Jiang Liu
2015-06-21 17:25 ` Jiang Liu
2015-06-21 17:55 ` Jiang Liu
2015-06-21 17:55 ` Jiang Liu
2015-06-21 17:55 ` Jiang Liu
2015-06-21 18:55 ` Boszormenyi Zoltan
2015-06-21 19:59 ` Boszormenyi Zoltan
2015-06-21 19:59 ` Boszormenyi Zoltan
2015-06-23 4:12 ` [Patch v1] PCI, ACPI: Fix regressions caused by resource_size_t overflow with 32bit kernel Jiang Liu
2015-06-23 4:12 ` Jiang Liu
2015-06-23 7:35 ` Ingo Molnar [this message]
2015-06-23 7:35 ` Ingo Molnar
2015-06-21 18:28 ` ACPI regression? Was Re: Ethernet chip disappeared from lspci Boszormenyi Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623073530.GA21872@gmail.com \
--to=mingo@kernel.org \
--cc=bhelgaas@google.com \
--cc=jiang.liu@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=x86@kernel.org \
--cc=zboszor@pr.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.