From: Jan Kara <jack@suse.cz>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jan Kara <jack@suse.cz>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/10 v6] Helper to abstract vma handling in media layer
Date: Mon, 13 Jul 2015 15:36:07 +0200 [thread overview]
Message-ID: <20150713133607.GA17075@quack.suse.cz> (raw)
In-Reply-To: <55A37AA5.1020809@xs4all.nl>
On Mon 13-07-15 10:45:25, Hans Verkuil wrote:
> On 07/09/2015 02:12 PM, Hans Verkuil wrote:
> > On 07/09/2015 01:48 PM, Jan Kara wrote:
> >> Hello,
> >>
> >> Hans, did you have a chance to look at these patches? I have tested them
> >> with the vivid driver but it would be good if you could run them through
> >> your standard testing procedure as well. Andrew has updated the patches in
> >> his tree but some ack from you would be welcome...
> >
> > I've planned a 'patch day' for Monday. So hopefully you'll see a pull request
> > by then.
>
> OK, I'm confused. I thought the non-vb2 patches would go in for 4.2? That
> didn't happen, so I guess the plan is to merge the whole lot for 4.3 via
> our media tree? If that's the case, can you post a new patch series on
I guess Andrew wasn't sure what to push and what not so he just chose the
safe option to not push anything.
> top of the master branch of the media tree? I want to make sure I use the
> right patches. Also, if you do make a new patch series, then it would be
> better if patch 10/10 is folded into patch 2/10.
OK, I'll rebase patches on top of media tree.
Honza
> >> On Thu 18-06-15 16:08:30, Jan Kara wrote:
> >>> Hello,
> >>>
> >>> I'm sending the sixth version of my patch series to abstract vma handling from
> >>> the various media drivers. Since the previous version I have added a patch to
> >>> move mm helpers into a separate file and behind a config option. I also
> >>> changed patch pushing mmap_sem down in videobuf2 core to avoid lockdep warning
> >>> and NULL dereference Hans found in his testing. I've also included small
> >>> fixups Andrew was carrying.
> >>>
> >>> After this patch set drivers have to know much less details about vmas, their
> >>> types, and locking. Also quite some code is removed from them. As a bonus
> >>> drivers get automatically VM_FAULT_RETRY handling. The primary motivation for
> >>> this series is to remove knowledge about mmap_sem locking from as many places a
> >>> possible so that we can change it with reasonable effort.
> >>>
> >>> The core of the series is the new helper get_vaddr_frames() which is given a
> >>> virtual address and it fills in PFNs / struct page pointers (depending on VMA
> >>> type) into the provided array. If PFNs correspond to normal pages it also grabs
> >>> references to these pages. The difference from get_user_pages() is that this
> >>> function can also deal with pfnmap, and io mappings which is what the media
> >>> drivers need.
> >>>
> >>> I have tested the patches with vivid driver so at least vb2 code got some
> >>> exposure. Conversion of other drivers was just compile-tested (for x86 so e.g.
> >>> exynos driver which is only for Samsung platform is completely untested).
> >>>
> >>> Andrew, can you please update the patches in mm three? Thanks!
> >>>
> >>> Honza
> >>>
> >>> Changes since v5:
> >>> * Moved mm helper into a separate file and behind a config option
> >>> * Changed the first patch pushing mmap_sem down in videobuf2 core to avoid
> >>> possible deadlock
> >>>
> >>> Changes since v4:
> >>> * Minor cleanups and fixes pointed out by Mel and Vlasta
> >>> * Added Acked-by tags
> >>>
> >>> Changes since v3:
> >>> * Added include <linux/vmalloc.h> into mm/gup.c as it's needed for some archs
> >>> * Fixed error path for exynos driver
> >>>
> >>> Changes since v2:
> >>> * Renamed functions and structures as Mel suggested
> >>> * Other minor changes suggested by Mel
> >>> * Rebased on top of 4.1-rc2
> >>> * Changed functions to get pointer to array of pages / pfns to perform
> >>> conversion if necessary. This fixes possible issue in the omap I may have
> >>> introduced in v2 and generally makes the API less errorprone.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jan Kara <jack@suse.cz>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/10 v6] Helper to abstract vma handling in media layer
Date: Mon, 13 Jul 2015 15:36:07 +0200 [thread overview]
Message-ID: <20150713133607.GA17075@quack.suse.cz> (raw)
In-Reply-To: <55A37AA5.1020809@xs4all.nl>
On Mon 13-07-15 10:45:25, Hans Verkuil wrote:
> On 07/09/2015 02:12 PM, Hans Verkuil wrote:
> > On 07/09/2015 01:48 PM, Jan Kara wrote:
> >> Hello,
> >>
> >> Hans, did you have a chance to look at these patches? I have tested them
> >> with the vivid driver but it would be good if you could run them through
> >> your standard testing procedure as well. Andrew has updated the patches in
> >> his tree but some ack from you would be welcome...
> >
> > I've planned a 'patch day' for Monday. So hopefully you'll see a pull request
> > by then.
>
> OK, I'm confused. I thought the non-vb2 patches would go in for 4.2? That
> didn't happen, so I guess the plan is to merge the whole lot for 4.3 via
> our media tree? If that's the case, can you post a new patch series on
I guess Andrew wasn't sure what to push and what not so he just chose the
safe option to not push anything.
> top of the master branch of the media tree? I want to make sure I use the
> right patches. Also, if you do make a new patch series, then it would be
> better if patch 10/10 is folded into patch 2/10.
OK, I'll rebase patches on top of media tree.
Honza
> >> On Thu 18-06-15 16:08:30, Jan Kara wrote:
> >>> Hello,
> >>>
> >>> I'm sending the sixth version of my patch series to abstract vma handling from
> >>> the various media drivers. Since the previous version I have added a patch to
> >>> move mm helpers into a separate file and behind a config option. I also
> >>> changed patch pushing mmap_sem down in videobuf2 core to avoid lockdep warning
> >>> and NULL dereference Hans found in his testing. I've also included small
> >>> fixups Andrew was carrying.
> >>>
> >>> After this patch set drivers have to know much less details about vmas, their
> >>> types, and locking. Also quite some code is removed from them. As a bonus
> >>> drivers get automatically VM_FAULT_RETRY handling. The primary motivation for
> >>> this series is to remove knowledge about mmap_sem locking from as many places a
> >>> possible so that we can change it with reasonable effort.
> >>>
> >>> The core of the series is the new helper get_vaddr_frames() which is given a
> >>> virtual address and it fills in PFNs / struct page pointers (depending on VMA
> >>> type) into the provided array. If PFNs correspond to normal pages it also grabs
> >>> references to these pages. The difference from get_user_pages() is that this
> >>> function can also deal with pfnmap, and io mappings which is what the media
> >>> drivers need.
> >>>
> >>> I have tested the patches with vivid driver so at least vb2 code got some
> >>> exposure. Conversion of other drivers was just compile-tested (for x86 so e.g.
> >>> exynos driver which is only for Samsung platform is completely untested).
> >>>
> >>> Andrew, can you please update the patches in mm three? Thanks!
> >>>
> >>> Honza
> >>>
> >>> Changes since v5:
> >>> * Moved mm helper into a separate file and behind a config option
> >>> * Changed the first patch pushing mmap_sem down in videobuf2 core to avoid
> >>> possible deadlock
> >>>
> >>> Changes since v4:
> >>> * Minor cleanups and fixes pointed out by Mel and Vlasta
> >>> * Added Acked-by tags
> >>>
> >>> Changes since v3:
> >>> * Added include <linux/vmalloc.h> into mm/gup.c as it's needed for some archs
> >>> * Fixed error path for exynos driver
> >>>
> >>> Changes since v2:
> >>> * Renamed functions and structures as Mel suggested
> >>> * Other minor changes suggested by Mel
> >>> * Rebased on top of 4.1-rc2
> >>> * Changed functions to get pointer to array of pages / pfns to perform
> >>> conversion if necessary. This fixes possible issue in the omap I may have
> >>> introduced in v2 and generally makes the API less errorprone.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-13 13:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 14:08 [PATCH 0/10 v6] Helper to abstract vma handling in media layer Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 1/10] [media] vb2: Push mmap_sem down to memops Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 2/10] mm: Provide new get_vaddr_frames() helper Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 3/10] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 4/10] vb2: Provide helpers for mapping virtual addresses Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 5/10] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 6/10] media: vb2: Convert vb2_vmalloc_get_userptr() " Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 7/10] media: vb2: Convert vb2_dc_get_userptr() " Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 8/10] media: vb2: Remove unused functions Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 9/10] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames() Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-06-18 14:08 ` [PATCH 10/10] mm: Move get_vaddr_frames() behind a config option Jan Kara
2015-06-18 14:08 ` Jan Kara
2015-07-09 11:48 ` [PATCH 0/10 v6] Helper to abstract vma handling in media layer Jan Kara
2015-07-09 11:48 ` Jan Kara
2015-07-09 12:12 ` Hans Verkuil
2015-07-09 12:12 ` Hans Verkuil
2015-07-13 8:45 ` Hans Verkuil
2015-07-13 8:45 ` Hans Verkuil
2015-07-13 13:36 ` Jan Kara [this message]
2015-07-13 13:36 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713133607.GA17075@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.