All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arun Bharadwaj <arun@gumstix.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Adam YH Lee" <adam.yh.lee@gmail.com>,
	"Ash Charles" <ashcharles@gmail.com>
Subject: Re: [PATCH 1/3] ARM: dts: Correct audio input route & set mic bias
Date: Mon, 13 Jul 2015 23:57:45 -0700	[thread overview]
Message-ID: <20150714065745.GE17550@atomide.com> (raw)
In-Reply-To: <1433441299-18887-2-git-send-email-arun@gumstix.com>

* Arun Bharadwaj <arun@gumstix.com> [150604 11:10]:
> From: Adam YH Lee <adam.yh.lee@gmail.com>
> 
> Audio-in was incorrectly routed to Line In. It should be Mic3L as per
> schematic.
> 
> Using mic-bias voltage at 2.0v (<0x1>) does not work for some reason. There
> is no voltage seen on micbias (R127). Mic-bias voltage of 2.5v (<0x2>) works.
> I see voltage of 2.475v across GND and micbias.
> 
> With these changes, I can record audio with a pair of proliferate TRRS earbuds.
> 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>

Can you please repost this with after checking From
and Signed-off-by?

Regards,

Tony

> ---
>  arch/arm/boot/dts/am335x-pepper.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
> index 0d35ab6..473d8ee 100644
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -74,6 +74,7 @@
>  	audio_codec: tlv320aic3106@1b {
>  		compatible = "ti,tlv320aic3106";
>  		reg = <0x1b>;
> +		ai3x-micbias-vg = <0x2>;
>  	};
>  
>  	accel: lis331dlh@1d {
> @@ -153,7 +154,7 @@
>  	ti,audio-routing =
>  		"Headphone Jack",	"HPLOUT",
>  		"Headphone Jack",	"HPROUT",
> -		"LINE1L",		"Line In";
> +		"MIC3L",		"Mic3L Switch";
>  };
>  
>  &mcasp0 {
> -- 
> 2.1.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Arun Bharadwaj <arun-EiDWdcs9+yZBDgjK7y7TUQ@public.gmane.org>
Cc: "Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Adam YH Lee"
	<adam.yh.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Ash Charles"
	<ashcharles-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: dts: Correct audio input route & set mic bias
Date: Mon, 13 Jul 2015 23:57:45 -0700	[thread overview]
Message-ID: <20150714065745.GE17550@atomide.com> (raw)
In-Reply-To: <1433441299-18887-2-git-send-email-arun-EiDWdcs9+yZBDgjK7y7TUQ@public.gmane.org>

* Arun Bharadwaj <arun-EiDWdcs9+yZBDgjK7y7TUQ@public.gmane.org> [150604 11:10]:
> From: Adam YH Lee <adam.yh.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Audio-in was incorrectly routed to Line In. It should be Mic3L as per
> schematic.
> 
> Using mic-bias voltage at 2.0v (<0x1>) does not work for some reason. There
> is no voltage seen on micbias (R127). Mic-bias voltage of 2.5v (<0x2>) works.
> I see voltage of 2.475v across GND and micbias.
> 
> With these changes, I can record audio with a pair of proliferate TRRS earbuds.
> 
> Signed-off-by: Ash Charles <ashcharles-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Can you please repost this with after checking From
and Signed-off-by?

Regards,

Tony

> ---
>  arch/arm/boot/dts/am335x-pepper.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
> index 0d35ab6..473d8ee 100644
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -74,6 +74,7 @@
>  	audio_codec: tlv320aic3106@1b {
>  		compatible = "ti,tlv320aic3106";
>  		reg = <0x1b>;
> +		ai3x-micbias-vg = <0x2>;
>  	};
>  
>  	accel: lis331dlh@1d {
> @@ -153,7 +154,7 @@
>  	ti,audio-routing =
>  		"Headphone Jack",	"HPLOUT",
>  		"Headphone Jack",	"HPROUT",
> -		"LINE1L",		"Line In";
> +		"MIC3L",		"Mic3L Switch";
>  };
>  
>  &mcasp0 {
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: Correct audio input route & set mic bias
Date: Mon, 13 Jul 2015 23:57:45 -0700	[thread overview]
Message-ID: <20150714065745.GE17550@atomide.com> (raw)
In-Reply-To: <1433441299-18887-2-git-send-email-arun@gumstix.com>

* Arun Bharadwaj <arun@gumstix.com> [150604 11:10]:
> From: Adam YH Lee <adam.yh.lee@gmail.com>
> 
> Audio-in was incorrectly routed to Line In. It should be Mic3L as per
> schematic.
> 
> Using mic-bias voltage at 2.0v (<0x1>) does not work for some reason. There
> is no voltage seen on micbias (R127). Mic-bias voltage of 2.5v (<0x2>) works.
> I see voltage of 2.475v across GND and micbias.
> 
> With these changes, I can record audio with a pair of proliferate TRRS earbuds.
> 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>

Can you please repost this with after checking From
and Signed-off-by?

Regards,

Tony

> ---
>  arch/arm/boot/dts/am335x-pepper.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
> index 0d35ab6..473d8ee 100644
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -74,6 +74,7 @@
>  	audio_codec: tlv320aic3106 at 1b {
>  		compatible = "ti,tlv320aic3106";
>  		reg = <0x1b>;
> +		ai3x-micbias-vg = <0x2>;
>  	};
>  
>  	accel: lis331dlh at 1d {
> @@ -153,7 +154,7 @@
>  	ti,audio-routing =
>  		"Headphone Jack",	"HPLOUT",
>  		"Headphone Jack",	"HPROUT",
> -		"LINE1L",		"Line In";
> +		"MIC3L",		"Mic3L Switch";
>  };
>  
>  &mcasp0 {
> -- 
> 2.1.4
> 

  reply	other threads:[~2015-07-14  6:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 18:08 [PATCH 0/3] ARM: dts: Changes for Gumstix Pepper dts Arun Bharadwaj
2015-06-04 18:08 ` Arun Bharadwaj
2015-06-04 18:08 ` Arun Bharadwaj
2015-06-04 18:08 ` [PATCH 1/3] ARM: dts: Correct audio input route & set mic bias Arun Bharadwaj
2015-06-04 18:08   ` Arun Bharadwaj
2015-07-14  6:57   ` Tony Lindgren [this message]
2015-07-14  6:57     ` Tony Lindgren
2015-07-14  6:57     ` Tony Lindgren
2015-06-04 18:08 ` [PATCH 2/3] ARM: dts: configure regulators for Gumstix Pepper Arun Bharadwaj
2015-06-04 18:08   ` Arun Bharadwaj
2015-06-29  6:47   ` Tony Lindgren
2015-06-29  6:47     ` Tony Lindgren
2015-06-29  6:47     ` Tony Lindgren
2015-07-02 18:34     ` Ash Charles
2015-07-02 18:34       ` Ash Charles
2015-07-02 18:34       ` Ash Charles
2015-07-03  5:53       ` Tony Lindgren
2015-07-03  5:53         ` Tony Lindgren
2015-07-03  5:53         ` Tony Lindgren
2015-06-04 18:08 ` [PATCH 3/3] ARM: dts: Fix frequency scaling on " Arun Bharadwaj
2015-06-04 18:08   ` Arun Bharadwaj
2015-06-04 18:08   ` Arun Bharadwaj
2015-06-09 15:45   ` Ash Charles
2015-06-09 15:45     ` Ash Charles
2015-06-09 15:45     ` Ash Charles
2015-07-14  6:54     ` Tony Lindgren
2015-07-14  6:54       ` Tony Lindgren
2015-07-14  6:54       ` Tony Lindgren
2015-07-14 12:25 ` [PATCH 0/3] ARM: dts: Changes for Gumstix Pepper dts Kevin Hilman
2015-07-14 12:25   ` Kevin Hilman
2015-07-14 12:25   ` Kevin Hilman
2015-07-14 18:29   ` Adam Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150714065745.GE17550@atomide.com \
    --to=tony@atomide.com \
    --cc=adam.yh.lee@gmail.com \
    --cc=arun@gumstix.com \
    --cc=ashcharles@gmail.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.