From: Cyril Hrubis <chrubis@suse.cz>
To: Yuan Sun <sunyuan3@huawei.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Add check_simple_capset in filecapstest.sh.
Date: Tue, 14 Jul 2015 12:11:27 +0200 [thread overview]
Message-ID: <20150714101126.GE3729@rei.suse.de> (raw)
In-Reply-To: <55A4DD8E.90501@huawei.com>
Hi!
> >> +echo "testing for simple capset"
> >> +check_simple_capset
> >> +tmp=$?
> >> +if [ $tmp -ne 0 ]; then
> >> + exit_code=$tmp
> >> +fi
> > Rather than adding to the script, can we split it so that each of the
> > binaries can be run separately and that we have one entry per test in
> > the runtest file?
> You mean that I need to add check_simple_capset to ltp/runtest/filecaps.
> Is it right?
Yes along with the rest of tests that are executed from the script and
move any required setup from the script to the testcases as well. Looks
to me like tst_tmpdir() would be needed but I haven't checked throughly.
Idealy we would have one record in runtest files per test.
> > It would also be good idea to prefix the test binaris with capset_ or
> > something similar (in a separate patch please).
> >
> The following file names need updating. Is it right?
>
> check_simple_capset.c -> capset_check_simple.c
> inh_capped.c -> capset_inh.c
> print_caps.c -> capset_print.c
> verify_caps_exec.c -> capset_verify_exec.c
Yes please.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2015-07-14 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1435895009-18134-1-git-send-email-sunyuan3@huawei.com>
2015-07-14 9:40 ` [LTP] [PATCH] Add check_simple_capset in filecapstest.sh Cyril Hrubis
[not found] ` <55A4DD8E.90501@huawei.com>
2015-07-14 10:11 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714101126.GE3729@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=sunyuan3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.