* Re: [LTP] [PATCH] Add check_simple_capset in filecapstest.sh.
[not found] <1435895009-18134-1-git-send-email-sunyuan3@huawei.com>
@ 2015-07-14 9:40 ` Cyril Hrubis
[not found] ` <55A4DD8E.90501@huawei.com>
0 siblings, 1 reply; 2+ messages in thread
From: Cyril Hrubis @ 2015-07-14 9:40 UTC (permalink / raw)
To: Yuan Sun; +Cc: ltp-list
Hi!
> +echo "testing for simple capset"
> +check_simple_capset
> +tmp=$?
> +if [ $tmp -ne 0 ]; then
> + exit_code=$tmp
> +fi
Rather than adding to the script, can we split it so that each of the
binaries can be run separately and that we have one entry per test in
the runtest file?
It would also be good idea to prefix the test binaris with capset_ or
something similar (in a separate patch please).
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [LTP] [PATCH] Add check_simple_capset in filecapstest.sh.
[not found] ` <55A4DD8E.90501@huawei.com>
@ 2015-07-14 10:11 ` Cyril Hrubis
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2015-07-14 10:11 UTC (permalink / raw)
To: Yuan Sun; +Cc: ltp-list
Hi!
> >> +echo "testing for simple capset"
> >> +check_simple_capset
> >> +tmp=$?
> >> +if [ $tmp -ne 0 ]; then
> >> + exit_code=$tmp
> >> +fi
> > Rather than adding to the script, can we split it so that each of the
> > binaries can be run separately and that we have one entry per test in
> > the runtest file?
> You mean that I need to add check_simple_capset to ltp/runtest/filecaps.
> Is it right?
Yes along with the rest of tests that are executed from the script and
move any required setup from the script to the testcases as well. Looks
to me like tst_tmpdir() would be needed but I haven't checked throughly.
Idealy we would have one record in runtest files per test.
> > It would also be good idea to prefix the test binaris with capset_ or
> > something similar (in a separate patch please).
> >
> The following file names need updating. Is it right?
>
> check_simple_capset.c -> capset_check_simple.c
> inh_capped.c -> capset_inh.c
> print_caps.c -> capset_print.c
> verify_caps_exec.c -> capset_verify_exec.c
Yes please.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-14 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1435895009-18134-1-git-send-email-sunyuan3@huawei.com>
2015-07-14 9:40 ` [LTP] [PATCH] Add check_simple_capset in filecapstest.sh Cyril Hrubis
[not found] ` <55A4DD8E.90501@huawei.com>
2015-07-14 10:11 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.