From: Peter Chen <peter.chen@freescale.com> To: Andrew Bresticker <abrestic@chromium.org> Cc: Roger Quadros <rogerq@ti.com>, Alan Stern <stern@rowland.harvard.edu>, Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com>, <jun.li@freescale.com>, "Mathias Nyman" <mathias.nyman@linux.intel.com>, <tony@atomide.com>, <Joao.Pinto@synopsys.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org> Subject: Re: [PATCH v3 00/11] USB: OTG/DRD Core functionality Date: Wed, 15 Jul 2015 10:13:40 +0800 [thread overview] Message-ID: <20150715021339.GB30154@shlinux2> (raw) In-Reply-To: <CAL1qeaHdFv2VQwJVkW-Dv5KxKiJOpfusYuuc50BOkAdp-yvzLw@mail.gmail.com> On Tue, Jul 14, 2015 at 11:18:30AM -0700, Andrew Bresticker wrote: > Hi Peter, > > On Mon, Jul 13, 2015 at 5:59 PM, Peter Chen <peter.chen@freescale.com> wrote: > > On Mon, Jul 13, 2015 at 12:14:43PM -0700, Andrew Bresticker wrote: > >> Hi Roger, > >> > >> On Wed, Jul 8, 2015 at 3:19 AM, Roger Quadros <rogerq@ti.com> wrote: > >> > Usage model: > >> > ----------- > >> > > >> > - The OTG controller device is assumed to be the parent of > >> > the host and gadget controller. It must call usb_otg_register() > >> > before populating the host and gadget devices so that the OTG > >> > core is aware that it is an OTG device before the host & gadget > >> > register. The OTG controller must provide struct otg_fsm_ops * > >> > which will be called by the OTG core depending on OTG bus state. > >> > >> I'm wondering if the requirement that the OTG controller be the parent > >> of the USB host/device-controllers makes sense. For some context, I'm > >> working on adding dual-role support for Tegra210, specifically on a > >> system with USB Type-C. On Tegra, the USB host-controller and USB > >> device-controller are two separate IP blocks (XUSB host and XUSB > >> device) with another, separate, IP block (XUSB padctl) for the USB PHY > >> and OTG support. In the non-Type-C case, your OTG framework could > >> work well, though it's debatable as to whether or not the XUSB padctl > >> device should be a parent to the XUSB host/device-controller devices > >> (currently it isn't - it's just a PHY provider). But in the Type-C > >> case, it's an off-chip embedded controller that determines the > >> dual-role status of the Type-C port, so the above requirement doesn't > >> make sense at all. > > > > Hi Andrew, > > > > I think your problem is how to add your core driver to manage device and > > host functionality together, and once you find how (through padctl/type-c > > controller) to do it based on current code, it will be clear how to use roger > > proposal framework at that time. > > > > Most of current core drivers, we use extcon driver (through gpio) or USB > > vbus/id pin (through internal registers) to manager roles. > > Right, currently I'm modeling the Type-C controller as an extcon > device and handle the role-changes in the core drivers, but that > doesn't really make sense for the non-Type-C case where we use the > XUSB padctl controller and need a full OTG state-machine. The full OTG FSM is only applied if your board needs it, you can disable it through dts. Jun [1] and Roger's patchset are for it. > Roger's new > OTG/DRD framework would fit my situation perfectly since it makes the > host/device-controller drivers independent from all the > OTG/role-changing logic. The only issue is the requirement that the > OTG/DRD controller be the parent device of the host/device > controllers. > The core device is the parent for host/device device, the OTG core just use the pointer of it, Roger does an example using dwc3 [2]. [1] http://www.spinics.net/lists/linux-usb/msg127110.html [2] http://www.spinics.net/lists/linux-usb/msg126999.html -- Best Regards, Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@freescale.com> To: Andrew Bresticker <abrestic@chromium.org> Cc: Roger Quadros <rogerq@ti.com>, Alan Stern <stern@rowland.harvard.edu>, Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com>, jun.li@freescale.com, Mathias Nyman <mathias.nyman@linux.intel.com>, tony@atomide.com, Joao.Pinto@synopsys.com, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-omap@vger.kernel.org, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org> Subject: Re: [PATCH v3 00/11] USB: OTG/DRD Core functionality Date: Wed, 15 Jul 2015 10:13:40 +0800 [thread overview] Message-ID: <20150715021339.GB30154@shlinux2> (raw) In-Reply-To: <CAL1qeaHdFv2VQwJVkW-Dv5KxKiJOpfusYuuc50BOkAdp-yvzLw@mail.gmail.com> On Tue, Jul 14, 2015 at 11:18:30AM -0700, Andrew Bresticker wrote: > Hi Peter, > > On Mon, Jul 13, 2015 at 5:59 PM, Peter Chen <peter.chen@freescale.com> wrote: > > On Mon, Jul 13, 2015 at 12:14:43PM -0700, Andrew Bresticker wrote: > >> Hi Roger, > >> > >> On Wed, Jul 8, 2015 at 3:19 AM, Roger Quadros <rogerq@ti.com> wrote: > >> > Usage model: > >> > ----------- > >> > > >> > - The OTG controller device is assumed to be the parent of > >> > the host and gadget controller. It must call usb_otg_register() > >> > before populating the host and gadget devices so that the OTG > >> > core is aware that it is an OTG device before the host & gadget > >> > register. The OTG controller must provide struct otg_fsm_ops * > >> > which will be called by the OTG core depending on OTG bus state. > >> > >> I'm wondering if the requirement that the OTG controller be the parent > >> of the USB host/device-controllers makes sense. For some context, I'm > >> working on adding dual-role support for Tegra210, specifically on a > >> system with USB Type-C. On Tegra, the USB host-controller and USB > >> device-controller are two separate IP blocks (XUSB host and XUSB > >> device) with another, separate, IP block (XUSB padctl) for the USB PHY > >> and OTG support. In the non-Type-C case, your OTG framework could > >> work well, though it's debatable as to whether or not the XUSB padctl > >> device should be a parent to the XUSB host/device-controller devices > >> (currently it isn't - it's just a PHY provider). But in the Type-C > >> case, it's an off-chip embedded controller that determines the > >> dual-role status of the Type-C port, so the above requirement doesn't > >> make sense at all. > > > > Hi Andrew, > > > > I think your problem is how to add your core driver to manage device and > > host functionality together, and once you find how (through padctl/type-c > > controller) to do it based on current code, it will be clear how to use roger > > proposal framework at that time. > > > > Most of current core drivers, we use extcon driver (through gpio) or USB > > vbus/id pin (through internal registers) to manager roles. > > Right, currently I'm modeling the Type-C controller as an extcon > device and handle the role-changes in the core drivers, but that > doesn't really make sense for the non-Type-C case where we use the > XUSB padctl controller and need a full OTG state-machine. The full OTG FSM is only applied if your board needs it, you can disable it through dts. Jun [1] and Roger's patchset are for it. > Roger's new > OTG/DRD framework would fit my situation perfectly since it makes the > host/device-controller drivers independent from all the > OTG/role-changing logic. The only issue is the requirement that the > OTG/DRD controller be the parent device of the host/device > controllers. > The core device is the parent for host/device device, the OTG core just use the pointer of it, Roger does an example using dwc3 [2]. [1] http://www.spinics.net/lists/linux-usb/msg127110.html [2] http://www.spinics.net/lists/linux-usb/msg126999.html -- Best Regards, Peter Chen
next prev parent reply other threads:[~2015-07-15 3:22 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-08 10:19 [PATCH v3 00/11] USB: OTG/DRD Core functionality Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 01/11] usb: otg-fsm: Add documentation for struct otg_fsm Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-13 1:21 ` Peter Chen 2015-07-13 1:21 ` Peter Chen 2015-07-13 10:06 ` Roger Quadros 2015-07-13 10:06 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 02/11] usb: otg-fsm: support multiple instances Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-10 8:06 ` Li Jun 2015-07-10 8:06 ` Li Jun 2015-07-13 1:39 ` Peter Chen 2015-07-13 1:39 ` Peter Chen 2015-07-17 11:17 ` Roger Quadros 2015-07-17 11:17 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 03/11] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-13 1:52 ` Peter Chen 2015-07-13 1:52 ` Peter Chen 2015-07-08 10:19 ` [PATCH v3 04/11] otg-fsm: move usb_bus_start_enum into otg-fsm->ops Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-13 1:58 ` Peter Chen 2015-07-13 1:58 ` Peter Chen 2015-07-13 10:13 ` Roger Quadros 2015-07-13 10:13 ` Roger Quadros 2015-07-14 0:34 ` Peter Chen 2015-07-14 0:34 ` Peter Chen 2015-07-15 13:30 ` Roger Quadros 2015-07-15 13:30 ` Roger Quadros 2015-07-16 0:54 ` Peter Chen 2015-07-16 0:54 ` Peter Chen 2015-07-16 10:40 ` Roger Quadros 2015-07-16 10:40 ` Roger Quadros 2015-07-17 0:28 ` Peter Chen 2015-07-17 0:28 ` Peter Chen 2015-07-08 10:19 ` [PATCH v3 05/11] usb: hcd.h: Add OTG to HCD interface Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-13 2:00 ` Peter Chen 2015-07-13 2:00 ` Peter Chen 2015-07-17 0:30 ` Peter Chen 2015-07-17 0:30 ` Peter Chen 2015-07-08 10:19 ` [PATCH v3 06/11] usb: gadget.h: Add OTG to gadget interface Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-17 0:31 ` Peter Chen 2015-07-17 0:31 ` Peter Chen 2015-07-08 10:19 ` [PATCH v3 07/11] usb: otg: add OTG core Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-13 2:14 ` Peter Chen 2015-07-13 2:14 ` Peter Chen 2015-07-13 10:20 ` Roger Quadros 2015-07-13 10:20 ` Roger Quadros 2015-08-14 9:42 ` Roger Quadros 2015-08-14 9:42 ` Roger Quadros 2015-08-14 8:43 ` Peter Chen 2015-08-14 8:43 ` Peter Chen 2015-07-17 7:48 ` Li Jun 2015-07-17 7:48 ` Li Jun 2015-07-17 12:06 ` Roger Quadros 2015-07-17 12:06 ` Roger Quadros 2015-07-20 1:45 ` Peter Chen 2015-07-20 1:45 ` Peter Chen 2015-07-21 10:52 ` Li Jun 2015-07-21 10:52 ` Li Jun 2015-07-27 10:03 ` Roger Quadros 2015-07-27 10:03 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 08/11] usb: hcd: Adapt to " Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 09/11] usb: gadget: udc: adapt " Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 10/11] usb: otg: Add dual-role device (DRD) support Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-17 8:14 ` Li Jun 2015-07-17 8:14 ` Li Jun 2015-07-17 10:41 ` Roger Quadros 2015-07-17 10:41 ` Roger Quadros 2015-07-17 9:02 ` Li Jun 2015-07-17 9:02 ` Li Jun 2015-07-17 10:47 ` Roger Quadros 2015-07-17 10:47 ` Roger Quadros 2015-07-20 1:23 ` Peter Chen 2015-07-20 1:23 ` Peter Chen 2015-07-27 9:31 ` Roger Quadros 2015-07-27 9:31 ` Roger Quadros 2015-07-08 10:19 ` [PATCH v3 11/11] usb: otg: hub: Notify OTG fsm when A device sets b_hnp_enable Roger Quadros 2015-07-08 10:19 ` Roger Quadros 2015-07-08 10:23 ` [PATCH v3 12/12] usb: chipidea: move from CONFIG_USB_OTG_FSM to CONFIG_USB_OTG Roger Quadros 2015-07-08 10:23 ` Roger Quadros 2015-07-10 7:58 ` [PATCH v3 00/11] USB: OTG/DRD Core functionality Li Jun 2015-07-10 7:58 ` Li Jun 2015-07-13 10:24 ` Roger Quadros 2015-07-13 10:24 ` Roger Quadros 2015-07-13 13:04 ` Li Jun 2015-07-13 13:04 ` Li Jun 2015-07-15 13:07 ` Roger Quadros 2015-07-15 13:07 ` Roger Quadros 2015-07-13 19:14 ` Andrew Bresticker 2015-07-13 19:14 ` Andrew Bresticker 2015-07-14 0:59 ` Peter Chen 2015-07-14 0:59 ` Peter Chen 2015-07-14 18:18 ` Andrew Bresticker 2015-07-15 2:13 ` Peter Chen [this message] 2015-07-15 2:13 ` Peter Chen 2015-07-15 13:26 ` Roger Quadros 2015-07-15 13:26 ` Roger Quadros 2015-07-16 18:29 ` Andrew Bresticker 2015-07-16 18:29 ` Andrew Bresticker 2015-07-17 10:34 ` Roger Quadros 2015-07-17 10:34 ` Roger Quadros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150715021339.GB30154@shlinux2 \ --to=peter.chen@freescale.com \ --cc=Joao.Pinto@synopsys.com \ --cc=abrestic@chromium.org \ --cc=balbi@ti.com \ --cc=dan.j.williams@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=jun.li@freescale.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@linux.intel.com \ --cc=rogerq@ti.com \ --cc=stern@rowland.harvard.edu \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.