From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain Date: Wed, 15 Jul 2015 10:24:37 +0100 [thread overview] Message-ID: <20150715092437.GC9627@leverpostej> (raw) In-Reply-To: <1436820101-2172-1-git-send-email-balbi@ti.com> On Mon, Jul 13, 2015 at 09:41:41PM +0100, Felipe Balbi wrote: > According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter), > the realtime counter sits in the Wakeup Always-On Power domain. > Furthermore, the counter will automatically switch the 32K clock source > when MPU goes into standby and automatically switch back to SYS_CLK or > ABE_LP when MPU goes out of standby. While the counter is in an always-on domain (the architecture mandates this) I don't think that applies to the timers (i.e. the comparators within a CPU), which are almost certainly not in an always-on domain. I suspect that this is incorrect, and it will be very painful to debug if it is... Thanks, Mark. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 8f1e25bcecbd..c1e6fd82485f 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -50,6 +50,7 @@ > <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, > <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; > interrupt-parent = <&gic>; > + always-on; > }; > > gic: interrupt-controller at 48211000 { > -- > 2.4.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: Felipe Balbi <balbi@ti.com> Cc: Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>, Linux OMAP Mailing List <linux-omap@vger.kernel.org>, Linux ARM Kernel Mailing List <linux-arm-kernel@lists.infradead.org>, marc.zyngier@arm.com Subject: Re: [PATCH] arm: dts: dra7: arch timer sits in always-on power domain Date: Wed, 15 Jul 2015 10:24:37 +0100 [thread overview] Message-ID: <20150715092437.GC9627@leverpostej> (raw) In-Reply-To: <1436820101-2172-1-git-send-email-balbi@ti.com> On Mon, Jul 13, 2015 at 09:41:41PM +0100, Felipe Balbi wrote: > According to DRA7x TRM section 4.3.5 Realtime Counter (Master Counter), > the realtime counter sits in the Wakeup Always-On Power domain. > Furthermore, the counter will automatically switch the 32K clock source > when MPU goes into standby and automatically switch back to SYS_CLK or > ABE_LP when MPU goes out of standby. While the counter is in an always-on domain (the architecture mandates this) I don't think that applies to the timers (i.e. the comparators within a CPU), which are almost certainly not in an always-on domain. I suspect that this is incorrect, and it will be very painful to debug if it is... Thanks, Mark. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 8f1e25bcecbd..c1e6fd82485f 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -50,6 +50,7 @@ > <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>, > <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>; > interrupt-parent = <&gic>; > + always-on; > }; > > gic: interrupt-controller@48211000 { > -- > 2.4.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
next prev parent reply other threads:[~2015-07-15 9:24 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-13 20:41 [PATCH] arm: dts: dra7: arch timer sits in always-on power domain Felipe Balbi 2015-07-13 20:41 ` Felipe Balbi 2015-07-13 20:53 ` Nishanth Menon 2015-07-13 20:53 ` Nishanth Menon 2015-07-14 4:49 ` Tony Lindgren 2015-07-14 4:49 ` Tony Lindgren 2015-07-14 7:05 ` Tony Lindgren 2015-07-14 7:05 ` Tony Lindgren 2015-07-15 9:24 ` Mark Rutland [this message] 2015-07-15 9:24 ` Mark Rutland 2015-07-15 10:00 ` Tony Lindgren 2015-07-15 10:00 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150715092437.GC9627@leverpostej \ --to=mark.rutland@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.