From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: add critical clock for rk3368
Date: Mon, 14 Sep 2015 16:19:42 +0100 [thread overview]
Message-ID: <20150914151942.GJ7002@leverpostej> (raw)
In-Reply-To: <6675833.8DAAvDYooL@diego>
On Mon, Sep 14, 2015 at 04:06:05PM +0100, Heiko St?bner wrote:
> Am Montag, 14. September 2015, 15:19:21 schrieb Mark Rutland:
> > On Sun, Sep 13, 2015 at 12:20:36PM +0100, Heiko St?bner wrote:
> > > Again a result of the gpio-clock-liberation the rk3368 needs the
> > > pclk_pd_pmu marked as critical, to boot successfully.
> > >
> > > Reported-by: Mark Rutland <mark.rutland@arm.com>
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >
> > FWIW: Tested-by: Mark Rutland <mark.rutland@arm.com>
> >
> > I'm surprised that we don't describe these as critical in the DT, given
> > that this isn't really an internal property of the clock controller, but
> > rather what happens to be attached to it. That ship appears to have
> > sailed, however.
>
> I wouldn't necessarily think so ... what is called critical only means "don't
> turn off when walking the clock-tree upwards".
>
> The pclk_pd_pmu for example simply supplies some more clocks we don't handle
> at all currently (pclk_pmu_noc, ...). That we currently choose to ignore those
> [because we don't have any code nor dt-bindings to handle the components
> supplied] sounds very much like an implementation-specific detail, not
> something about the hardware.
Sure, but the specific case that lead to this report was the fact that
this clock (directly?) feeds the pinctrl programming interface, and that
fact is neither described in the DT nor handled by the driver. Surely
that should be described and handled?
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: "mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: rockchip: add critical clock for rk3368
Date: Mon, 14 Sep 2015 16:19:42 +0100 [thread overview]
Message-ID: <20150914151942.GJ7002@leverpostej> (raw)
In-Reply-To: <6675833.8DAAvDYooL@diego>
On Mon, Sep 14, 2015 at 04:06:05PM +0100, Heiko Stübner wrote:
> Am Montag, 14. September 2015, 15:19:21 schrieb Mark Rutland:
> > On Sun, Sep 13, 2015 at 12:20:36PM +0100, Heiko Stübner wrote:
> > > Again a result of the gpio-clock-liberation the rk3368 needs the
> > > pclk_pd_pmu marked as critical, to boot successfully.
> > >
> > > Reported-by: Mark Rutland <mark.rutland@arm.com>
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >
> > FWIW: Tested-by: Mark Rutland <mark.rutland@arm.com>
> >
> > I'm surprised that we don't describe these as critical in the DT, given
> > that this isn't really an internal property of the clock controller, but
> > rather what happens to be attached to it. That ship appears to have
> > sailed, however.
>
> I wouldn't necessarily think so ... what is called critical only means "don't
> turn off when walking the clock-tree upwards".
>
> The pclk_pd_pmu for example simply supplies some more clocks we don't handle
> at all currently (pclk_pmu_noc, ...). That we currently choose to ignore those
> [because we don't have any code nor dt-bindings to handle the components
> supplied] sounds very much like an implementation-specific detail, not
> something about the hardware.
Sure, but the specific case that lead to this report was the fact that
this clock (directly?) feeds the pinctrl programming interface, and that
fact is neither described in the DT nor handled by the driver. Surely
that should be described and handled?
Thanks,
Mark.
next prev parent reply other threads:[~2015-09-14 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 11:20 [PATCH] clk: rockchip: add critical clock for rk3368 Heiko Stübner
2015-09-13 11:20 ` Heiko Stübner
2015-09-13 11:20 ` Heiko Stübner
2015-09-14 14:19 ` Mark Rutland
2015-09-14 14:19 ` Mark Rutland
2015-09-14 14:19 ` Mark Rutland
2015-09-14 15:06 ` Heiko Stübner
2015-09-14 15:06 ` Heiko Stübner
2015-09-14 15:06 ` Heiko Stübner
2015-09-14 15:19 ` Mark Rutland [this message]
2015-09-14 15:19 ` Mark Rutland
2015-09-14 15:24 ` Heiko Stübner
2015-09-14 15:24 ` Heiko Stübner
2015-09-14 15:24 ` Heiko Stübner
2015-09-14 19:49 ` Stephen Boyd
2015-09-14 19:49 ` Stephen Boyd
2015-09-14 19:49 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914151942.GJ7002@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.