From: Mark Brown <broonie@kernel.org> To: Pavel Machek <pavel@ucw.cz> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Date: Tue, 13 Oct 2015 12:53:55 +0100 [thread overview] Message-ID: <20151013115355.GC14956@sirena.org.uk> (raw) In-Reply-To: <20151012201137.GA7317@amd> [-- Attachment #1: Type: text/plain, Size: 1694 bytes --] On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > On Mon 2015-10-12 16:47:15, Mark Brown wrote: > > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > static const struct regulator_desc arizona_ldo1_hc = { > > > - .name = "LDO1", > > No, you definitely shouldn't be doing this - the regulator names should > > reflect the names the device has in the datasheet to aid people in going > > from software to the hardware and back again. They shouldn't be > > dynamically generated at runtime. If you need to namespace by > device > They already are, see wm831x-ldo.c . No, that's a different case where we actually have a repeatable IP we can enumerate multiple instances of on a single piece of silicon which has multiple variants available. This is a single device with a single regulator on it. > > provide an interface which explicitly namespaces by device rather than > > hacking it into another interface, the usual thing is to use the struct > > device as the context. > I'll need some more help here. I need to use it from ALSA, so I don't > think I can influence that interface easily. Sorry? If this is going into the userspace ABI there's something seriously wrong... > What is currently in tree _does not work_, as there are two arizona > chips, and two "LDO1" regulators. (Doable) suggestions how to fix that > are welcome. To repeat what I said above, provide an interface which namespaces by device (as we normally do when we need to distinguish between multiple instances of the same device). Given that everything is part of the same device it's very easy to discover which device so it's clearly no problem when mapping the supplies. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Pavel Machek <pavel@ucw.cz> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com, Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Subject: Re: multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Date: Tue, 13 Oct 2015 12:53:55 +0100 [thread overview] Message-ID: <20151013115355.GC14956@sirena.org.uk> (raw) In-Reply-To: <20151012201137.GA7317@amd> [-- Attachment #1.1: Type: text/plain, Size: 1694 bytes --] On Mon, Oct 12, 2015 at 10:11:38PM +0200, Pavel Machek wrote: > On Mon 2015-10-12 16:47:15, Mark Brown wrote: > > On Mon, Oct 12, 2015 at 11:00:45AM +0200, Pavel Machek wrote: > > > static const struct regulator_desc arizona_ldo1_hc = { > > > - .name = "LDO1", > > No, you definitely shouldn't be doing this - the regulator names should > > reflect the names the device has in the datasheet to aid people in going > > from software to the hardware and back again. They shouldn't be > > dynamically generated at runtime. If you need to namespace by > device > They already are, see wm831x-ldo.c . No, that's a different case where we actually have a repeatable IP we can enumerate multiple instances of on a single piece of silicon which has multiple variants available. This is a single device with a single regulator on it. > > provide an interface which explicitly namespaces by device rather than > > hacking it into another interface, the usual thing is to use the struct > > device as the context. > I'll need some more help here. I need to use it from ALSA, so I don't > think I can influence that interface easily. Sorry? If this is going into the userspace ABI there's something seriously wrong... > What is currently in tree _does not work_, as there are two arizona > chips, and two "LDO1" regulators. (Doable) suggestions how to fix that > are welcome. To repeat what I said above, provide an interface which namespaces by device (as we normally do when we need to distinguish between multiple instances of the same device). Given that everything is part of the same device it's very easy to discover which device so it's clearly no problem when mapping the supplies. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --] [-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-10-13 11:54 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-14 11:54 System with multiple arizona (wm5102) codecs Pavel Machek 2015-09-14 11:52 ` Charles Keepax 2015-09-14 11:52 ` Charles Keepax 2015-09-14 13:31 ` Charles Keepax 2015-09-14 13:31 ` Charles Keepax 2015-09-14 20:11 ` Pavel Machek 2015-09-15 6:18 ` Pavel Machek 2015-09-15 8:06 ` Charles Keepax 2015-09-15 8:06 ` Charles Keepax 2015-09-15 8:35 ` Pavel Machek 2015-09-15 13:56 ` [alsa-devel] " Caleb Crome 2015-09-15 13:56 ` Caleb Crome 2015-09-15 14:09 ` [alsa-devel] " Mark Brown 2015-09-15 14:09 ` Mark Brown 2015-09-15 15:26 ` [alsa-devel] " Caleb Crome 2015-09-19 18:21 ` Mark Brown 2015-09-21 12:36 ` Pavel Machek 2015-10-12 9:00 ` multi-codec support for arizona-ldo1 was " Pavel Machek 2015-10-12 11:37 ` Charles Keepax 2015-10-12 11:37 ` Charles Keepax 2015-11-30 11:33 ` multi-card support for davinci-evm Pavel Machek 2015-11-30 11:37 ` multi-card support for arizona-core Pavel Machek 2015-11-30 11:37 ` Pavel Machek 2015-11-30 11:54 ` Mark Brown 2015-10-12 15:47 ` multi-codec support for arizona-ldo1 was Re: System with multiple arizona (wm5102) codecs Mark Brown 2015-10-12 20:11 ` Pavel Machek 2015-10-13 11:53 ` Mark Brown [this message] 2015-10-13 11:53 ` Mark Brown 2015-11-13 21:58 ` Pavel Machek 2015-11-13 22:53 ` Mark Brown 2015-11-14 7:44 ` Pavel Machek 2015-11-14 7:44 ` Pavel Machek 2015-11-14 12:39 ` Mark Brown 2015-11-14 17:59 ` Pavel Machek 2015-11-14 17:59 ` Pavel Machek 2015-11-14 18:49 ` Mark Brown 2015-11-14 21:16 ` Pavel Machek 2015-11-14 21:16 ` Pavel Machek 2015-11-15 0:14 ` Mark Brown 2015-11-15 0:14 ` Mark Brown 2015-11-16 7:45 ` Pavel Machek 2015-11-16 10:50 ` Mark Brown 2015-11-16 12:29 ` Pavel Machek 2015-11-16 12:29 ` Pavel Machek 2015-11-16 13:57 ` Charles Keepax 2015-11-16 13:57 ` Charles Keepax 2015-11-16 14:28 ` Charles Keepax 2015-11-16 14:28 ` Charles Keepax 2015-11-16 17:33 ` Mark Brown 2015-11-16 14:11 ` Charles Keepax 2015-11-16 14:11 ` Charles Keepax 2015-11-22 6:51 ` Pavel Machek 2015-11-22 6:51 ` Pavel Machek 2015-11-23 8:18 ` Lee Jones 2015-11-23 8:18 ` Lee Jones 2015-11-23 10:11 ` Pavel Machek 2015-11-23 10:25 ` Richard Fitzgerald 2015-11-23 10:25 ` Richard Fitzgerald 2015-11-23 11:30 ` Mark Brown 2015-11-23 11:46 ` Charles Keepax 2015-11-23 11:46 ` Charles Keepax 2015-11-23 14:31 ` Lee Jones 2015-11-23 15:00 ` Pavel Machek 2015-11-16 14:05 ` Charles Keepax 2015-11-16 14:05 ` Charles Keepax
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151013115355.GC14956@sirena.org.uk \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=ckeepax@opensource.wolfsonmicro.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.wolfsonmicro.com \ --cc=pavel@ucw.cz \ --cc=perex@perex.cz \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.