From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Qipeng Zha <qipeng.zha@intel.com>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit
Date: Tue, 8 Dec 2015 14:59:15 -0800 [thread overview]
Message-ID: <20151208225915.GA14939@malice.jf.intel.com> (raw)
In-Reply-To: <1449579438.30729.48.camel@linux.intel.com>
On Tue, Dec 08, 2015 at 02:57:18PM +0200, Andy Shevchenko wrote:
> On Mon, 2015-12-07 at 15:45 -0800, Darren Hart wrote:
> > On Tue, Dec 08, 2015 at 12:55:04AM +0800, Qipeng Zha wrote:
...
>
> > >
> > > res = platform_get_resource(pdev, IORESOURCE_MEM,
> > > - PLAT_RESOURCE_PUNIT_INTER_INDE
> > > X);
> > > + PLAT_RES_PUNIT_BIOS_INTER_INDE
> > > X);
> > > if (!res) {
> > > - dev_err(&pdev->dev, "Failed to get punit inter
> > > resource\n");
> > > + dev_err(&pdev->dev, "Failed to get res of punit
> > > BIOS inter\n");
>
> Darren, can you improve this phrasing, I didn't get what this message
> about?
I wasn't going to mention this unless there was sure to be a v9, it seems that
is likely, so...
Qipeng, in order to ensure the message to the user is clear, it is important not
to use abbreviations (especially non-obvious ones) like "inter" and "res". Note that the user will not necessarily have the sourcecode handy for context.
I believe this message is just attempting to the user that the
platform_get_resource message failed for some reason when attempting to get the
ACPI provided resource for the BIOS interface resource. There are two resources
for each, interface and data.
Without knowing the details of the internals, I would think the following might
be a better message?
dev_err(&pdev->dev, "Failed to get punit BIOS interface platform resource\n");
Similarly for all these messages.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-12-08 22:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 16:55 [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit Qipeng Zha
2015-12-07 16:55 ` [PATCH V8 2/2] platform:x86: add Intel P-Unit mailbox IPC driver Qipeng Zha
2015-12-07 23:45 ` [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit Darren Hart
2015-12-08 11:10 ` Andy Shevchenko
2015-12-08 12:57 ` Andy Shevchenko
2015-12-08 22:59 ` Darren Hart [this message]
2015-12-09 0:21 ` Darren Hart
2015-12-09 11:09 ` Andy Shevchenko
2015-12-09 16:33 ` Darren Hart
2015-12-08 13:19 ` Andy Shevchenko
2015-12-08 23:02 ` Darren Hart
2015-12-08 23:28 ` Darren Hart
2015-12-10 2:39 ` Zha, Qipeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208225915.GA14939@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.